From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: RFC: omit some variables from custom-save-variables Date: Mon, 22 Jun 2020 18:22:38 +0000 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: References: <4kr6525r.fsf@lifelogs.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="730"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: John Wiegley , Emacs Development To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 22 20:23:22 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnR6I-000Y1Y-9v for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Jun 2020 20:23:22 +0200 Original-Received: from localhost ([::1]:45258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnR6H-000434-Cs for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Jun 2020 14:23:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnR5g-0003HF-5e for emacs-devel@gnu.org; Mon, 22 Jun 2020 14:22:44 -0400 Original-Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:40969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnR5e-0006Uc-EK for emacs-devel@gnu.org; Mon, 22 Jun 2020 14:22:43 -0400 Original-Received: by mail-qk1-x735.google.com with SMTP id z63so4366422qkb.8 for ; Mon, 22 Jun 2020 11:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=CxBcbSq5YK5ybJ5hPlIP7f/Gga7XIYGmsXKBhHoPWtE=; b=TNw0ITXZudybqgA/LXVjLm6KSxRqgyYmtkKnxi7s2LI7zRsu0stO6OIQppLygO/qo1 klIeDzl0CgclhluSdid1F+YiWEt6/BpbtNE9JO6KuhVgz3QMobWFZ+GMMQvGz8GUEYXT RPP7fNubQapjUYOgydv/y9Nolqe1bs/Ak6t+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=CxBcbSq5YK5ybJ5hPlIP7f/Gga7XIYGmsXKBhHoPWtE=; b=I6BIu4EtbWrzU97sMNwZkIUJAFKsG6BVITy23jlp56gw+XJou19Gl9sT7m8DAO+UdZ lf9+VzVYtE6+SxZohgVVtdjwtEceeH83sO7xo9VbnSYYLiZoJqZsLbTgQPrzeS8PJDSb pfHZcGxOogJ4Up0dIy+oIj2kM1d/SePRWGt2kyQDRwL5LSy0+pKfpa0kAkKqqXoBtVOD aaQXqeHt/MZg3xOSBNdaVDFP/gejyzpvfF6rRnPadWIJBRuUAa0WIFtY/d+dZkO1M6Du P7kBCiTexYzkPMbcxNo70QvHLiifCTZ13U0mTmGKMLNvZj9mSMmS9POqns9mhmdOTmcx 9ZRw== X-Gm-Message-State: AOAM530gE4FTffVhOopoeOWPWbv25GJnHeD/ATAGlnExX7hbvrjGrWSZ bn+nAYp9ynPvECrKNZkIgji5Gw== X-Google-Smtp-Source: ABdhPJzg1zVASetXow9zrPVrXamqm59IU+ZaAKMSYQaqah1llS93bLplcBZs2NxMiYjunAfhKYLNLA== X-Received: by 2002:a37:b681:: with SMTP id g123mr16726590qkf.112.1592850160909; Mon, 22 Jun 2020 11:22:40 -0700 (PDT) Original-Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id f203sm8681337qke.135.2020.06.22.11.22.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jun 2020 11:22:39 -0700 (PDT) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never In-Reply-To: (Stefan Monnier's message of "Fri, 19 Jun 2020 17:26:06 -0400") Received-SPF: none client-ip=2607:f8b0:4864:20::735; envelope-from=tzz@lifelogs.com; helo=mail-qk1-x735.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252514 Archived-At: On Fri, 19 Jun 2020 17:26:06 -0400 Stefan Monnier wrote: SM> Hmm... my reflex would have been to make use-package use something like SM> (funcall (or (get variable 'custom-set) #'set-default) variable value) SM> instead of whichever other way it currently uses to set the variable. >> Does that omit the variable from the custom.el file? SM> Yes, as should be obvious at least in the case where it falls back on `set-default`. OK, it sounds like a better approach if it requires no core changes. I proposed the change in https://github.com/jwiegley/use-package/pull/850 and in my testing it behaved correctly. Ted