* Re: /srv/bzr/emacs/trunk r101625: Set up GnuTLS support.
[not found] <E1OzkYD-0004oM-MI@internal.in.savannah.gnu.org>
@ 2010-10-03 0:25 ` Glenn Morris
2010-10-03 12:34 ` Ted Zlatanov
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2010-10-03 0:25 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: emacs-devel
Somebody may have mentioned this already, but was the following a
by-hand change to src/config.in? That is not the right way to do it -
that file is generated by autoheader from configure.in. The "#define
LIBGNUTLS" stuff will get clobbered the next time someone regenerates
config.in. But it seems pointless anyway?
(Also this stuff needs a NEWS entry at some point.)
> revno: 101625
> committer: Ted Zlatanov <tzz at lifelogs.com>
> branch nick: quickfixes
> timestamp: Sun 2010-09-26 01:06:28 -0500
> message:
> Set up GnuTLS support.
[...]
> === modified file 'src/config.in'
> --- a/src/config.in 2010-09-10 16:44:35 +0000
> +++ b/src/config.in 2010-09-26 06:06:28 +0000
> @@ -255,6 +255,9 @@
> /* Define to 1 if you have a gif (or ungif) library. */
> #undef HAVE_GIF
>
> +/* Define if we have the GNU TLS library. */
> +#undef HAVE_GNUTLS
> +
> /* Define to 1 if you have the gpm library (-lgpm). */
> #undef HAVE_GPM
>
> @@ -1094,6 +1097,12 @@
> #include config_opsysfile
> #include config_machfile
>
> +#if HAVE_GNUTLS
> +#define LIBGNUTLS $(LIBGNUTLS_LIBS)
> +#else /* not HAVE_GNUTLS */
> +#define LIBGNUTLS
> +#endif /* not HAVE_GNUTLS */
> +
> /* Set up some defines, C and LD flags for NeXTstep interface on GNUstep.
> (There is probably a better place to do this, but right now the Cocoa
> side does this in s/darwin.h and we cannot
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /srv/bzr/emacs/trunk r101625: Set up GnuTLS support.
2010-10-03 0:25 ` /srv/bzr/emacs/trunk r101625: Set up GnuTLS support Glenn Morris
@ 2010-10-03 12:34 ` Ted Zlatanov
2010-10-03 12:51 ` Juanma Barranquero
2010-10-03 19:37 ` Glenn Morris
0 siblings, 2 replies; 9+ messages in thread
From: Ted Zlatanov @ 2010-10-03 12:34 UTC (permalink / raw)
To: emacs-devel
On Sat, 02 Oct 2010 20:25:00 -0400 Glenn Morris <rgm@gnu.org> wrote:
GM> Somebody may have mentioned this already, but was the following a
GM> by-hand change to src/config.in? That is not the right way to do it -
GM> that file is generated by autoheader from configure.in. The "#define
GM> LIBGNUTLS" stuff will get clobbered the next time someone regenerates
GM> config.in. But it seems pointless anyway?
I didn't know it was automatic since I don't know autoheader. Can you
check if everything works without those hand-added sections?
GM> (Also this stuff needs a NEWS entry at some point.)
Let me finish the API. I'll write a manual too. I know I've been slow.
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /srv/bzr/emacs/trunk r101625: Set up GnuTLS support.
2010-10-03 12:34 ` Ted Zlatanov
@ 2010-10-03 12:51 ` Juanma Barranquero
2010-10-04 0:56 ` Ted Zlatanov
2010-10-03 19:37 ` Glenn Morris
1 sibling, 1 reply; 9+ messages in thread
From: Juanma Barranquero @ 2010-10-03 12:51 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: emacs-devel
2010/10/3 Ted Zlatanov <tzz@lifelogs.com>:
> Let me finish the API.
Speaking of which... Why is gnutls_emacs_global_deinit() not called
from anywhere?
Juanma
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /srv/bzr/emacs/trunk r101625: Set up GnuTLS support.
2010-10-03 12:34 ` Ted Zlatanov
2010-10-03 12:51 ` Juanma Barranquero
@ 2010-10-03 19:37 ` Glenn Morris
2010-10-03 20:12 ` Eli Zaretskii
2010-10-04 15:06 ` Ted Zlatanov
1 sibling, 2 replies; 9+ messages in thread
From: Glenn Morris @ 2010-10-03 19:37 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: emacs-devel
Ted Zlatanov wrote:
> I didn't know it was automatic since I don't know autoheader. Can you
> check if everything works without those hand-added sections?
Running autoconf generates configure from configure.in.
Running autoheader generates src/config.in from configure.in.
AC_DEFINE statements in configure.in produce "#define foo"
statements in config.in. Hence the
AC_DEFINE(HAVE_GNUTLS, 1, [Define if using GnuTLS.])
in configure.in takes care of one of the hand-written sections.
If you really need to put anything beneath the "config_machfile" etc
stuff in config.in, you do it by adding to AH_BOTTOM in configure.in.
But you almost certainly don't need to do this. The code you have
there now has no effect, because nowhere in the C code is `LIBGNUTLS'
expanded, and even if it were, it expands to a shell variable
$(LIBGNUTLS_LIBS) which won't be set. The AC_SUBST(LIBGNUTLS_LIBS)
line handles substituting the necessary value in the Makefiles.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /srv/bzr/emacs/trunk r101625: Set up GnuTLS support.
2010-10-03 19:37 ` Glenn Morris
@ 2010-10-03 20:12 ` Eli Zaretskii
2010-10-04 15:06 ` Ted Zlatanov
1 sibling, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2010-10-03 20:12 UTC (permalink / raw)
To: Glenn Morris; +Cc: tzz, emacs-devel
> From: Glenn Morris <rgm@gnu.org>
> Date: Sun, 03 Oct 2010 15:37:18 -0400
> Cc: emacs-devel@gnu.org
>
> Ted Zlatanov wrote:
>
> > I didn't know it was automatic since I don't know autoheader. Can you
> > check if everything works without those hand-added sections?
>
> Running autoconf generates configure from configure.in.
> Running autoheader generates src/config.in from configure.in.
Doesn't "autoreconf" do both in one go?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /srv/bzr/emacs/trunk r101625: Set up GnuTLS support.
2010-10-03 12:51 ` Juanma Barranquero
@ 2010-10-04 0:56 ` Ted Zlatanov
0 siblings, 0 replies; 9+ messages in thread
From: Ted Zlatanov @ 2010-10-04 0:56 UTC (permalink / raw)
To: emacs-devel
On Sun, 3 Oct 2010 14:51:18 +0200 Juanma Barranquero <lekktu@gmail.com> wrote:
JB> 2010/10/3 Ted Zlatanov <tzz@lifelogs.com>:
>> Let me finish the API.
JB> Speaking of which...
It's almost done now :)
JB> Why is gnutls_emacs_global_deinit() not called from anywhere?
Because it's a global deinitialization. Since we don't unload GnuTLS
support currently, we don't need to do it. We may have to unload in the
future, though. So for now I left it in.
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /srv/bzr/emacs/trunk r101625: Set up GnuTLS support.
2010-10-03 19:37 ` Glenn Morris
2010-10-03 20:12 ` Eli Zaretskii
@ 2010-10-04 15:06 ` Ted Zlatanov
2010-10-04 19:04 ` Eli Zaretskii
1 sibling, 1 reply; 9+ messages in thread
From: Ted Zlatanov @ 2010-10-04 15:06 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
On Sun, 03 Oct 2010 15:37:18 -0400 Glenn Morris <rgm@gnu.org> wrote:
GM> Ted Zlatanov wrote:
>> I didn't know it was automatic since I don't know autoheader. Can you
>> check if everything works without those hand-added sections?
GM> Running autoconf generates configure from configure.in.
GM> Running autoheader generates src/config.in from configure.in.
...
GM> But you almost certainly don't need to do this. The code you have
GM> there now has no effect, because nowhere in the C code is `LIBGNUTLS'
GM> expanded, and even if it were, it expands to a shell variable
GM> $(LIBGNUTLS_LIBS) which won't be set. The AC_SUBST(LIBGNUTLS_LIBS)
GM> line handles substituting the necessary value in the Makefiles.
On Sun, 03 Oct 2010 22:12:27 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
EZ> Doesn't "autoreconf" do both in one go?
OK. So I should run `autoheader' or `autoreconf' and check in
src/config.in?
Thanks
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /srv/bzr/emacs/trunk r101625: Set up GnuTLS support.
2010-10-04 15:06 ` Ted Zlatanov
@ 2010-10-04 19:04 ` Eli Zaretskii
2010-10-10 5:21 ` Ted Zlatanov
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2010-10-04 19:04 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: emacs-devel
> From: Ted Zlatanov <tzz@lifelogs.com>
> Date: Mon, 4 Oct 2010 10:06:02 -0500
> Cc: emacs-devel@gnu.org
>
> EZ> Doesn't "autoreconf" do both in one go?
>
> OK. So I should run `autoheader' or `autoreconf' and check in
> src/config.in?
Yes. In general, whenever you change anything in the configury, run
either "autoreconf" or "autoconf" and "autoheader", and commit the
files it updates.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /srv/bzr/emacs/trunk r101625: Set up GnuTLS support.
2010-10-04 19:04 ` Eli Zaretskii
@ 2010-10-10 5:21 ` Ted Zlatanov
0 siblings, 0 replies; 9+ messages in thread
From: Ted Zlatanov @ 2010-10-10 5:21 UTC (permalink / raw)
To: emacs-devel
On Mon, 04 Oct 2010 21:04:11 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Ted Zlatanov <tzz@lifelogs.com>
>> Date: Mon, 4 Oct 2010 10:06:02 -0500
>> Cc: emacs-devel@gnu.org
>>
EZ> Doesn't "autoreconf" do both in one go?
>>
>> OK. So I should run `autoheader' or `autoreconf' and check in
>> src/config.in?
EZ> Yes. In general, whenever you change anything in the configury, run
EZ> either "autoreconf" or "autoconf" and "autoheader", and commit the
EZ> files it updates.
OK, it seems that Glenn Morris fixed it up already. I'll be careful
about that in the future.
Thanks
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-10-10 5:21 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1OzkYD-0004oM-MI@internal.in.savannah.gnu.org>
2010-10-03 0:25 ` /srv/bzr/emacs/trunk r101625: Set up GnuTLS support Glenn Morris
2010-10-03 12:34 ` Ted Zlatanov
2010-10-03 12:51 ` Juanma Barranquero
2010-10-04 0:56 ` Ted Zlatanov
2010-10-03 19:37 ` Glenn Morris
2010-10-03 20:12 ` Eli Zaretskii
2010-10-04 15:06 ` Ted Zlatanov
2010-10-04 19:04 ` Eli Zaretskii
2010-10-10 5:21 ` Ted Zlatanov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.