Frame resize hook?

Frame resize hook?

[Juan Pedro Bolivar Puente]

Hi,

I'm using Xmonad as window manager so tiling causes frames to get very
small sometimes, and if I'm working with ECB windows are messed
afterwards. I can fix it by calling ecb-redraw-layout, but I don't know
how to get that function called automatically on every resize of the
Emacs frame.

Any hints?

Many thanks,
JP

Re: Frame resize hook?

[Pascal J. Bourguignon]

Juan Pedro Bolivar Puente <magnicida@gmail.com> writes:

> I'm using Xmonad as window manager so tiling causes frames to get very
> small sometimes, and if I'm working with ECB windows are messed
> afterwards. I can fix it by calling ecb-redraw-layout, but I don't know
> how to get that function called automatically on every resize of the
> Emacs frame.
>
> Any hints?

Perhaps with an advice, but ISTR that advices are not called when the
function is called from within the C layer of emacs (the calls are
"open coded" there).  So it would work only if the frame resizing is
done from lisp code.

The functions to advice would be set-frame-size, set-frame-width and set-frame-height.
(perhaps also set-frame-position).

Cf. defadvice

Otherwise, you would have to patch the C code of these primitive functions.

-- 
__Pascal Bourguignon__

Re: Frame resize hook?

[Juan Pedro Bolivar Puente]

> 
> Perhaps with an advice, but ISTR that advices are not called when the
> function is called from within the C layer of emacs (the calls are
> "open coded" there).  So it would work only if the frame resizing is
> done from lisp code.
> 
> The functions to advice would be set-frame-size, set-frame-width and set-frame-height.
> (perhaps also set-frame-position).
> 
> Cf. defadvice
> 
> Otherwise, you would have to patch the C code of these primitive functions.
> 

I tried adding:

(defadvice set-frame-size (after jpb-advice-resize-1)
  (ecb-redraw-layout))
(defadvice set-frame-width (after jpb-advice-resize-2)
  (ecb-redraw-layout))
(defadvice set-frame-height (after jpb-advice-resize-2)
  (ecb-redraw-layout))
(ad-activate 'set-frame-size)
(ad-activate 'set-frame-width)
(ad-activate 'set-frame-height)

But, as you said, it only works when calling set-frame-xxx from Elisp
code, not on window manager events.

Thanks for the tip anyways, I didn't know about "advices".

JP

Re: Frame resize hook?

[Nikolaj Schumacher]

Juan Pedro Bolivar Puente <magnicida@gmail.com> wrote:

> Any hints?

The dirty way would be running a timer, checking if the window size
changed, and redrawing then...

regards,
Nikolaj Schumacher

Re: Frame resize hook?

[Lennart Borgman]

On Wed, Apr 22, 2009 at 8:02 PM, Nikolaj Schumacher <me@nschum.de> wrote:
> Juan Pedro Bolivar Puente <magnicida@gmail.com> wrote:
>
>> Any hints?
>
> The dirty way would be running a timer, checking if the window size
> changed, and redrawing then...

What about window-configuration-change-hook?

Re: Frame resize hook?

[Juan Pedro Bolivar Puente]

Lennart Borgman wrote:
> On Wed, Apr 22, 2009 at 8:02 PM, Nikolaj Schumacher <me@nschum.de> wrote:
>> Juan Pedro Bolivar Puente <magnicida@gmail.com> wrote:
>>
>>> Any hints?
>> The dirty way would be running a timer, checking if the window size
>> changed, and redrawing then...
> 
> What about window-configuration-change-hook?
> 
> 
> 

That hook is triggered on windows change, not a frame change.

JP

Re: Frame resize hook?

[Lennart Borgman]

On Thu, Apr 23, 2009 at 10:00 AM, Juan Pedro Bolivar Puente
<magnicida@gmail.com> wrote:
> Lennart Borgman wrote:
>> On Wed, Apr 22, 2009 at 8:02 PM, Nikolaj Schumacher <me@nschum.de> wrote:
>>> Juan Pedro Bolivar Puente <magnicida@gmail.com> wrote:
>>>
>>>> Any hints?
>>> The dirty way would be running a timer, checking if the window size
>>> changed, and redrawing then...
>>
>> What about window-configuration-change-hook?
>>
>>
>>
>
> That hook is triggered on windows change, not a frame change.

Yes, but a frame size change triggers windows changes. Does not that
happen for you?

Re: Frame resize hook?

[Juan Pedro Bolivar Puente]

Lennart Borgman wrote:
> On Thu, Apr 23, 2009 at 10:00 AM, Juan Pedro Bolivar Puente
> <magnicida@gmail.com> wrote:
>> Lennart Borgman wrote:
>>> On Wed, Apr 22, 2009 at 8:02 PM, Nikolaj Schumacher <me@nschum.de> wrote:
>>>> Juan Pedro Bolivar Puente <magnicida@gmail.com> wrote:
>>>>
>>>>> Any hints?
>>>> The dirty way would be running a timer, checking if the window size
>>>> changed, and redrawing then...
>>> What about window-configuration-change-hook?
>>>
>>>
>>>
>> That hook is triggered on windows change, not a frame change.
> 
> Yes, but a frame size change triggers windows changes. Does not that
> happen for you?
> 
> 
> 

Yes, but I get into infinite recursion and stack overflow as
ecb-layout-redraw also changes window configuration :p

JP

Re: Frame resize hook?

[Lennart Borgman]

On Thu, Apr 23, 2009 at 10:55 AM, Juan Pedro Bolivar Puente
<magnicida@gmail.com> wrote:
> Lennart Borgman wrote:
>> On Thu, Apr 23, 2009 at 10:00 AM, Juan Pedro Bolivar Puente
>> <magnicida@gmail.com> wrote:
>>> Lennart Borgman wrote:
>>>> On Wed, Apr 22, 2009 at 8:02 PM, Nikolaj Schumacher <me@nschum.de> wrote:
>>>>> Juan Pedro Bolivar Puente <magnicida@gmail.com> wrote:
>>>>>
>>>>>> Any hints?
>>>>> The dirty way would be running a timer, checking if the window size
>>>>> changed, and redrawing then...
>>>> What about window-configuration-change-hook?
>>>>
>>>>
>>>>
>>> That hook is triggered on windows change, not a frame change.
>>
>> Yes, but a frame size change triggers windows changes. Does not that
>> happen for you?
>>
>>
>>
>
> Yes, but I get into infinite recursion and stack overflow as
> ecb-layout-redraw also changes window configuration :p

You have to protect against that by let-binding the hook.

Re: Frame resize hook?

[Juan Pedro Bolivar Puente]

>>>
>> Yes, but I get into infinite recursion and stack overflow as
>> ecb-layout-redraw also changes window configuration :p
> 
> You have to protect against that by let-binding the hook.
> 
> 
> 

I don't understand very well what you mean. Can you please give me a
further explanation? I'm a newbie on elisp.

Thanks
JP

Re: Frame resize hook?

[Lennart Borgman]

On Thu, Apr 23, 2009 at 11:32 AM, Juan Pedro Bolivar Puente
<magnicida@gmail.com> wrote:
>
>>>>
>>> Yes, but I get into infinite recursion and stack overflow as
>>> ecb-layout-redraw also changes window configuration :p
>>
>> You have to protect against that by let-binding the hook.
>>
>>
>>
>
> I don't understand very well what you mean. Can you please give me a
> further explanation? I'm a newbie on elisp.

You can override the value of a a variable through dynamic binding,
see for example

  http://www.emacswiki.org/emacs/DynamicBindingVsLexicalBinding

In your case you can use something like this in the function
(your-hook-fun) you put in the hook:

(defun your-hook-fun ()
  (let ((window-configuration-change-hook nil))
    ...
    ))