From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.help Subject: Re: Help needed to simplify code for customisation Date: Tue, 10 Mar 2009 20:39:21 -0600 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1236739206 19901 80.91.229.12 (11 Mar 2009 02:40:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Mar 2009 02:40:06 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Wed Mar 11 03:41:22 2009 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LhENl-00012m-Vp for geh-help-gnu-emacs@m.gmane.org; Wed, 11 Mar 2009 03:41:22 +0100 Original-Received: from localhost ([127.0.0.1]:35485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhEMQ-0000X1-0I for geh-help-gnu-emacs@m.gmane.org; Tue, 10 Mar 2009 22:39:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhEM3-0000U8-Fk for help-gnu-emacs@gnu.org; Tue, 10 Mar 2009 22:39:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhEM2-0000S5-0S for help-gnu-emacs@gnu.org; Tue, 10 Mar 2009 22:39:35 -0400 Original-Received: from [199.232.76.173] (port=43058 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhEM1-0000Rw-QU for help-gnu-emacs@gnu.org; Tue, 10 Mar 2009 22:39:33 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:42492 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LhEM1-0001xd-EA for help-gnu-emacs@gnu.org; Tue, 10 Mar 2009 22:39:33 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LhELv-0002tt-IN for help-gnu-emacs@gnu.org; Wed, 11 Mar 2009 02:39:27 +0000 Original-Received: from c-67-190-36-32.hsd1.co.comcast.net ([67.190.36.32]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 11 Mar 2009 02:39:27 +0000 Original-Received: from kevin.d.rodgers by c-67-190-36-32.hsd1.co.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 11 Mar 2009 02:39:27 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 63 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-67-190-36-32.hsd1.co.comcast.net User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:62823 Archived-At: Richard Riley wrote: > Could someone please recommend the best way to remove the 3 similar lines > doing string-match on the "account" assign and iterate a variable list to > which I can "add-to-list" in other .el libraries for example? > > ,---- > | (if (message-mail-p) > | (save-excursion > | (let* ((from > | (save-restriction > | (message-narrow-to-headers) > | (message-fetch-field "from"))) > | (account > | (cond > | ((string-match ".*root.*" from)"richardriley") > | ((string-match ".*richardriley.*" from)"richardriley") > | ((string-match ".*rileyrgdev.*" from)"rileyrgdev") > | )) > | ) > | (setq message-sendmail-extra-arguments (list "-a" account)) > | ))) > | ) > `---- > > Thanks for any pointers, Why not use message-field-value instead of message-fetch-field, since it takes care of the narrowing as well? (string-match ".*foo.*" BAR) is equivalent to (string-match "foo" BAR) when used as a predicate. Your patterns are not very specific and admit false positives e.g. "FOO@BARrichardrileyBAZ.com" and "foo@bar.com (not richardriley)". At the very least, they should be anchored with \< and \>. Better yet, use mail-header-parse-address to split the header into MAILBOX and COMMENT components, then match only on MAILBOX. Here's what I came up with: (defvar my-sendmail-accounts '(("root" . "richardriley") ("richardriley") ("rileyrgdev")) "Alist of (MAILBOX . ACCOUNT) pairs. If ACCOUNT is nil, use MAILBOX.") (when (message-mail-p) (let ((sender (car (mail-header-parse-address (message-field-value "From")))) (accounts-regexp (format "\\`\\(%s\\)\\>" (mapconcat (function car) my-sendmail-accounts "\\|") ))) (when (string-match accounts-regexp sender) (let ((mailbox-account (assoc (match-string 0 sender) my-sendmail-accounts))) (setq message-sendmail-extra-arguments (list "-a" (or (cdr mailbox-account) (car mailbox-account)))))))) -- Kevin Rodgers Denver, Colorado, USA