From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#18173: 24.3; message-sendmail-extra-arguments not applied Date: Sat, 04 Oct 2014 16:05:30 -0400 Message-ID: References: <8738dfklm8.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1412453178 13315 80.91.229.3 (4 Oct 2014 20:06:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Oct 2014 20:06:18 +0000 (UTC) Cc: 18173@debbugs.gnu.org To: Myles English Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 04 22:06:10 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XaVah-0006rX-LY for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Oct 2014 22:06:07 +0200 Original-Received: from localhost ([::1]:45089 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaVag-00023A-N4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Oct 2014 16:06:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaVae-000234-Ab for bug-gnu-emacs@gnu.org; Sat, 04 Oct 2014 16:06:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XaVad-0007mO-GS for bug-gnu-emacs@gnu.org; Sat, 04 Oct 2014 16:06:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaVad-0007mJ-Dr for bug-gnu-emacs@gnu.org; Sat, 04 Oct 2014 16:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XaVac-00023D-HJ; Sat, 04 Oct 2014 16:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sat, 04 Oct 2014 20:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18173 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 18173-submit@debbugs.gnu.org id=B18173.14124531377849 (code B ref 18173); Sat, 04 Oct 2014 20:06:02 +0000 Original-Received: (at 18173) by debbugs.gnu.org; 4 Oct 2014 20:05:37 +0000 Original-Received: from localhost ([127.0.0.1]:33260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaVaB-00022T-7b for submit@debbugs.gnu.org; Sat, 04 Oct 2014 16:05:36 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:35000) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaVa7-00022J-FN for 18173@debbugs.gnu.org; Sat, 04 Oct 2014 16:05:32 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XaVa6-0005W6-UC; Sat, 04 Oct 2014 16:05:30 -0400 X-Spook: mindwar AGT. AMME Jyllandsposten digicash AFSPC X-Ran: 0~&{]H{?5\R}M;E>5fuxW^GOMuO,i]{c9K/cf:?jtmUBAN{N]D>SJ4WW_q?T6|5GD^sg~) X-Hue: green X-Attribution: GM In-Reply-To: <8738dfklm8.fsf@gmail.com> (Myles English's message of "Sat, 02 Aug 2014 15:13:23 +0100") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:94132 Archived-At: Myles English wrote: > (setq message-sendmail-extra-arguments '("-C" > "/home/myles/.config/msmtp/msmtprc")) > > But got the error "Sending...failed with exit value 78". > > The patch below prevents that error, allows the extra arguments to be > applied, and thus the config file to be found. Sorry, I'm being dense, because I cannot see a bug here, or how your patch makes any difference to anything. Can you explain? > --- message.el > +++ message.el > @@ -4723,9 +4723,7 @@ > (erase-buffer)))) > (let* ((default-directory "/") > (coding-system-for-write message-send-coding-system) > - (cpr (apply > - 'call-process-region > - (append > + (args (append > (list (point-min) (point-max) sendmail-program > nil errbuf nil "-oi") > message-sendmail-extra-arguments > @@ -4745,7 +4743,8 @@ > ;; For a resend, include the specific addresses. > (if resend-to-addresses > (list resend-to-addresses) > - '("-t")))))) > + '("-t")))) > + (cpr (apply 'call-process-region args))) > (unless (or (null cpr) (and (numberp cpr) (zerop cpr))) > (if errbuf (pop-to-buffer errbuf)) > (error "Sending...failed with exit value %d" cpr)))