From: Glenn Morris <rgm@gnu.org>
To: Myles English <mylesenglish@gmail.com>
Cc: 18173@debbugs.gnu.org
Subject: bug#18173: 24.3; message-sendmail-extra-arguments not applied
Date: Sat, 04 Oct 2014 16:05:30 -0400 [thread overview]
Message-ID: <go61fzios5.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <8738dfklm8.fsf@gmail.com> (Myles English's message of "Sat, 02 Aug 2014 15:13:23 +0100")
Myles English wrote:
> (setq message-sendmail-extra-arguments '("-C"
> "/home/myles/.config/msmtp/msmtprc"))
>
> But got the error "Sending...failed with exit value 78".
>
> The patch below prevents that error, allows the extra arguments to be
> applied, and thus the config file to be found.
Sorry, I'm being dense, because I cannot see a bug here, or how your
patch makes any difference to anything. Can you explain?
> --- message.el
> +++ message.el
> @@ -4723,9 +4723,7 @@
> (erase-buffer))))
> (let* ((default-directory "/")
> (coding-system-for-write message-send-coding-system)
> - (cpr (apply
> - 'call-process-region
> - (append
> + (args (append
> (list (point-min) (point-max) sendmail-program
> nil errbuf nil "-oi")
> message-sendmail-extra-arguments
> @@ -4745,7 +4743,8 @@
> ;; For a resend, include the specific addresses.
> (if resend-to-addresses
> (list resend-to-addresses)
> - '("-t"))))))
> + '("-t"))))
> + (cpr (apply 'call-process-region args)))
> (unless (or (null cpr) (and (numberp cpr) (zerop cpr)))
> (if errbuf (pop-to-buffer errbuf))
> (error "Sending...failed with exit value %d" cpr)))
next prev parent reply other threads:[~2014-10-04 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 14:13 bug#18173: 24.3; message-sendmail-extra-arguments not applied Myles English
2014-10-04 20:05 ` Glenn Morris [this message]
2014-10-04 21:25 ` Myles English
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=go61fzios5.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=18173@debbugs.gnu.org \
--cc=mylesenglish@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.