From: Glenn Morris <rgm@gnu.org>
To: Christopher Wellons <wellons@nullprogram.com>
Cc: 24494@debbugs.gnu.org
Subject: bug#24494: 24.4; Trailing comma in emacs-module.h
Date: Mon, 12 Dec 2016 17:35:53 -0500 [thread overview]
Message-ID: <g47f743hdi.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87fuotnupa.fsf@wellocc1-ares.jhuapl.edu> (Christopher Wellons's message of "Wed, 21 Sep 2016 11:22:57 -0400")
Christopher Wellons wrote:
> Building Emacs itself now requires a C99 compiler, but this requirement
> needn't extend to dynamic modules. Removing a trailing comma (see patch)
> makes emacs-module.h C89/C90 compatible, allowing modules to be built
> using older C compilers. Trailing commas weren't permitted until C99.
Thanks for the report. I don't have an opinion, but some comments:
1) I think it's going to be hard for developers to remember to use
different conventions for emacs-module.h, so C99-isms are likely to
creep back in.
2) Are people really likely to be building Emacs modules with set-ups
that can't build Emacs itself?
3) It seems this feature was supported by gcc since 0.9? Ie, forever?
https://www.gnu.org/software/gcc/c99status.html
Hopefully someone who does have an opinion will quickly either fix or
wontfix this issue. :)
> diff --git a/src/emacs-module.h b/src/emacs-module.h
> --- a/src/emacs-module.h
> +++ b/src/emacs-module.h
> @@ -67,7 +67,7 @@ enum emacs_funcall_exit
> emacs_funcall_exit_signal = 1,
>
> /* Function has exit using `throw'. */
> - emacs_funcall_exit_throw = 2,
> + emacs_funcall_exit_throw = 2
> };
>
> struct emacs_env_25
next prev parent reply other threads:[~2016-12-12 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 15:22 bug#24494: 24.4; Trailing comma in emacs-module.h Christopher Wellons
2016-12-12 22:35 ` Glenn Morris [this message]
2017-07-01 20:50 ` npostavs
2017-07-02 15:28 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g47f743hdi.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=24494@debbugs.gnu.org \
--cc=wellons@nullprogram.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.