From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Warnings about keymaps Date: Thu, 17 Sep 2009 03:32:35 -0400 Message-ID: References: <83ocph26p7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253174094 22054 80.91.229.12 (17 Sep 2009 07:54:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Sep 2009 07:54:54 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 17 09:54:47 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MoBpH-0002OL-2B for ged-emacs-devel@m.gmane.org; Thu, 17 Sep 2009 09:54:47 +0200 Original-Received: from localhost ([127.0.0.1]:59989 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoBpG-000500-Li for ged-emacs-devel@m.gmane.org; Thu, 17 Sep 2009 03:54:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoBnF-0004On-MP for emacs-devel@gnu.org; Thu, 17 Sep 2009 03:52:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoBnA-0004MR-3E for emacs-devel@gnu.org; Thu, 17 Sep 2009 03:52:40 -0400 Original-Received: from [199.232.76.173] (port=45750 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoBn9-0004ML-Sq for emacs-devel@gnu.org; Thu, 17 Sep 2009 03:52:35 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:42668) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MoBn8-0007Ye-OQ for emacs-devel@gnu.org; Thu, 17 Sep 2009 03:52:35 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MoBTn-0005Py-98; Thu, 17 Sep 2009 03:32:35 -0400 X-Spook: propaganda kilderkin JUWTF Bruxelles Becker kibo Ortega X-Ran: E{<-O3N+HE;8D]4K"N>91K'=a@=@^:cL.$U9hG:?Fw8E7iE_0}~MyWX0VaBefRd^tZr\|# X-Hue: black X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115404 Archived-At: Stefan Monnier wrote: > - most importantly: it doesn't solve the problem at hand which is how > to get rid of the other warning. The other warning? > - what's its use? It's not like we've seen lots of bugs where people > use both defconst and defvar for a variable. It simply replaces the current "variable assignment to a constant" warning with a slightly more informative one, as you suggested. > - Finally, if the defconst+defvar is really what you want to do (as in > the present case where the defconst and the defvar both come from > macros that we may not want to change), how do you silence > the warning? The same way you silence the current one about variable assignment to a constant. :) I don't think is a particularly useful change. I think it would be better to change define-derived-mode to not defvar the map if it is already defined; or to change easy-mode-defmap to not use defconst (are you saying users should not add key bindings to log-edit-mode-map, for example?).