From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.help Subject: Re: kill-region defadvice Date: Sun, 08 Jun 2008 14:51:02 -0600 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1212958310 32310 80.91.229.12 (8 Jun 2008 20:51:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Jun 2008 20:51:50 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sun Jun 08 22:52:32 2008 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K5RsL-00037w-2t for geh-help-gnu-emacs@m.gmane.org; Sun, 08 Jun 2008 22:52:29 +0200 Original-Received: from localhost ([127.0.0.1]:54483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5RrY-0000mt-1D for geh-help-gnu-emacs@m.gmane.org; Sun, 08 Jun 2008 16:51:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K5RrF-0000mk-Rv for help-gnu-emacs@gnu.org; Sun, 08 Jun 2008 16:51:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K5RrE-0000mP-Ih for help-gnu-emacs@gnu.org; Sun, 08 Jun 2008 16:51:21 -0400 Original-Received: from [199.232.76.173] (port=46609 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5RrE-0000mL-8h for help-gnu-emacs@gnu.org; Sun, 08 Jun 2008 16:51:20 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:53621 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K5RrE-0004rO-8x for help-gnu-emacs@gnu.org; Sun, 08 Jun 2008 16:51:20 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1K5Rr6-0004Ly-LB for help-gnu-emacs@gnu.org; Sun, 08 Jun 2008 20:51:12 +0000 Original-Received: from c-67-190-29-163.hsd1.co.comcast.net ([67.190.29.163]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 08 Jun 2008 20:51:12 +0000 Original-Received: from kevin.d.rodgers by c-67-190-29-163.hsd1.co.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 08 Jun 2008 20:51:12 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-67-190-29-163.hsd1.co.comcast.net User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) In-Reply-To: X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:54629 Archived-At: Nikolaj Schumacher wrote: > Kevin Rodgers wrote: > >> Nikolaj Schumacher wrote: >>> Joe wrote: >>> >>>> Originally I did this by writing a new function that checked >>>> if the mark was active. However, I think that using defadvice is a >>>> better solution but I got stuck while trying to write it. >>> No, it's not! By using advice, you modify the kill-region function and >>> risk that any command using it will backward-kill-word instead. >> Just write the advice as >> >> (if (and (interactive-p) mark-active) >> ad-do-it >> (backward-kill-word 1)) > > Still not a good idea. > `interactive-p' will return nil when used in a keyboard macro. That > will most likely cause unintended behavior at some point. (if (and (or (interactive-p) executing-kbd-macro) mark-active) ... -- Kevin Rodgers Denver, Colorado, USA