From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Whitespace in `${srcdir}' during `configure' Date: Mon, 10 Nov 2014 14:25:03 -0500 Message-ID: References: <5460673E.8000002@cs.ucla.edu> <83389rnl75.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1415647519 23410 80.91.229.3 (10 Nov 2014 19:25:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Nov 2014 19:25:19 +0000 (UTC) Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel , Yuri Khan To: Alexander Shukaev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 10 20:25:13 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XnuaN-0001X5-Aq for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2014 20:25:11 +0100 Original-Received: from localhost ([::1]:44797 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnuaM-000186-QD for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2014 14:25:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnuaI-00014G-CO for emacs-devel@gnu.org; Mon, 10 Nov 2014 14:25:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XnuaH-0001l4-6Y for emacs-devel@gnu.org; Mon, 10 Nov 2014 14:25:06 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnuaH-0001kg-4F for emacs-devel@gnu.org; Mon, 10 Nov 2014 14:25:05 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XnuaF-0004Jk-Jx; Mon, 10 Nov 2014 14:25:03 -0500 X-Spook: sweep TWA ARPA world domination encryption Kh-11 Downing X-Ran: y\HZGu&)UriQ}FF9EM">\w,MAF_+i.%P=8(ghE`V3-sOhm%8>`&*(cBi6G/iUev{N\&B6u X-Hue: red X-Attribution: GM In-Reply-To: Glenn Morris's message of "Mon\, 10 Nov 2014 14\:13\:30 -0500" User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176706 Archived-At: Oh now, I see. I guess you were using Emacs 24.4 or emacs-24. In that branch . $srcdir/nt/mingw-cfg.site indeed comes before "checking whether build environment is sane" (via AM_SANITY_CHECK from AM_INIT_AUTOMAKE). In trunk, it comes after. So in that branch, we should indeed either quote that one reference to srcdir, or move it after AM_INIT_AUTOMAKE (that change was already made in trunk 2014-06-10). PS Quoting is not always necessary, eg it's not needed in case arguments and on the RHS of assignments: https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Shell-Substitutions.html So AFAICS none of the other changes you suggest would be necessary (even if srcdir could contain spaces) apart from the gdbinit one. But by that stage, we are sure srcdir has no spaces.