all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Alexander Shukaev <haroogan@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	eggert@cs.ucla.edu, emacs-devel <emacs-devel@gnu.org>,
	Yuri Khan <yuri.v.khan@gmail.com>
Subject: Re: Whitespace in `${srcdir}' during `configure'
Date: Mon, 10 Nov 2014 14:25:03 -0500	[thread overview]
Message-ID: <g18ujiq2nk.fsf@fencepost.gnu.org> (raw)
In-Reply-To: Glenn Morris's message of "Mon\, 10 Nov 2014 14\:13\:30 -0500"


Oh now, I see.

I guess you were using Emacs 24.4 or emacs-24.

In that branch

  . $srcdir/nt/mingw-cfg.site

indeed comes before "checking whether build environment is sane" (via
AM_SANITY_CHECK from AM_INIT_AUTOMAKE). In trunk, it comes after.

So in that branch, we should indeed either quote that one reference to
srcdir, or move it after AM_INIT_AUTOMAKE (that change was already made
in trunk 2014-06-10).

PS Quoting is not always necessary, eg it's not needed in case
arguments and on the RHS of assignments:

https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Shell-Substitutions.html

So AFAICS none of the other changes you suggest would be necessary (even
if srcdir could contain spaces) apart from the gdbinit one. But by that
stage, we are sure srcdir has no spaces.



  reply	other threads:[~2014-11-10 19:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10  2:28 Whitespace in `${srcdir}' during `configure' Alexander Shukaev
2014-11-10  7:14 ` Glenn Morris
2014-11-10  7:20   ` Paul Eggert
2014-11-10  8:26     ` Glenn Morris
2014-11-10 14:28       ` Yuri Khan
2014-11-10 15:12         ` Eli Zaretskii
2014-11-10 16:03           ` Alexander Shukaev
2014-11-10 16:27             ` Eli Zaretskii
2014-11-10 17:17             ` Glenn Morris
2014-11-10 18:04               ` Alexander Shukaev
2014-11-10 19:25                 ` Glenn Morris [this message]
2014-11-10 19:39                   ` Glenn Morris
2014-11-17  2:24                     ` Glenn Morris
2014-11-10 10:47     ` Eli Zaretskii
2014-11-10  7:17 ` Paul Eggert
2014-11-10  7:24   ` Glenn Morris
2014-11-10  9:04     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=g18ujiq2nk.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=haroogan@gmail.com \
    --cc=yuri.v.khan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.