bug#47501: [PATCH] Do not search the global keymap in project--keymap-prompt

[Dario Gjorgjevski <dario.gjorgjevski@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

Hi,

project--keymap-prompt searches project-prefix-map *plus* the global
keymap when constructing the prompt for project-switch-command.  This
can result in weird behavior; for example,

    (global-set-key (kbd "M-s r") 'rgrep)
    (require 'project)
    (define-key project-prefix-map (kbd "<f5>") 'rgrep)
    (push '(rgrep "rgrep") project-switch-commands)

might (or will?) cause project-switch-project to display "[M-s r] rgrep"
instead of the expected "[<f5>] rgrep".

The attached patch fixes the issue as per the documentation of
`where-is-internal'.

Best regards,
Dario


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Do not search the global keymap in project--keymap-prompt --]
[-- Type: text/x-diff, Size: 1088 bytes --]

From 6e63d66b85d702abc72a32bcbb4d4f00fd6e2a21 Mon Sep 17 00:00:00 2001
From: Dario Gjorgjevski <dario.gjorgjevski+git@gmail.com>
Date: Tue, 30 Mar 2021 18:50:23 +0200
Subject: [PATCH] Do not search the global keymap in project--keymap-prompt

* lisp/progmodes/project.el: (project--keymap-prompt) Pass
project--keymap-prompt as a list to where-is-internal so that the
global keymap is not searched at all.
---
 lisp/progmodes/project.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 4101962..e0d5412 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -1321,7 +1321,7 @@ are legal even if they aren't listed in the dispatch menu."
                key tmp)))
      (let ((key (if key
                     (vector key)
-                  (where-is-internal cmd project-prefix-map t))))
+                  (where-is-internal cmd (list project-prefix-map) t))))
        (format "[%s] %s"
                (propertize (key-description key) 'face 'bold)
                label)))
-- 
2.31.0


[-- Attachment #3: Type: text/plain, Size: 128 bytes --]


-- 
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid