From: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: 38294@debbugs.gnu.org
Subject: bug#38294: [PATCH] Handle killing of virtual buffers in Ido
Date: Wed, 22 Jan 2020 09:21:30 +0100 [thread overview]
Message-ID: <fv2zojftg7zyt1.fsf@gmail.com> (raw)
In-Reply-To: <87a76it1hi.fsf@marxist.se> (Stefan Kangas's message of "Mon, 20 Jan 2020 19:40:57 +0100")
Hi Stefan,
Thanks a lot for getting back to me.
> I noticed that you have gotten no reply here. Could you please
> describe what problem it is you are solving, is this fixing a bug or
> adding a new feature?
I would say this neither fixes a bug nor introduces a new feature;
merely makes ‘ido-kill-buffer’ behave as I expect it to.
> How can I test that this code works as advertised, preferably starting
> from "emacs -Q"? Please give a step by step description, including a
> description of what happens before and after applying your patch.
What follows is a way to reproduce this scenario, assuming the file
‘foo’ does not exist.
Start by
M-x recentf-mode <RET>
M-x ido-mode <RET>
M-: (setq ido-use-virtual-buffers t) <RET>
C-x C-f foo <RET> <RET>
C-x C-s
C-x k <RET>
Now, ‘foo’ is a _virtual buffer_ in the terminology of Ido, and since we
have ‘ido-use-virtual-buffers’ set to t, we should be able to operate on
it: switch to it or kill it. Switching works fine; however, *killing is
a no-op*.
At this point, when you do
C-x k foo <RET>
you will notice that ‘foo’ remains in the list of buffers, despite being
“killed.” You will still see when doing C-x b or C-x k. In fact, you
can repeat the above step ad infinitum.
What this patch changes is exactly this behavior: once a virtual buffer
has been “killed” from C-x k, it no longer appears in the list of
buffers.
Let me know if this makes sense.
Best regards,
Dario
--
dario.gjorgjevski@gmail.com :: +49 1525 8666837
% gpg --keyserver 'hkps://hkps.pool.sks-keyservers.net' \
\`> --recv-keys '744A4F0B4F1C9371'
next prev parent reply other threads:[~2020-01-22 8:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 8:56 bug#38294: [PATCH] Handle killing of virtual buffers in Ido Dario Gjorgjevski
2020-01-20 18:40 ` Stefan Kangas
2020-01-22 8:21 ` Dario Gjorgjevski [this message]
2020-01-22 9:00 ` Stefan Kangas
2020-08-09 13:20 ` Lars Ingebrigtsen
2020-08-12 22:01 ` Stefan Kangas
2020-08-13 8:16 ` Lars Ingebrigtsen
2020-08-13 8:37 ` Stefan Kangas
2020-08-13 8:39 ` Lars Ingebrigtsen
2020-08-13 9:50 ` Dario Gjorgjevski
2020-08-13 11:04 ` Stefan Kangas
2020-08-14 9:23 ` Dario Gjorgjevski
2020-08-14 11:00 ` Lars Ingebrigtsen
2020-08-14 16:14 ` Stefan Kangas
2020-08-14 21:58 ` Dario Gjorgjevski
2020-08-14 22:56 ` Stefan Kangas
2020-08-15 8:03 ` Dario Gjorgjevski
2020-08-15 10:29 ` Lars Ingebrigtsen
2020-08-15 14:03 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fv2zojftg7zyt1.fsf@gmail.com \
--to=dario.gjorgjevski@gmail.com \
--cc=38294@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.