From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dario Gjorgjevski Newsgroups: gmane.emacs.bugs Subject: bug#38294: [PATCH] Handle killing of virtual buffers in Ido Date: Wed, 20 Nov 2019 09:56:43 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="2092"; mail-complaints-to="usenet@blaine.gmane.org" To: 38294@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 20 09:58:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXLoR-0000Qq-Cg for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 09:58:11 +0100 Original-Received: from localhost ([::1]:54914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXLoQ-0002oB-3V for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 03:58:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38072) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXLoK-0002o5-BA for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:58:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXLoJ-0004V2-7a for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:58:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40143) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXLoJ-0004Uw-2c for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:58:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXLoI-0004bf-Vo for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:58:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dario Gjorgjevski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2019 08:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157424022617643 (code B ref -1); Wed, 20 Nov 2019 08:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Nov 2019 08:57:06 +0000 Original-Received: from localhost ([127.0.0.1]:48964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXLnL-0004aS-0h for submit@debbugs.gnu.org; Wed, 20 Nov 2019 03:57:06 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:37626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXLnJ-0004a3-Lp for submit@debbugs.gnu.org; Wed, 20 Nov 2019 03:57:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37814) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXLnI-0002a3-CP for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:57:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXLnF-0003Et-TO for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:57:00 -0500 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:50520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXLnD-00037y-LK for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:56:56 -0500 Original-Received: by mail-wm1-x32b.google.com with SMTP id l17so6107665wmh.0 for ; Wed, 20 Nov 2019 00:56:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=c7hG6Ch/G92qcCTc6TNkznR3sjDS0WaJOPFJq41eOvA=; b=tDwLyy3H5Rxvg39GuP04aKsPZrA3MuwR1LdDr5oxd31SU+nEbZlKGFGr1G7z13KGmp 7URxaTEm6BRwH/0eJ56VZusm5oaZ07vkgkNc1GJROomnfPgphC/eE0Ne4WblnfqQcHMh vaCRAFoAYfGd5tuMk4/s830jlIFVCbyiW6pislvyX+URBYNgfEjCY8h4nBAKDRKupU88 atJbe0ESvCy/hRDjbxXkseB4aupM/4jV95AWr8xSzsxmbAZL37xbe2DjT5Mm/6nSkykx p+CZd8F0UZS811/yhZ7MjCiKmTCptfbZgXpSb/4fvqpu2R66gOlOQm5iUn+VBxLHaR6d hD5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=c7hG6Ch/G92qcCTc6TNkznR3sjDS0WaJOPFJq41eOvA=; b=BdEQT+yvog81GXQ42DRpJN194jxDDmcx2CYO16kD9lbdq9KGIxhHsNd5NEHTpK+nyR a6qHE7EOJa43LoxiJBhQKxlDnf48QU5mNzziD4k3UbyT+8vX1g/jgdB1Z/8esnHKdSPw Fu1FosLmMSh/wSc6XIl+hCsQVfe9zmfPJ9uR63HorB6WP0e/Bss51PM9i9jHCtd1oxl6 ZI1yh+AD2JyzZjvidROxm0TY0UCmjmyh52+2S25pSBYbOw1/yCjJyAI4cYtZ+FPANI2L o1fdZMDJEodXSeeQc8rk/RieawRKHzZeOqf7okLk9MhaTHB3PE4FgSWLferaWPuwo1Gp gyAA== X-Gm-Message-State: APjAAAVltCJU99PBD9567DsgBsnJ6cRClD6OBhKfwvyc4FTiLhTHDsZp P2WEi2cIr3IwJRGeyMalyJMDLU4y X-Google-Smtp-Source: APXvYqyO4CAATQFYVa8l/jmpqikD4pEkoaLMy8O7tZboiSwXxY6Wf92BDPx7lCeGYz9C7zmfe3Q3Sw== X-Received: by 2002:a05:600c:2253:: with SMTP id a19mr1799018wmm.97.1574240211447; Wed, 20 Nov 2019 00:56:51 -0800 (PST) Original-Received: from ZALANDO-31298 ([185.85.220.254]) by smtp.gmail.com with ESMTPSA id d7sm30885720wrx.11.2019.11.20.00.56.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 00:56:50 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172044 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Currently, =E2=80=98ido-kill-buffer=E2=80=99 does essentially nothing to vi= rtual buffers. (They are visited and then immediately killed.) The attached patch changes that so that they are instead removed from =E2=80=98recentf-l= ist=E2=80=99, akin to =E2=80=98ido-kill-buffer-at-head=E2=80=99. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Handle-killing-of-virtual-buffers-in-Ido.patch Content-Description: Handle killing of virtual buffers in Ido >From 4295cac14ea280d43c0aa493520543aa403a4c2e Mon Sep 17 00:00:00 2001 From: Dario Gjorgjevski Date: Wed, 20 Nov 2019 09:34:58 +0100 Subject: [PATCH] Handle killing of virtual buffers in Ido To: bug-gnu-emacs@gnu.org * lisp/ido.el (ido-buffer-internal): Handle killing of virtual buffers as a special case. (ido-visit-buffer): Document the special case. --- lisp/ido.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/ido.el b/lisp/ido.el index 79f259b819..bf3f57883d 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -2286,7 +2286,10 @@ ido-buffer-internal ((and ido-enable-virtual-buffers ido-virtual-buffers (setq filename (assoc buf ido-virtual-buffers))) - (ido-visit-buffer (find-file-noselect (cdr filename)) method t)) + (if (eq method 'kill) + (setq recentf-list + (delete (cdr filename) recentf-list)) + (ido-visit-buffer (find-file-noselect (cdr filename)) method t))) ((and (eq ido-create-new-buffer 'prompt) (null require-match) @@ -4128,6 +4131,8 @@ ido-visit-buffer (setq buffer (buffer-name buffer))) (let (win newframe) (cond + ;; "killing" of virtual buffers is handled in + ;; `ido-buffer-internal' ((eq method 'kill) (if record (ido-record-command 'kill-buffer buffer)) -- 2.17.1 --=-=-=--