* bug#48026: [PATCH] Possible typo in tramp-get-remote-gid
@ 2021-04-26 7:10 Dario Gjorgjevski
2021-04-26 8:00 ` Michael Albinus
0 siblings, 1 reply; 2+ messages in thread
From: Dario Gjorgjevski @ 2021-04-26 7:10 UTC (permalink / raw)
To: 48026
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
Hi,
I was browsing through TRAMP's source code and noticed a possible typo
in tramp-get-remote-gid. Please note that I have almost no familiarity
with the code, so it may well not even be a typo.
Here is what I am talking about:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix typo in tramp-get-remote-gid --]
[-- Type: text/x-diff, Size: 969 bytes --]
From 87ed8e1e19fd4ddb0922d907a45569c61598369d Mon Sep 17 00:00:00 2001
From: Dario Gjorgjevski <dario.gjorgjevski+git@gmail.com>
Date: Mon, 26 Apr 2021 09:01:51 +0200
Subject: [PATCH] Fix typo in tramp-get-remote-gid
* lisp/net/tramp.el (tramp-get-remote-gid): Pass the correct operation
to find-file-name-handler.
---
lisp/net/tramp.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index a411aaf..dc34b8f 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -5080,7 +5080,7 @@ ID-FORMAT valid values are `string' and `integer'."
(or (when-let
((handler
(find-file-name-handler
- (tramp-make-tramp-file-name vec) 'tramp-get-remote-uid)))
+ (tramp-make-tramp-file-name vec) 'tramp-get-remote-gid)))
(funcall handler #'tramp-get-remote-gid vec id-format))
;; Ensure there is a valid result.
(and (equal id-format 'integer) tramp-unknown-id-integer)
--
2.31.GIT
[-- Attachment #3: Type: text/plain, Size: 149 bytes --]
Best regards,
Dario
--
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#48026: [PATCH] Possible typo in tramp-get-remote-gid
2021-04-26 7:10 bug#48026: [PATCH] Possible typo in tramp-get-remote-gid Dario Gjorgjevski
@ 2021-04-26 8:00 ` Michael Albinus
0 siblings, 0 replies; 2+ messages in thread
From: Michael Albinus @ 2021-04-26 8:00 UTC (permalink / raw)
To: Dario Gjorgjevski; +Cc: 48026-done
Version: 28.1
Dario Gjorgjevski <dario.gjorgjevski@gmail.com> writes:
> Hi,
Hi Dario,
> I was browsing through TRAMP's source code and noticed a possible typo
> in tramp-get-remote-gid. Please note that I have almost no familiarity
> with the code, so it may well not even be a typo.
It is a typo, indeed. Thanks for reporting!
I've pushed your patch to master, closing the bug.
> Best regards,
> Dario
Best regards, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-26 8:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-26 7:10 bug#48026: [PATCH] Possible typo in tramp-get-remote-gid Dario Gjorgjevski
2021-04-26 8:00 ` Michael Albinus
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.