From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#26100: Switch from Automake to GNU Make Date: Wed, 15 Mar 2017 20:10:25 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489623069 24182 195.159.176.226 (16 Mar 2017 00:11:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Mar 2017 00:11:09 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 26100@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 16 01:11:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coJ0S-0005aI-0P for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Mar 2017 01:11:04 +0100 Original-Received: from localhost ([::1]:40072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coJ0X-0005As-Ur for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Mar 2017 20:11:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coJ0S-0005Ac-Bg for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2017 20:11:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coJ0Q-0000YK-NO for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2017 20:11:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1coJ0Q-0000YD-Eq for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2017 20:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1coJ0Q-0004bZ-A5 for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2017 20:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Mar 2017 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26100 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 26100-submit@debbugs.gnu.org id=B26100.148962303817662 (code B ref 26100); Thu, 16 Mar 2017 00:11:02 +0000 Original-Received: (at 26100) by debbugs.gnu.org; 16 Mar 2017 00:10:38 +0000 Original-Received: from localhost ([127.0.0.1]:57692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coJ02-0004an-49 for submit@debbugs.gnu.org; Wed, 15 Mar 2017 20:10:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coJ00-0004aZ-P8 for 26100@debbugs.gnu.org; Wed, 15 Mar 2017 20:10:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coIzu-0000RX-Ij for 26100@debbugs.gnu.org; Wed, 15 Mar 2017 20:10:31 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coIzq-0000R7-Tm; Wed, 15 Mar 2017 20:10:26 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1coIzq-0003ri-2l; Wed, 15 Mar 2017 20:10:26 -0400 X-Spook: PLF NOC Mossad Vince Foster Domestic Nuclear Detection X-Ran: qyJt-y_C (Paul Eggert's message of "Tue, 14 Mar 2017 17:16:21 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130630 Archived-At: Paul Eggert wrote: > Attached is a patch to change the Emacs build procedure to use GNU > Make instead of Automake Thanks, great news! Nitpicks below. > --- a/Makefile.in > +++ b/Makefile.in > @@ -73,10 +73,6 @@ CDPATH= > cache_file = @cache_file@ > CONFIGURE_FLAGS = --cache-file=$(cache_file) > > -AUTOCONF = @AUTOCONF@ [...] > -AUTOCONF_INPUTS = $(srcdir)/configure.ac $(srcdir)/aclocal.m4 > - > -$(srcdir)/configure: $(AUTOCONF_INPUTS) > - cd ${srcdir} && ${AUTOCONF} > - [...] > +$(srcdir)/configure $(srcdir)/src/stamp-h.in: \ > + $(srcdir)/configure.ac $(srcdir)/m4/*.m4 > + cd $(srcdir) && ./autogen.sh autoconf autogen.sh passes "-f" to autoreconf, so the new version will be more aggressive about updating than the old version was. (Also, this hunk isn't directly related to the overall change, is it?) > $(srcdir)/src/config.in: $(srcdir)/src/stamp-h.in > @ # Usually, there's no need to rebuild src/config.in just > @ # because stamp-h.in has changed (since building stamp-h.in > @ # refreshes config.in as well), but if config.in is missing > @ # then we really need to do something more. > - $(if $(wildcard $@),,cd $(srcdir) && $(AUTOHEADER)) > -$(srcdir)/src/stamp-h.in: $(AUTOCONF_INPUTS) > - cd ${srcdir} && ${AUTOHEADER} > - rm -f $@ > - echo timestamp > $@ > + $(if $(wildcard $@),,cd $(srcdir) && ./autogen.sh autoconf) Likewise? > diff --git a/autogen.sh b/autogen.sh > index bb3f818..f8e71cb 100755 > --- a/autogen.sh > +++ b/autogen.sh [...] > - autoreconf -fi -I m4 || exit $? > + autoreconf -fi -I m4 || exit Also unrelated? [New files:] > build-aux/config.guess > build-aux/config.sub > build-aux/install-sh It's a tiny bit disappointing that we need to version these again (you removed them in 2011).