From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "serge.tupchii" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45122: [PATCH] 27.1; 28.0.50; Fix crash (segfault) in etags on generating tags for Erlang files Date: Tue, 08 Dec 2020 11:34:25 +0000 Message-ID: Reply-To: "serge.tupchii" , "serge.tupchii" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_cUa5O7M7QFpCiFRsMdGxptT5VGUnwybnqS6eKqOGc" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37426"; mail-complaints-to="usenet@ciao.gmane.io" To: 45122@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 08 17:18:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmfgz-0009bS-7q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Dec 2020 17:18:21 +0100 Original-Received: from localhost ([::1]:51302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmfgy-0007q8-9G for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Dec 2020 11:18:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmfgg-0007ow-Ts for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 11:18:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47787) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmfgg-0006A9-Lr for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 11:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmfgg-00083m-IJ for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 11:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "serge.tupchii" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Dec 2020 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45122 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.160744426030950 (code B ref -1); Tue, 08 Dec 2020 16:18:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Dec 2020 16:17:40 +0000 Original-Received: from localhost ([127.0.0.1]:59333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmfgJ-000837-Jh for submit@debbugs.gnu.org; Tue, 08 Dec 2020 11:17:40 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:42924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmbGe-00056g-F2 for submit@debbugs.gnu.org; Tue, 08 Dec 2020 06:34:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmbGd-0004QU-PN for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 06:34:52 -0500 Original-Received: from mail-03.mail-europe.com ([91.134.188.129]:57218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmbGV-0004JY-NV for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 06:34:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1607427276; bh=kYrvS+uTNkJPc0IcIq67bce6tIwG91u5/zmavNAYdyU=; h=Date:To:From:Reply-To:Subject:From; b=UXbKBO3O/t6eEkgTZZ6B4u0wKjasCncwLmeCebFhp2W3iLpvQXTbVeUhvVUx+FShN svxS5hk4AMrK/1rTP7KJ2fGWFt4YMvD7SJeLeRupJkOrXXbAo6X+MRvkdBahVfwuPk nJ3ysYwbbS53My/WWR5/ynkMy/cl/LW5d4MgzlCE= Received-SPF: pass client-ip=91.134.188.129; envelope-from=serge.tupchii@protonmail.com; helo=mail-03.mail-europe.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 08 Dec 2020 11:17:38 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195379 Archived-At: This is a multi-part message in MIME format. --b1_cUa5O7M7QFpCiFRsMdGxptT5VGUnwybnqS6eKqOGc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, This is a trivial patch to fix segfault occurring when generating tags for = Erlang source files. Steps to reproduce: 1. $ wget https://erlang.org/download/otp_src_23.1.tar.gz (~85 Mb) 2. $ tar -xf otp_src_23.1.tar.gz 3. $ etags otp_src_23.1/lib/*/src/*.erl Segmentation fault (core dumped) In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9, ca= iro version 1.14.6) of 2020-11-30 built on sergey-Latitude-5480 Repository revision: 31dcc70e555482fee59df2d8aa1939360d8f8c69 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 16.04.7 LTS Note: this bug is also present in Emacs 27 release GDB backtrace: (gdb) bt #0 0x00007ffff7b5b48d in ?? () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x000000000040a7bd in mempcpy (__len=3D12, __src=3D, __d= est=3D0x0) at /usr/include/x86_64-linux-gnu/bits/string3.h:67 #2 memcpyz (len=3D, src=3D, dest=3D0x0) at e= tags.c:149 #3 Erlang_functions (inf=3D0x6280a0) at etags.c:6082 #4 0x000000000040c003 in find_entries (inf=3Dinf@entry=3D0x6280a0) at etag= s.c:1901 #5 0x000000000040c75e in process_file (fh=3Dfh@entry=3D0x6280a0, fn=3Dfn@entry=3D0x7fffffff644c "otp_src_23.1/lib/asn1/src/asn1ct_check.= erl", lang=3Dlang@entry=3D0x0) at etags.c:1722 #6 0x000000000040c9e0 in process_file_name ( file=3D0x7fffffff644c "otp_src_23.1/lib/asn1/src/asn1ct_check.erl", lan= g=3D0x0) at etags.c:1668 #7 0x0000000000401c0c in main (argc=3D, argv=3D) at etags.c:1313 The attached patch fixes the above issue. Thanks and kind regards, Serge --b1_cUa5O7M7QFpCiFRsMdGxptT5VGUnwybnqS6eKqOGc Content-Type: text/x-patch; name=0001-Fix-crash-segfault-in-etags-on-generating-tags-for-E.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-crash-segfault-in-etags-on-generating-tags-for-E.patch RnJvbSAzNjZmNTU3MGY0NGE3NGY2MGRjZjZmMGIwY2M1YzU4NzhhNDhlMmQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnZSBUdXBjaGlpIDxzZXJnZS50dXBjaGlpQHByb3Rvbm1h aWwuY29tPgpEYXRlOiBUdWUsIDggRGVjIDIwMjAgMTE6MjU6MDEgKzAyMDAKU3ViamVjdDogW1BB VENIXSBGaXggY3Jhc2ggKHNlZ2ZhdWx0KSBpbiBldGFncyBvbiBnZW5lcmF0aW5nIHRhZ3MgZm9y IEVybGFuZwogZmlsZXMKCiogbGliLXNyYy9ldGFncy5jOiBTZXQgYWxsb2NhdGVkIGFuZCBsYXN0 bGVuIHRvIHplcm8sIGFmdGVyIGZyZWVpbmcgbGFzdCBwdHIKICBpbiBFcmxhbmdfZnVuY3Rpb25z IHRvIHByZXZlbnQgZGVyZWZlcmVuY2luZyBOVUxMIHBvaW50ZXIKLS0tCiBsaWItc3JjL2V0YWdz LmMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2xp Yi1zcmMvZXRhZ3MuYyBiL2xpYi1zcmMvZXRhZ3MuYwppbmRleCA0MzE1NzcxYTQ5Li5hMWM2ODM3 ZTg4IDEwMDY0NAotLS0gYS9saWItc3JjL2V0YWdzLmMKKysrIGIvbGliLXNyYy9ldGFncy5jCkBA IC02MDYzLDYgKzYwNjMsNyBAQCBFcmxhbmdfZnVuY3Rpb25zIChGSUxFICppbmYpCiAJICAgIHsK IAkgICAgICBmcmVlIChsYXN0KTsKIAkgICAgICBsYXN0ID0gTlVMTDsKKwkgICAgICBhbGxvY2F0 ZWQgPSBsYXN0bGVuID0gMDsKIAkgICAgfQogCX0KICAgICAgIGVsc2UKLS0gCjIuMjkuMAoK --b1_cUa5O7M7QFpCiFRsMdGxptT5VGUnwybnqS6eKqOGc--