From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ralf Angeli Newsgroups: gmane.emacs.devel Subject: Re: declare-function in files from Gnus (hashcash.el, imap.el) Date: Sat, 01 Dec 2007 10:15:42 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1196500755 5794 80.91.229.12 (1 Dec 2007 09:19:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Dec 2007 09:19:15 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 01 10:19:24 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IyOVO-00041C-CH for ged-emacs-devel@m.gmane.org; Sat, 01 Dec 2007 10:19:22 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IyOV7-0006d3-TX for ged-emacs-devel@m.gmane.org; Sat, 01 Dec 2007 04:19:05 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IyOV3-0006ZZ-Bl for emacs-devel@gnu.org; Sat, 01 Dec 2007 04:19:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IyOV1-0006Xu-TG for emacs-devel@gnu.org; Sat, 01 Dec 2007 04:19:01 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IyOV1-0006Xl-Qk for emacs-devel@gnu.org; Sat, 01 Dec 2007 04:18:59 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IyOV1-0004q9-En for emacs-devel@gnu.org; Sat, 01 Dec 2007 04:18:59 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IyOTt-0001NG-BC for emacs-devel@gnu.org; Sat, 01 Dec 2007 09:17:49 +0000 Original-Received: from p54a523ad.dip0.t-ipconnect.de ([84.165.35.173]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 01 Dec 2007 09:17:49 +0000 Original-Received: from angeli by p54a523ad.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 01 Dec 2007 09:17:49 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 35 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: p54a523ad.dip0.t-ipconnect.de Cancel-Lock: sha1:cggBCe5EQcEOtYRCmFP0Uhc/lpM= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84411 Archived-At: * Reiner Steib (2007-11-30) writes: > I think the following changes... > > 2007-11-27 Dan Nicolaescu > [...] > * mail/hashcash.el (message-narrow-to-headers-or-head) > (message-fetch-field, message-goto-eoh) > (message-narrow-to-headers): > [...] Declare as functions. > > 2007-11-29 Glenn Morris > [...] > * net/imap.el (sasl-find-mechanism, sasl-mechanism-name) > (sasl-make-client, sasl-next-step, sasl-step-data) > (sasl-step-set-data) > [...] Declare as functions. > > ... will break compatibility of Gnus with Emacs 21, Emacs 22.1 and > XEmacs when synced to Gnus repository (doesn't happen immediately, > because Miles is on a trip). > > The files came from Gnus and are only used by Gnus, AFAIK. We could > probably skip these changes when syncing, keeping the files identical > simplifies maintenance. > > Maybe we could add (defalias 'declare-function 'ignore ...) (like in > Emacs 22.2) to `gnus/lisp/dgnushack.el' (in Gnus). There is the same problem with RefTeX. Can somebody explain why these `declare-function' calls are needed? -- Ralf