From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115669: eww: support disabled and readonly text Date: Mon, 23 Dec 2013 13:54:12 -0500 Message-ID: References: <87txdzaiaa.fsf@flea.lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1387824854 25137 80.91.229.3 (23 Dec 2013 18:54:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Dec 2013 18:54:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 23 19:54:21 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VvAdw-0006sL-HQ for ged-emacs-devel@m.gmane.org; Mon, 23 Dec 2013 19:54:20 +0100 Original-Received: from localhost ([::1]:34987 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvAdw-0005yh-4T for ged-emacs-devel@m.gmane.org; Mon, 23 Dec 2013 13:54:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvAds-0005wJ-HG for emacs-devel@gnu.org; Mon, 23 Dec 2013 13:54:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvAdo-0001OA-SO for emacs-devel@gnu.org; Mon, 23 Dec 2013 13:54:16 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvAdo-0001O6-P3 for emacs-devel@gnu.org; Mon, 23 Dec 2013 13:54:12 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VvAdo-0004W0-89; Mon, 23 Dec 2013 13:54:12 -0500 X-Spook: analyzer MD2 George W. Bush Nazi Putin Treasury Plame X-Ran: Di9*Q->LOTQ0&:J%G9#Q8.-tV]he=xmUlt1C%~-m?j9vO>mRaJnWH->5>f1q}rJi X-Hue: blue X-Attribution: GM In-Reply-To: <87txdzaiaa.fsf@flea.lifelogs.com> (Ted Zlatanov's message of "Mon, 23 Dec 2013 07:00:45 -0500") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166791 Archived-At: Ted Zlatanov wrote: > Regarding the first nitpick: I saw eww as the first word and didn't want > to capitalize it. But I see both versions in the ChangeLog, from me and > others, e.g. Whoa, whoa, whoa! ;) The commit log is not the ChangeLog (no matter how much some people might like it to be). So when you say "I see both versions in the ChangeLog", your examples are all incorrect, since they do not come from the ChangeLog. > revno: 115702 > committer: Chong Yidong > branch nick: trunk > timestamp: Mon 2013-12-23 11:59:10 +0800 > message: > Rename set-temporary-overlay-map -> set-transient-map [...] > revno: 115699 > committer: Glenn Morris > branch nick: trunk > timestamp: Sun 2013-12-22 15:13:18 -0800 > message: > Misc small fixes for some recent doc changes Those are examples of the summary line that starts a commit. I adhere to the convention that these look best if treated like the Subject: header of an email. These traditionally start with a capital and do not end with a full-stop. I feel like I've seen this written down somewhere wrt commit messages, but cannot find it now, so maybe I made that up. The slightly different convention of: module: change in this module which is what Ted used, is followed eg by coreutils. I also think this looks fine. Yours nitpick-for-nitpick,