all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r115669: eww: support disabled and readonly text
Date: Mon, 23 Dec 2013 13:54:12 -0500	[thread overview]
Message-ID: <fi7gavpfe3.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87txdzaiaa.fsf@flea.lifelogs.com> (Ted Zlatanov's message of "Mon, 23 Dec 2013 07:00:45 -0500")

Ted Zlatanov wrote:

> Regarding the first nitpick: I saw eww as the first word and didn't want
> to capitalize it.  But I see both versions in the ChangeLog, from me and
> others, e.g.

Whoa, whoa, whoa! ;)

The commit log is not the ChangeLog (no matter how much some people
might like it to be). So when you say "I see both versions in the
ChangeLog", your examples are all incorrect, since they do not come
from the ChangeLog.

> revno: 115702
> committer: Chong Yidong <cyd@gnu.org>
> branch nick: trunk
> timestamp: Mon 2013-12-23 11:59:10 +0800
> message:
>   Rename set-temporary-overlay-map -> set-transient-map
[...]
> revno: 115699
> committer: Glenn Morris <rgm@gnu.org>
> branch nick: trunk
> timestamp: Sun 2013-12-22 15:13:18 -0800
> message:
>   Misc small fixes for some recent doc changes

Those are examples of the summary line that starts a commit.

I adhere to the convention that these look best if treated like the
Subject: header of an email. These traditionally start with a capital
and do not end with a full-stop.

I feel like I've seen this written down somewhere wrt commit messages,
but cannot find it now, so maybe I made that up.

The slightly different convention of:

  module: change in this module

which is what Ted used, is followed eg by coreutils. I also think this
looks fine.

Yours nitpick-for-nitpick,



      parent reply	other threads:[~2013-12-23 18:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1VuTME-00023E-Te@vcs.savannah.gnu.org>
2013-12-23  2:26 ` [Emacs-diffs] trunk r115669: eww: support disabled and readonly text Stefan Monnier
2013-12-23 12:00   ` Ted Zlatanov
2013-12-23 13:54     ` Stefan Monnier
2013-12-23 14:31       ` Ted Zlatanov
2013-12-23 18:54     ` Glenn Morris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fi7gavpfe3.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.