From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Toshi Umehara" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Scheme-mode: Add support for regular expression literal Date: Sun, 24 Mar 2024 13:33:19 +0900 Message-ID: References: <87msqpfz68.fsf@niceume.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=e9442c4f733e4822ad39292891500050 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28961"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.11.0-alpha0-332-gdeb4194079-fm-20240319.002-gdeb41940 Cc: emacs-devel@gnu.org, "Eli Zaretskii" , jcubic@onet.pl To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 24 05:35:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1roFaD-0007Fn-7Z for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Mar 2024 05:35:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1roFZE-0002WN-To; Sun, 24 Mar 2024 00:34:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1roFZD-0002W4-3P for emacs-devel@gnu.org; Sun, 24 Mar 2024 00:34:43 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1roFZ9-0007Ut-QC; Sun, 24 Mar 2024 00:34:42 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 05A2032003D3; Sun, 24 Mar 2024 00:34:33 -0400 (EDT) Original-Received: from imap48 ([10.202.2.98]) by compute5.internal (MEProxy); Sun, 24 Mar 2024 00:34:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niceume.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=mesmtp; t=1711254873; x=1711341273; bh=KFnRZ24 swXs06r34f1e7KkBRAYuw6+h8zqXEY36rRxU=; b=T+IydJqhKXjM3GHNNd8yq94 swWHynKEQjFUKHS5pwT1I5ozhaxo2RJHmI6pZispan19ndktKVVhXHW+WVgIGo/p Ipxx9Gisw9Ik6xnd8+yRCMHdW4M0sNcNwIw549pdWje161IyXZU2QF/af5pZEm8U 8U/I5/blF7uwB1vNbXVs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1711254873; x=1711341273; bh=KFnRZ24swXs06r34f1e7KkBRAYuw 6+h8zqXEY36rRxU=; b=brPj/g5uE1hslhkzy1f5OxziTtJ27tY3I7tLyTW3PJeA BE4oOxmZ8Gd6V0GwskLnl8fAw8clLPeZPbf7mt3i0kkptv/+KZCqlpeGFpSYjZAv Wv3bSntl1D05q+SSMdAoJbf5fzi4arp3ZYJNMbbTY7kOzYdD46XaVgDnN+MUCWbK zRYeayTtrh6W4+4BL9rdrRx3OJWRr5wo5esVXR1Xc7W1qLLslwsk0aqi3YhA1p8b WW3VQDNaVSXlBX8DWoScBal/Vk8XmC9hz3oB9x66PMBl+3ryVsd9AwPtNJjgee+W WtwC3cToKhmGCVuYMxk7txI1V5RU+5gCfMdyfW3Mnw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddthedgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehmtderreerredtnecuhfhrohhmpedfvfho shhhihcufghmvghhrghrrgdfuceothhoshhhihesnhhitggvuhhmvgdrtghomheqnecugg ftrfgrthhtvghrnhepveeivedtvefggeegueevjefhjeffjefhvdelveekhfetudetueev jeeuueefiefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhoshhhihesnhhitggvuhhmvgdrtghomh X-ME-Proxy: Feedback-ID: iaf1147ca:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id DDCF531A0065; Sun, 24 Mar 2024 00:34:32 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: Received-SPF: pass client-ip=64.147.123.20; envelope-from=toshi@niceume.com; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317256 Archived-At: --e9442c4f733e4822ad39292891500050 Content-Type: text/plain Thank you very much for reviewing the patch, Stefan. The patch is updated. - Subexpression 1 is now used for regular expression rule in syntax-propertize-rules - Unused arguments are removed from caller and callee of scheme-syntax-propertize-regexp - Changing the third argument of re-search-forward from t to 'move moves the point to end if the search does not find closing slash, which is ideal. Attached patches are separated into three. The first one changes only regular expression part mentioned above. The second one is NEWS update. The third one removes unused arguments also for scheme-syntax-propertize-sexp-comment . Please use them as you want. Also about copyright assignment, this is the first commitment to GNU, and I have filled out the form and have emailed it to assign@gnu.org . Thanks -- Toshi (Toshihiro Umehara) --e9442c4f733e4822ad39292891500050 Content-Disposition: attachment; filename*0="0001-Enable-dealing-with-regular-expression-literal.patch" Content-Type: text/x-patch; name="=?UTF-8?Q?0001-Enable-dealing-with-regular-expression-literal.patch?=" Content-Transfer-Encoding: BASE64 RnJvbSBhNDFmODFkYTMyOWJmOWY3NTNhOTAxYzAyZDA1ZGIxNGJjZDBiNjUxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBuaWNldW1lIDx0b3NoaUBuaWNldW1lLmNvbT4KRGF0 ZTogU3VuLCAxNyBNYXIgMjAyNCAwOToxMjozMiArMDkwMApTdWJqZWN0OiBbUEFUQ0ggMS8z XSBFbmFibGUgZGVhbGluZyB3aXRoIHJlZ3VsYXIgZXhwcmVzc2lvbiBsaXRlcmFsCgotLS0K IGxpc3AvcHJvZ21vZGVzL3NjaGVtZS5lbCB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3NjaGVtZS5lbCBiL2xpc3Av cHJvZ21vZGVzL3NjaGVtZS5lbAppbmRleCA2N2FiYWI2OTEzZC4uZmEyNzJkZDVjNWMgMTAw NjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3NjaGVtZS5lbAorKysgYi9saXNwL3Byb2dtb2Rl cy9zY2hlbWUuZWwKQEAgLTQxMCwxMCArNDEwLDIxIEBAIHNjaGVtZS1zZXhwLWNvbW1lbnQt c3ludGF4LXRhYmxlCiAoZGVmdW4gc2NoZW1lLXN5bnRheC1wcm9wZXJ0aXplIChiZWcgZW5k KQogICAoZ290by1jaGFyIGJlZykKICAgKHNjaGVtZS1zeW50YXgtcHJvcGVydGl6ZS1zZXhw LWNvbW1lbnQgKHBvaW50KSBlbmQpCisgIChzY2hlbWUtc3ludGF4LXByb3BlcnRpemUtcmVn ZXhwIGVuZCkKICAgKGZ1bmNhbGwKICAgIChzeW50YXgtcHJvcGVydGl6ZS1ydWxlcwogICAg ICgiXFwoI1xcKTsiICgxIChwcm9nMSAiPCBjbiIKLSAgICAgICAgICAgICAgICAgICAgIChz Y2hlbWUtc3ludGF4LXByb3BlcnRpemUtc2V4cC1jb21tZW50IChwb2ludCkgZW5kKSkpKSkK KyAgICAgICAgICAgICAgICAgICAgIChzY2hlbWUtc3ludGF4LXByb3BlcnRpemUtc2V4cC1j b21tZW50IChwb2ludCkgZW5kKSkpKQorICAgICgiXFwoI1xcKS8iICgxICh3aGVuIChudWxs IChudGggOCAoc2F2ZS1leGN1cnNpb24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoc3ludGF4LXBwc3MKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKG1hdGNoLWJlZ2lubmluZyAwKSkpKSkKKyAgICAgICAgICAgICAgICAg ICAgIChwdXQtdGV4dC1wcm9wZXJ0eQorICAgICAgICAgICAgICAgICAgICAgIChtYXRjaC1i ZWdpbm5pbmcgMSkKKyAgICAgICAgICAgICAgICAgICAgICAobWF0Y2gtZW5kIDEpCisgICAg ICAgICAgICAgICAgICAgICAgJ3N5bnRheC10YWJsZSAoc3RyaW5nLXRvLXN5bnRheCAifCIp KQorICAgICAgICAgICAgICAgICAgICAgKHNjaGVtZS1zeW50YXgtcHJvcGVydGl6ZS1yZWdl eHAgZW5kKQorICAgICAgICAgICAgICAgICAgICAgbmlsKQorICAgICAgICAgICAgICAgICAg ICkpKQogICAgKHBvaW50KSBlbmQpKQogCiAoZGVmdW4gc2NoZW1lLXN5bnRheC1wcm9wZXJ0 aXplLXNleHAtY29tbWVudCAoXyBlbmQpCkBAIC00MzAsNiArNDQxLDI4IEBAIHNjaGVtZS1z eW50YXgtcHJvcGVydGl6ZS1zZXhwLWNvbW1lbnQKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAnc3ludGF4LXRhYmxlIChzdHJpbmctdG8tc3ludGF4ICI+IGNuIikpKQogICAg ICAgICAoc2Nhbi1lcnJvciAoZ290by1jaGFyIGVuZCkpKSkpKQogCisoZGVmdW4gc2NoZW1l LXN5bnRheC1wcm9wZXJ0aXplLXJlZ2V4cCAoZW5kKQorICAobGV0KiAoKHN0YXRlIChzeW50 YXgtcHBzcykpCisgICAgICAgICAod2l0aGluLXN0ciAobnRoIDMgc3RhdGUpKQorICAgICAg ICAgKHN0YXJ0LWRlbGltLXBvcyAobnRoIDggc3RhdGUpKSkKKyAgICAod2hlbiAoYW5kIHdp dGhpbi1zdHIKKyAgICAgICAgICAgICAgIChjaGFyLWVxdWFsID8jIChjaGFyLWFmdGVyIHN0 YXJ0LWRlbGltLXBvcykpKQorICAgICAgKHdoaWxlCisgICAgICAgICAgKGFuZAorICAgICAg ICAgICAocmUtc2VhcmNoLWZvcndhcmQgIi8iIGVuZCAnbW92ZSkKKyAgICAgICAgICAgKGVx IC0xCisgICAgICAgICAgICAgICAoJSAoc2F2ZS1leGN1cnNpb24KKyAgICAgICAgICAgICAg ICAgICAgKGJhY2t3YXJkLWNoYXIpCisgICAgICAgICAgICAgICAgICAgIChza2lwLWNoYXJz LWJhY2t3YXJkICJcXFxcIikpIDIpKSkpCisgICAgICAod2hlbiAoPCAocG9pbnQpIGVuZCkK KyAgICAgICAgKHByb2duCisgICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5CisgICAgICAg ICAgIChtYXRjaC1iZWdpbm5pbmcgMCkKKyAgICAgICAgICAgKG1hdGNoLWVuZCAwKQorICAg ICAgICAgICAnc3ludGF4LXRhYmxlIChzdHJpbmctdG8tc3ludGF4ICJ8IikpCisgICAgICAg ICAgKSkpCisgICAgKSkKKwogOzs7IyMjYXV0b2xvYWQKIChkZWZpbmUtZGVyaXZlZC1tb2Rl IGRzc3NsLW1vZGUgc2NoZW1lLW1vZGUgIkRTU1NMIgogICAiTWFqb3IgbW9kZSBmb3IgZWRp dGluZyBEU1NTTCBjb2RlLgotLSAKMi40NC4wCgo= --e9442c4f733e4822ad39292891500050 Content-Disposition: attachment; filename*0="0002-NEWS-update-for-scheme-mode.patch" Content-Type: text/x-patch; name="0002-NEWS-update-for-scheme-mode.patch" Content-Transfer-Encoding: BASE64 RnJvbSA0ZGE4MGI1YmQwOTkzZDRjZWIyMGFkYTU0OGNkNDU5ZGQwZTczYjRmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBuaWNldW1lIDx0b3NoaUBuaWNldW1lLmNvbT4KRGF0 ZTogU3VuLCAyNCBNYXIgMjAyNCAxMjoyOTowOSArMDkwMApTdWJqZWN0OiBbUEFUQ0ggMi8z XSBORVdTIHVwZGF0ZSBmb3Igc2NoZW1lLW1vZGUKCi0tLQogZXRjL05FV1MgfCA1ICsrKysr CiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZXRjL05F V1MgYi9ldGMvTkVXUwppbmRleCBmNGI0YzMwODU1Yy4uM2QzYjAyM2YyYmMgMTAwNjQ0Ci0t LSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0xMTg4LDYgKzExODgsMTEgQEAgaW5z dGVhZCBvZjoKIFRoaXMgYWxsb3dzIHRoZSB1c2VyIHRvIHNwZWNpZnkgY29tbWFuZCBsaW5l IGFyZ3VtZW50cyB0byB0aGUgbm9uCiBpbnRlcmFjdGl2ZSBQeXRob24gaW50ZXJwcmV0ZXIg c3BlY2lmaWVkIGJ5ICdweXRob24taW50ZXJwcmV0ZXInLgogCisqKiBTY2hlbWUgbW9kZQor CitTY2hlbWUgbW9kZSBub3cgaGFuZGxlcyByZWd1bGFyIGV4cHJlc3Npb24gbGl0ZXJhbCAj L3JlZ2V4cC8gdGhhdCBpcworYXZhaWxhYmxlIGluIHNvbWUgU2NoZW1lIGltcGxlbWVudGF0 aW9ucy4KKwogKiogdXNlLXBhY2thZ2UKIAogKysrCi0tIAoyLjQ0LjAKCg== --e9442c4f733e4822ad39292891500050 Content-Disposition: attachment; filename*0="0003-remove-unused-arguments-from-scheme-syntax-propertiz.pat"; filename*1="ch" Content-Type: text/x-patch; name="=?UTF-8?Q?0003-remove-unused-arguments-from-scheme-syntax-propertiz.patc?= =?UTF-8?Q?h?=" Content-Transfer-Encoding: BASE64 RnJvbSA5ZjhhZTNmYjZjMGY4MTgyNDY0MzE4MGNiYzlhNTNjYTJhY2FhODJhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBuaWNldW1lIDx0b3NoaUBuaWNldW1lLmNvbT4KRGF0 ZTogU3VuLCAyNCBNYXIgMjAyNCAxMjoyOTo1NiArMDkwMApTdWJqZWN0OiBbUEFUQ0ggMy8z XSByZW1vdmUgdW51c2VkIGFyZ3VtZW50cyBmcm9tCiBzY2hlbWUtc3ludGF4LXByb3BlcnRp emUtc2V4cC1jb21tZW50CgotLS0KIGxpc3AvcHJvZ21vZGVzL3NjaGVtZS5lbCB8IDYgKysr LS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3NjaGVtZS5lbCBiL2xpc3AvcHJvZ21vZGVz L3NjaGVtZS5lbAppbmRleCBmYTI3MmRkNWM1Yy4uZmNhZWFmYjRhNzUgMTAwNjQ0Ci0tLSBh L2xpc3AvcHJvZ21vZGVzL3NjaGVtZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9zY2hlbWUu ZWwKQEAgLTQwOSwxMiArNDA5LDEyIEBAIHNjaGVtZS1zZXhwLWNvbW1lbnQtc3ludGF4LXRh YmxlCiAKIChkZWZ1biBzY2hlbWUtc3ludGF4LXByb3BlcnRpemUgKGJlZyBlbmQpCiAgIChn b3RvLWNoYXIgYmVnKQotICAoc2NoZW1lLXN5bnRheC1wcm9wZXJ0aXplLXNleHAtY29tbWVu dCAocG9pbnQpIGVuZCkKKyAgKHNjaGVtZS1zeW50YXgtcHJvcGVydGl6ZS1zZXhwLWNvbW1l bnQgZW5kKQogICAoc2NoZW1lLXN5bnRheC1wcm9wZXJ0aXplLXJlZ2V4cCBlbmQpCiAgIChm dW5jYWxsCiAgICAoc3ludGF4LXByb3BlcnRpemUtcnVsZXMKICAgICAoIlxcKCNcXCk7IiAo MSAocHJvZzEgIjwgY24iCi0gICAgICAgICAgICAgICAgICAgICAoc2NoZW1lLXN5bnRheC1w cm9wZXJ0aXplLXNleHAtY29tbWVudCAocG9pbnQpIGVuZCkpKSkKKyAgICAgICAgICAgICAg ICAgICAgIChzY2hlbWUtc3ludGF4LXByb3BlcnRpemUtc2V4cC1jb21tZW50IGVuZCkpKSkK ICAgICAoIlxcKCNcXCkvIiAoMSAod2hlbiAobnVsbCAobnRoIDggKHNhdmUtZXhjdXJzaW9u CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN5bnRheC1wcHNz CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChtYXRjaC1iZWdp bm5pbmcgMCkpKSkpCkBAIC00MjcsNyArNDI3LDcgQEAgc2NoZW1lLXN5bnRheC1wcm9wZXJ0 aXplCiAgICAgICAgICAgICAgICAgICAgKSkpCiAgICAocG9pbnQpIGVuZCkpCiAKLShkZWZ1 biBzY2hlbWUtc3ludGF4LXByb3BlcnRpemUtc2V4cC1jb21tZW50IChfIGVuZCkKKyhkZWZ1 biBzY2hlbWUtc3ludGF4LXByb3BlcnRpemUtc2V4cC1jb21tZW50IChlbmQpCiAgIChsZXQg KChzdGF0ZSAoc3ludGF4LXBwc3MpKSkKICAgICAod2hlbiAoZXEgMiAobnRoIDcgc3RhdGUp KQogICAgICAgOzsgSXQncyBhIHNleHAtY29tbWVudC4gIFRlbGwgcGFyc2UtcGFydGlhbC1z ZXhwIHdoZXJlIGl0IGVuZHMuCi0tIAoyLjQ0LjAKCg== --e9442c4f733e4822ad39292891500050--