From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Patches for Emacs 25.2
Date: Fri, 16 Dec 2016 02:05:19 +0200 [thread overview]
Message-ID: <fff8327a-a2e5-19ac-2b1a-22cb81958844@yandex.ru> (raw)
In-Reply-To: <877f96t9oc.fsf@gmx.de>
Hi Eli,
Here's a patch I'd like to install into the release branch.
It should be "obviously safe" (js-mode doesn't set a
forward-sexp-function), and will improve performance for js2-mode users.
Some backstory: https://github.com/mooz/js2-mode/issues/369
Is it OK?
diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index 6d995a0..0ba7aac 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -1851,7 +1851,8 @@ js--multi-line-declaration-indentation
"Helper function for `js--proper-indentation'.
Return the proper indentation of the current line if it belongs to a
declaration
statement spanning multiple lines; otherwise, return nil."
- (let (at-opening-bracket)
+ (let (forward-sexp-function ; use Lisp version even in js2-mode
+ at-opening-bracket)
(save-excursion
(back-to-indentation)
(when (not (looking-at js--declaration-keyword-re))
next prev parent reply other threads:[~2016-12-16 0:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 7:09 Patches for Emacs 25.2 Michael Albinus
2016-10-18 7:24 ` Eli Zaretskii
2016-10-18 7:47 ` Michael Albinus
2016-10-18 8:09 ` Nikolay Kudryavtsev
2016-10-18 8:25 ` Michael Albinus
2016-10-18 9:24 ` Eli Zaretskii
2016-10-18 11:05 ` Nikolay Kudryavtsev
2016-10-18 11:29 ` Eli Zaretskii
2016-10-18 11:59 ` Nikolay Kudryavtsev
2016-10-18 12:32 ` Michael Albinus
2016-10-18 14:38 ` Eli Zaretskii
2016-11-07 0:08 ` Dmitry Gutov
2016-11-07 9:01 ` Michael Albinus
2016-11-07 9:36 ` Dmitry Gutov
2016-11-07 10:31 ` Michael Albinus
2016-11-07 10:39 ` Dmitry Gutov
2016-11-07 10:58 ` Michael Albinus
2016-11-19 23:03 ` Dmitry Gutov
2016-11-20 15:34 ` file-local-name (was: Patches for Emacs 25.2) Michael Albinus
2016-11-19 23:04 ` Patches for Emacs 25.2 Dmitry Gutov
2016-11-20 8:49 ` Michael Albinus
2016-12-31 4:20 ` Nikolay Kudryavtsev
2016-12-31 11:32 ` Dmitry Gutov
2016-12-31 11:40 ` Eli Zaretskii
2016-12-31 11:44 ` Dmitry Gutov
2017-01-02 10:21 ` Nikolay Kudryavtsev
2017-01-02 10:32 ` Dmitry Gutov
2017-01-02 12:22 ` Michael Albinus
2017-01-02 18:43 ` Nikolay Kudryavtsev
2017-01-02 18:54 ` Michael Albinus
2017-01-02 19:08 ` Dmitry Gutov
2017-01-02 19:56 ` Michael Albinus
2017-01-02 20:08 ` Dmitry Gutov
2017-01-02 19:54 ` Michael Albinus
2017-01-02 20:52 ` Nikolay Kudryavtsev
2017-01-02 19:13 ` Dmitry Gutov
2016-10-18 9:13 ` Eli Zaretskii
2016-10-18 9:55 ` Michael Albinus
2016-10-18 10:05 ` Eli Zaretskii
2016-10-18 11:24 ` Michael Albinus
2016-10-18 11:30 ` Eli Zaretskii
2016-12-16 0:05 ` Dmitry Gutov [this message]
2016-12-16 8:10 ` Eli Zaretskii
2016-12-16 18:33 ` Dmitry Gutov
2016-12-16 21:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fff8327a-a2e5-19ac-2b1a-22cb81958844@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.