From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer Date: Tue, 11 Apr 2023 01:23:19 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36296"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Oleksandr Gavenko , 62749@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 11 00:24:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plzvx-0009Ge-9E for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Apr 2023 00:24:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plzvh-0008QP-0N; Mon, 10 Apr 2023 18:24:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plzvf-0008Px-6p for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 18:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plzve-0006RP-UY for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 18:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plzve-0007gp-DE for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 18:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Apr 2023 22:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62749 X-GNU-PR-Package: emacs Original-Received: via spool by 62749-submit@debbugs.gnu.org id=B62749.168116541029517 (code B ref 62749); Mon, 10 Apr 2023 22:24:02 +0000 Original-Received: (at 62749) by debbugs.gnu.org; 10 Apr 2023 22:23:30 +0000 Original-Received: from localhost ([127.0.0.1]:36077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plzv8-0007g0-FP for submit@debbugs.gnu.org; Mon, 10 Apr 2023 18:23:30 -0400 Original-Received: from new1-smtp.messagingengine.com ([66.111.4.221]:33635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plzv6-0007fm-4L for 62749@debbugs.gnu.org; Mon, 10 Apr 2023 18:23:28 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id D134158202B; Mon, 10 Apr 2023 18:23:22 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 10 Apr 2023 18:23:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681165402; x=1681169002; bh=bI6XZ91gMc9AFKk4VNgRLJY37R2/SfVsMAs NA9UFVhk=; b=SoG79czOq6JXEkj+L+5u5jCihgpfO3iDGoCITBuYWH+hXpA7gyH pyFVN4QErXDYChiG4yH7qzuckKbYYo6cgi9rUV/QGj9+JbBPeTH+f8d+u+N8QZ6W eHUX+i9EHrDoQ7xo7nKAeptqfTrB6ShHUBeZh458JxE1T7IZ50RAsOEBoZi1f4eR zrINN+TFn9pa6duMr0133rwHkdzEaRFqN3ygypUqYXui95j2TpHJrQ4PJ+OKUJ4f b9gUMAasXUIL6TyhVC3GfQPvamSeCwTqGRErVtjzfID7175GnK8RDNnTS3MhvtRg c+Db5/4vzRgoW5lhWtx21D8OaCSyqOwUdCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1681165402; x= 1681169002; bh=bI6XZ91gMc9AFKk4VNgRLJY37R2/SfVsMAsNA9UFVhk=; b=c FY278xd6LprxmoJveZ3agIYUaXRMS1SMEK+t3BJIpF2/3KiCBcp/ixXM1gme0p7m BwTPS/0ZPSA/fnAu8VvImgnrjNkVkiCqxOXycROfRpcpjKpohIqW6PNODgFoOArS 5pQxmmdJlj7K0w+aamiiKB+sabi5TnXlmm5kcOz2cA8taQ0DXv74GGrxA06LOgQp lwMifSZ9wKtzcHCVRMQzHQwGsJofG2xBgW6dyd261NTTD57lKy2CDIe2j6zDyxrP ycYJ9ooFTvXB7FPLdo1rn4f6xAyGIEWkgOA5sgdvG6iefyJ7xwYjVXklcK85HKMu VBfDRtBKlvOC6rjDlHEIw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekfedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpedvteeuieefgeefveejvdekjeegleeiffettdelfedugfekhfegteefffeitddt ieenucffohhmrghinhepshhtrggtkhgvgigthhgrnhhgvgdrtghomhenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthho vhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Apr 2023 18:23:21 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259608 Archived-At: Hi! Thanks for the report. On 10/04/2023 15:11, Oleksandr Gavenko wrote: > In GNU Emacs 28.2 (build 1, x86_64-pc-cygwin) > of 2022-09-16 built on fv-az140-985 > Repository revision: 70134aa8264ded36d80248204b2ba43ae3d8f599 > > Whenever I open vc-diff buffer by "d" (log-view-diff) to read repository > history from "C-x v L" (vc-print-root-log) Emacs opens all files referenced by > diff. > > The diff might be very big so: > > * I end with lots of opened files that I need eventually close. > * Emacs pollutes recentf history - I don't want robotically opened file mixed > with human opened files. > * Cygwin is slow (especially under antivirus supervision) file opening delays > Emacs for many seconds. > > Initially I asked for help in Emacs 27.1: > > https://emacs.stackexchange.com/questions/61760/lags-when-navigating-vc-root-diff-buffer/ > > and found workaround with: > > (setq diff-font-lock-syntax nil) This workaround should help, in particular to improve performance under Cygwin. The thing about opened files is quite odd, though: diff-syntax-fontify-hunk does not visit any new files. It either uses an existing buffer, or fetches file contents using insert-file-contents, or calls vc-find-revision-no-save which, again, inserts the previous' revision file contents into the provided buffer, without visiting a file. Perhaps you could edebug diff-syntax-fontify-hunk to find the exact place where a file is visited (and added to recentf), if that indeed happens.