From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15329: saveplace restores dired positions to random places Date: Mon, 16 Dec 2013 13:15:43 -0800 (PST) Message-ID: References: <87mwnj1414.fsf@mail.jurta.org> <8761u6ow6t.fsf@kwarm.red-bean.com> <87d2odvk36.fsf@mail.jurta.org> <87hacy829m.fsf@floss.red-bean.com> <87sittlvd7.fsf@mail.jurta.org> <87zjo05x8e.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1387228580 9549 80.91.229.3 (16 Dec 2013 21:16:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Dec 2013 21:16:20 +0000 (UTC) Cc: Karl Fogel , 15329@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 16 22:16:25 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VsfWa-0006pd-Gk for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Dec 2013 22:16:24 +0100 Original-Received: from localhost ([::1]:58230 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsfWZ-0000My-UL for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Dec 2013 16:16:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsfWN-00007n-59 for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 16:16:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsfWE-00027Q-JD for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 16:16:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsfWE-00027M-Gy for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 16:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VsfWE-0003kH-3M for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 16:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2013 21:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15329 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15329-submit@debbugs.gnu.org id=B15329.138722855014370 (code B ref 15329); Mon, 16 Dec 2013 21:16:02 +0000 Original-Received: (at 15329) by debbugs.gnu.org; 16 Dec 2013 21:15:50 +0000 Original-Received: from localhost ([127.0.0.1]:54534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VsfW1-0003jh-Mz for submit@debbugs.gnu.org; Mon, 16 Dec 2013 16:15:50 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:45859) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VsfW0-0003jZ-D6 for 15329@debbugs.gnu.org; Mon, 16 Dec 2013 16:15:49 -0500 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBGLFkWc023493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Dec 2013 21:15:47 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGLFiFX017502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 16 Dec 2013 21:15:45 GMT Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGLFikG019151; Mon, 16 Dec 2013 21:15:44 GMT In-Reply-To: <87zjo05x8e.fsf@mail.jurta.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82095 Archived-At: > > Is `dired-directory' really the right test here? I am used to seeing > > (derived-mode-p 'dired-mode) for that purpose (assuming I understand th= e > > purpose here). >=20 > Yes, `dired-directory' is the right test, because `dired-directory' > is used as a key in `save-place-alist'. OK. > > There is, BTW, nothing in the doc string of `dired-directory' that says > > what a nil value means. >=20 > Thanks for pointing to the doc string of `dired-directory' where I notice= d: >=20 > May be a list, in which case the car is the > directory name and the cdr is the list of files to mention. Yes, I use that use case quite a lot. > This case should be handled properly that I added to the following patch. Great. > > Should code now instead be using `dired-directory' to test whether the > > mode is (derived from) Dired? >=20 > Yes, code should be using `dired-directory' now. OK. Do you happen to know whether that is only the case now or has been th= e case all along? `dired-directory' is old, but I have always seen `derived-mode-p' used for the test - and I see it still, e.g., for `dired-toggle-read-only'. Or does it perhaps not matter at all which we use? Looking for what is best to use with multiple Emacs versions. > > If so, then at the very least the doc string of that variable should > > describe such a Boolean meaning: nil means not in Dired mode or a mode > > derived from it (or whatever the completely correct interpretation is). ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >=20 > Are you sure that nil means not in Dired mode or a mode derived from it? I posed a question; I didn't make a statement. Let's please describe what nil means here, whatever that might be. > Anyway, this is a new version: Thanks for taking the cons case into account.