all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Tom Tromey <tom@tromey.com>
Cc: 25529@debbugs.gnu.org, Stefan Monnier <monnier@IRO.UMontreal.CA>
Subject: bug#25529: diagnosis and one approach to a fix
Date: Tue, 7 Feb 2017 04:20:40 +0200	[thread overview]
Message-ID: <fed5a1b0-fa9a-d170-f9e6-d973fb17797f@yandex.ru> (raw)
In-Reply-To: <87bmuf8c1l.fsf@tromey.com>

On 06.02.2017 19:27, Tom Tromey wrote:

> Yep, adding a goto-char at the end of the function fixed this.
> Thanks for pointing that out; I'll add a test case for it.

Thanks.

> I think I understand combining the regexps.  But what does using a simple
> regexp for the closer mean?

Simple handler (not regexp), for the group corresponding to the closer 
(what's called a HIGHLIGHTn in syntax-propertize-rules docstring). The 
string "\"/", probably.

> Also, what is the purpose of the first call to
> js-syntax-propertize-regexp in js-syntax-propertize?

I'm not sure. Normally, that helps deal with multiline literals, but 
regexps in JavaScript are single-line. Maybe Stefan remembers.

Or maybe it was a result of confusion: the code deleted in 6cd18349 
includes this mistaken sentence: "XXX: Javascript can continue a regexp 
literal across lines so long as the newline is escaped with \."





  reply	other threads:[~2017-02-07  2:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25  7:22 bug#25529: 25.1.90; js-mode: Regexp literal with unbalanced brackets breaks font-lock Mikhail Gusarov
2017-02-05  5:37 ` bug#25529: diagnosis and one approach to a fix Tom Tromey
2017-02-05  6:01   ` Tom Tromey
2017-02-05 18:05     ` Tom Tromey
2017-02-05 18:43       ` Tom Tromey
2017-02-06  1:12         ` Dmitry Gutov
2017-02-06 17:27           ` Tom Tromey
2017-02-07  2:20             ` Dmitry Gutov [this message]
2017-02-07 13:07               ` Tom Tromey
2017-02-07 13:11                 ` Dmitry Gutov
2017-02-07 14:56               ` Stefan Monnier
2017-02-11  1:52               ` Tom Tromey
2017-02-11  3:45                 ` Stefan Monnier
2017-02-11  4:06                   ` Tom Tromey
2017-02-11  4:22                     ` Stefan Monnier
2017-02-11 15:27                       ` Tom Tromey
2017-02-11 15:41                         ` Stefan Monnier
2017-02-11 17:13                           ` Tom Tromey
2017-02-11 19:11                             ` Dmitry Gutov
2017-02-11 19:37 ` bug#25529: done Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fed5a1b0-fa9a-d170-f9e6-d973fb17797f@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=25529@debbugs.gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.