From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Devon Sean McCullough Newsgroups: gmane.emacs.bugs Subject: bug#45540: 27.1; symbolic links crash dired Date: Tue, 29 Dec 2020 16:54:15 -0500 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38418"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 To: 45540@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 29 22:55:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuMxS-0009tl-F2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 22:55:10 +0100 Original-Received: from localhost ([::1]:54460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuMxR-0006Ab-H1 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 16:55:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuMxK-0006AH-SM for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57094) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuMxK-0006oe-Ki for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuMxK-0006BZ-JA for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Devon Sean McCullough Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2020 21:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45540 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160927887423736 (code B ref -1); Tue, 29 Dec 2020 21:55:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Dec 2020 21:54:34 +0000 Original-Received: from localhost ([127.0.0.1]:40407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuMwr-0006Am-Tf for submit@debbugs.gnu.org; Tue, 29 Dec 2020 16:54:34 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:48016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuMwp-0006Ad-9w for submit@debbugs.gnu.org; Tue, 29 Dec 2020 16:54:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuMwo-0005tS-Vn for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:54:31 -0500 Original-Received: from gateway23.websitewelcome.com ([192.185.49.180]:42617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuMwn-0006b2-09 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:54:30 -0500 Original-Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 2A9444555 for ; Tue, 29 Dec 2020 15:54:16 -0600 (CST) Original-Received: from leaf.websitewelcome.com ([192.185.82.99]) by cmsmtp with SMTP id uMwakeEAjnPrxuMwakqmzZ; Tue, 29 Dec 2020 15:54:16 -0600 X-Authority-Reason: nr=8 Original-Received: from pool-72-83-171-228.washdc.east.verizon.net ([72.83.171.228]:56315 helo=[192.168.1.165]) by leaf.websitewelcome.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kuMwa-000Pv8-0g for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 15:54:16 -0600 Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - leaf.websitewelcome.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jovi.net X-BWhitelist: no X-Source-IP: 72.83.171.228 X-Source-L: No X-Exim-ID: 1kuMwa-000Pv8-0g X-Source-Sender: pool-72-83-171-228.washdc.east.verizon.net ([192.168.1.165]) [72.83.171.228]:56315 X-Source-Auth: devon2011@jovi.net X-Email-Count: 1 X-Source-Cap: am92aW5ldDtkZXZvbjtsZWFmLndlYnNpdGV3ZWxjb21lLmNvbQ== X-Local-Domain: yes Received-SPF: pass client-ip=192.185.49.180; envelope-from=emacs-hacker2018@jovi.net; helo=gateway23.websitewelcome.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196979 Archived-At: Here's a fix. I did NOT check this carefully. Dired crashes when (< (length file-name) (length root)) diff -aBbdu --label /Applications/Emacs-27.1.app/Contents/Resources/lisp/files.el.gz --label \#\ /var/folders/jv/9lctn91j0xqfv3f2kxc1lxx80000gn/T/jka-comtv7p5N /var/folders/jv/9lctn91j0xqfv3f2kxc1lxx80000gn/T/buffer-content-fatCkh --- /Applications/Emacs-27.1.app/Contents/Resources/lisp/files.el.gz +++ # @@ -4019,10 +4019,9 @@ (let* ((file-name (or (buffer-file-name) ;; Handle non-file buffers, too. (expand-file-name default-directory))) - (sub-file-name (if (and file-name + (sub-file-name (when (and file-name (file-name-absolute-p file-name)) - ;; FIXME: Why not use file-relative-name? - (substring file-name (length root))))) + (file-relative-name file-name root)))) (condition-case err (dolist (entry class-variables variables) (let ((key (car entry))) Diff finished. Tue Dec 29 16:42:36 2020