From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-27 b46c75b: xref-matches-in-files: Big Tramp speed-up
Date: Thu, 9 Jan 2020 02:42:17 +0300 [thread overview]
Message-ID: <fed14541-f4a9-8139-b688-03ffb62596ff@yandex.ru> (raw)
In-Reply-To: <jwvh81565et.fsf-monnier+emacs@gnu.org>
On 08.01.2020 22:51, Stefan Monnier wrote:
> Yes, I saw that, but it's still not clear to me which part of this costs
> so much more than tramp-file-local-name itself, nor why.
The whole of it, mostly. I've shown a simple patch which improved
performance a lot, by Michael says it's unmaintainable (IIUC):
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34343#83
(and there's a follow-up suggestion later)
By the way, the commit under discussion already references this bug report.
> The "remote" pat would presumably be in the DIR argument (DIR would
> presumably be the root of the project or something like that).
The current discussion is about xref-matches-in-files where Grep acts on
a list of files, not a directory. It's used by both project-find-regexp
and dired-do-find-regexp.
> Actually, maybe xref could apply `file-local-name` to the root of
> the project?
See above. It's not about projects only.
I've considered about having xref-matches-in-files also accept a
(REMOTE-ID LOCAL-FILES) struct, but that's also increase in complexity,
in all callers and related APIs, which will also affect maintainability.
So it's doable, but I'd rather make a good effort and fix it in Tramp to
have everyone benefit automatically.
next prev parent reply other threads:[~2020-01-08 23:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200107133628.1996.14412@vcs0.savannah.gnu.org>
[not found] ` <20200107133629.2E736211A5@vcs0.savannah.gnu.org>
[not found] ` <87y2uiiakq.fsf@gmx.de>
2020-01-08 13:52 ` emacs-27 b46c75b: xref-matches-in-files: Big Tramp speed-up Dmitry Gutov
2020-01-08 14:13 ` Michael Albinus
2020-01-08 14:56 ` Stefan Monnier
2020-01-08 15:13 ` Michael Albinus
2020-01-08 16:25 ` Stefan Monnier
2020-01-08 16:40 ` Michael Albinus
2020-01-08 18:56 ` Stefan Monnier
2020-01-08 20:10 ` Michael Albinus
2020-01-08 20:51 ` Stefan Monnier
2020-01-08 23:42 ` Dmitry Gutov [this message]
2020-01-13 9:50 ` Philippe Vaucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed14541-f4a9-8139-b688-03ffb62596ff@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.