From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Add Tango and Adwaita icons for the toolbar Date: Sun, 5 May 2024 18:25:23 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18336"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Yuan Fu , "Ergus via Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 05 17:26:02 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3dkW-0004Ut-AL for ged-emacs-devel@m.gmane-mx.org; Sun, 05 May 2024 17:26:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3dkH-0000Xb-Pb; Sun, 05 May 2024 11:25:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3dkA-0000Th-JU for emacs-devel@gnu.org; Sun, 05 May 2024 11:25:41 -0400 Original-Received: from fout6-smtp.messagingengine.com ([103.168.172.149]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3dk3-0000bb-Dk for emacs-devel@gnu.org; Sun, 05 May 2024 11:25:37 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id 48BBF1380153; Sun, 5 May 2024 11:25:27 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 05 May 2024 11:25:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714922727; x=1715009127; bh=WYsRva4ZwM4dI7Bltv4KXj/vmBq3QAmMS9Gv5oWu74s=; b= B4vuB37lmn9TtDcPZFsyMnzw0xHBbcZj4lEqaw+48RaGguz1ip22Lt5BSy9GBMOL T7N7PeMn2rj6H40mAW6UDklcPkWD9STnBqjhc35wM4+CH5qJJwIYMa/g71JvjbKx dxFZHCC9rZajQBXegVvw1a8Gb5dLaIOuqyK4xjjpgF9myZM+L4ERCyduFWXaYWM8 VlgWZwLJcB8eWntsj3t8qXw5/HG2lSDf0+gL/4LnU7wQHPb5eQofFAKai2xlWq5/ 1UiEqkiO5kbl3L6nVuvjmumWvOdIHM+onHt0OI/0SXByNFQcxERyzIrbBVvBY3w+ 4qYWuLMHTNk69l4H5Tk3IA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714922727; x= 1715009127; bh=WYsRva4ZwM4dI7Bltv4KXj/vmBq3QAmMS9Gv5oWu74s=; b=c Ljq8B2JKR2NEOQmau8L3NI5is0knklLobb9R6fsSYpQtWYRwzweBOQMSnVH3g4rN SlNj8k7gIH1jH36lxcQbYGLPG3Q98qiu5FA0BCMwxmmF9EU6/wvZ1hfQySJ/FaNg JNzA/+kCaz5/pr1tVbvouIxqlkb65yB/IEmPiwiNjQHkmD7coBHGyFr3duMLEEFC xrU6FRI5xVLWHQLFIpYeMYCFXP81SeAi2oSJjQMH8Nrneulsnq86n8N979tLDWRF w3GxCz+MGjfv62RcJJMpsADxcK9xxSev4a+n21zbFSsZY8t8kuxbdefkdS1h3tBP m6rUpLY8zc29L+t3Qee6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvgedgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthekredttddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeegueegteffuddvjeevvdelleeitdeftdduhfeffeffjedukeevjedvfeffgfev geenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 May 2024 11:25:26 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=103.168.172.149; envelope-from=dmitry@gutov.dev; helo=fout6-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318836 Archived-At: On 04/05/2024 12:20, Yuan Fu wrote: > I followed the original tool-bar icon thread in 2022. At the time I didn’t have much time and I personally prefer colorful icons for the tool bar [1] (IMO mono-colored symbolic icons are more suitable for inline, small icons), so I didn’t do anything except for observing the discussion. > > [1] I especially adore the life ring icon for help! Whatever icon set we use for the tool-bar, the help icon should always be a cute life ring :-) > > The recent Emacs app icon thread reminded me of that thread, and I do have time now. So, I went ahead and searched for the Tango and Adwaita icons (basically the high-res version of the existing tool-bar icon that we use), then converted them to be suitable for Emacs tool-bar. > > About 1/3 of the icons can be directly taken from Tango or Adwaita, the rest I have to modify or kind of take apart and re-assemble. Anyway, in the end I managed to get most of the basic icons covered. For details see etc/images/scalable/README. This is exciting! > You can see the attached screenshots for the current built-in icons and the new icons. I also attached the patch for it. You want to rebuild or byte-compile tool-bar.el for the new icons to take effect. > > I hope these new icons won’t be controversial. As you can see, they are basically straight high-res upgrades for the existing icons. There are many imperfections that’ll be atrocious in the eyes of a graphic designer—I did the conversion work in an afternoon and I’m no where near a graphic designer; but it’s definitely an upgrade and we can always incrementally improve after. > > If no one objects, I’ll happily push this to master. The icons look good - definitely better than what we had before. And it's the same set, so...