From: Paul Eggert <eggert@cs.ucla.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 1a6f595: * src/minibuf.c (read_minibuf): Add a FIXME comment.
Date: Wed, 25 Apr 2018 12:30:35 -0700 [thread overview]
Message-ID: <fe5afcd4-1fa3-a155-cbb1-ba4eee60218e@cs.ucla.edu> (raw)
In-Reply-To: <jwv36zj33ev.fsf-monnier+gmane.emacs.devel@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On 04/25/2018 04:59 AM, Stefan Monnier wrote:
> Not sure what earlier time you're thinking of. My minibuffer-only frame
> is still single-line, with no sign that it will grow a second line any
> time soon.
>
> In any case, I don't think this buffer-local binding is right, so
> I suggest removing it on `master`.
I vaguely recall that the minibuffer used to have problems if you did
stuff like (read-from-minibuffer "line1\nline2"). This now works and the
minibuffer displays as multiple lines (and does not use backslash-n in
the display). My memory of course could be faulty.
Anyway, thanks for the second pair of eyes. I installed the attached
into master and will close bug#31251.
[-- Attachment #2: 0001-Don-t-set-print-escape-newlines-in-the-minibuffer.txt --]
[-- Type: text/plain, Size: 2163 bytes --]
From 920d107d78cba5c390661d7a7f4b1a823ddfef0d Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 25 Apr 2018 12:20:04 -0700
Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20set=20print-escape-newlines=20i?=
=?UTF-8?q?n=20the=20minibuffer?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This appears to be an unnecessary and possibly-confusing
revenant from ancient code (Bug#31251). See thread containing:
https://lists.gnu.org/r/emacs-devel/2018-04/msg00654.html
* src/minibuf.c (read_minibuf): Do not set print-escape-newlines.
* src/print.c (syms_of_print): Do not defsym print-escape-newlines
or print-escape-control-characters, as these symbols are not used
in C code.
---
src/minibuf.c | 7 -------
src/print.c | 2 --
2 files changed, 9 deletions(-)
diff --git a/src/minibuf.c b/src/minibuf.c
index 11b3fe2b9c..c41958d85f 100644
--- a/src/minibuf.c
+++ b/src/minibuf.c
@@ -595,13 +595,6 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt,
XWINDOW (minibuf_window)->hscroll = 0;
XWINDOW (minibuf_window)->suspend_auto_hscroll = 0;
- /* Why does this code set print-escape-newlines? No call to Fprin1
- or to Fprint is anywhere in sight. FIXME: Either remove the next
- two lines of code along with this comment, or replace this
- comment with an explanation for why the two lines are needed. */
- Fmake_local_variable (Qprint_escape_newlines);
- print_escape_newlines = 1;
-
/* Erase the buffer. */
{
ptrdiff_t count1 = SPECPDL_INDEX ();
diff --git a/src/print.c b/src/print.c
index a8bbb9d37a..7c6856af48 100644
--- a/src/print.c
+++ b/src/print.c
@@ -2447,10 +2447,8 @@ priorities. */);
defsubr (&Sredirect_debugging_output);
defsubr (&Sprint_preprocess);
- DEFSYM (Qprint_escape_newlines, "print-escape-newlines");
DEFSYM (Qprint_escape_multibyte, "print-escape-multibyte");
DEFSYM (Qprint_escape_nonascii, "print-escape-nonascii");
- DEFSYM (Qprint_escape_control_characters, "print-escape-control-characters");
print_prune_charset_plist = Qnil;
staticpro (&print_prune_charset_plist);
--
2.14.3
prev parent reply other threads:[~2018-04-25 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180424225022.24335.78516@vcs0.savannah.gnu.org>
[not found] ` <20180424225023.4A3C620836@vcs0.savannah.gnu.org>
2018-04-25 1:39 ` [Emacs-diffs] master 1a6f595: * src/minibuf.c (read_minibuf): Add a FIXME comment Stefan Monnier
2018-04-25 4:09 ` Paul Eggert
2018-04-25 11:59 ` Stefan Monnier
2018-04-25 19:30 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe5afcd4-1fa3-a155-cbb1-ba4eee60218e@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.