From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24706: 26.0.50; Minor mode functions should do strict argument type checking Date: Sun, 16 Oct 2016 12:50:06 -0700 (PDT) Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1476647475 28938 195.159.176.226 (16 Oct 2016 19:51:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Oct 2016 19:51:15 +0000 (UTC) To: Philipp Stephani , 24706@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 16 21:51:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvrSg-0006kt-0F for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Oct 2016 21:51:10 +0200 Original-Received: from localhost ([::1]:57602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvrSi-0004p9-3q for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Oct 2016 15:51:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvrSc-0004oQ-5y for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 15:51:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvrSY-0000k6-9w for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 15:51:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57589) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bvrSY-0000k2-70 for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 15:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bvrSX-000300-Rd for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2016 15:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Oct 2016 19:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24706-submit@debbugs.gnu.org id=B24706.147664741711472 (code B ref 24706); Sun, 16 Oct 2016 19:51:01 +0000 Original-Received: (at 24706) by debbugs.gnu.org; 16 Oct 2016 19:50:17 +0000 Original-Received: from localhost ([127.0.0.1]:35546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvrRp-0002yx-KG for submit@debbugs.gnu.org; Sun, 16 Oct 2016 15:50:17 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:49548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvrRo-0002yl-8x for 24706@debbugs.gnu.org; Sun, 16 Oct 2016 15:50:16 -0400 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u9GJoASo018742 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 16 Oct 2016 19:50:10 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u9GJoA7q023296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 16 Oct 2016 19:50:10 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u9GJo9Wd020575; Sun, 16 Oct 2016 19:50:09 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124567 Archived-At: >> Why would you change the behavior, instead of just clarifying >> the doc? > > I generally prefer the behavior to be as strict as possible. > Consider (foo-mode 'disable) If you read such code, do you > assume that this enables foo-mode? If I understand the function, then yes. But I agree that the doc could make the function behavior clearer. That example is akin to this: (deconst two 42) (+ 3 two) There are plenty of ways to write code that is perverse in terms of readability (whether or not it has the right behavior). > However, in this case I guess it's too late, and fixing the > documentation is indeed more appropriate. It would be a backward-incompatible change. (And I do not see any advantage to it. But others might disagree with me and agree with you.)