From: Drew Adams <drew.adams@oracle.com>
To: Christopher Thorne <c.thorne@reckondigital.com>, 34621@debbugs.gnu.org
Subject: bug#34621: Patch Update
Date: Mon, 4 Mar 2019 07:26:27 -0800 (PST) [thread overview]
Message-ID: <fddfed8f-e4b9-4a14-887a-b27cc0fe4b2b@default> (raw)
In-Reply-To: <d7facb5fddda54484e2a8ed7fa31c481@reckondigital.com>
> + (not (eq major-mode 'dired-mode))
> + (not (eq major-mode 'dired-mode))
I haven't followed this thread at all - dunno
what the problem is that you're trying to solve.
But I'm a bit surprised that Dired needs to be
special-cased for grep in any way.
Anyway, the reasom I'm writing is to suggest
that you probably don't want
(eq major-mode 'dired-mode). You probably
want (derived-mode-p 'dired-mode).
next prev parent reply other threads:[~2019-03-04 15:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 17:29 bug#34621: [PATCH] lisp/progmodes/grep.el (grep-read-files): Add file-directory-p check Christopher Thorne
2019-03-04 11:13 ` bug#34621: Patch Update Christopher Thorne
2019-03-04 15:26 ` Drew Adams [this message]
2019-03-05 10:49 ` Christopher Thorne
2019-03-05 17:48 ` Drew Adams
2019-03-05 18:22 ` Christopher Thorne
2019-03-05 18:44 ` Drew Adams
2019-03-06 11:10 ` Christopher Thorne
2019-03-17 21:28 ` bug#34621: [PATCH] lisp/progmodes/grep.el (grep-read-files): Add file-directory-p check Juri Linkov
2019-04-08 10:41 ` bug#34621: [PATCH] Fix rgrep in dired taking default search file pattern from directory name (e.g. *.11 for django-1.11) Christopher Thorne
2019-04-08 19:44 ` Juri Linkov
2019-04-09 11:09 ` Christopher Thorne
2019-04-09 11:52 ` Noam Postavsky
2019-04-09 12:23 ` Christopher Thorne
2019-04-09 14:18 ` Eli Zaretskii
2019-04-09 14:32 ` Christopher Thorne
2019-04-09 20:32 ` Juri Linkov
2019-04-10 10:42 ` Christopher Thorne
2019-04-10 20:37 ` Juri Linkov
2019-04-11 20:51 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fddfed8f-e4b9-4a14-887a-b27cc0fe4b2b@default \
--to=drew.adams@oracle.com \
--cc=34621@debbugs.gnu.org \
--cc=c.thorne@reckondigital.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.