all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 25627@debbugs.gnu.org
Subject: bug#25627: 25.1; `help-make-xrefs' loads `cl-extra.el' now
Date: Sun, 5 Feb 2017 11:24:52 -0800 (PST)	[thread overview]
Message-ID: <fdc98b2f-d5c1-4c7d-a3b6-48a8ea6bb6fa@default> (raw)
In-Reply-To: <82c8d359-fd05-4bff-9dba-29d2738d435d@default>

It's also not clear to me why replacing the 3 `cond' clauses
used previously by the clause that uses `cl-some' is TRT (an
improvement). Seems to me like a degradation (bug), but I
don't have a test case.

Was that done to fix some bug?

The previous code was able to in some cases determine that
the symbol is a face or that it is a variable or that it is
a function.  That was replaced by the simple `cl-some' clause,
which just treats it as a symbol (producing all possible help
for it).

If that's the approach, why not just do that in all cases?

It looks like someone came up with `describe-symbol-backends'
for some other purpose and decided it could be reused here:
only the second element of each 3-element list entry is used
here.

Could you please state the rationale behind this change,
even if that is not directly related to this bug, which is
about unnecessarily loading `cl-extra.el'.  Thx.

These are the 3 `cond' clauses that were replaced by the
generic `cl-some' clause:

((and
  (facep sym)
  (save-match-data (looking-at "[ \t\n]+face\\W")))
 (help-xref-button 8 'help-face sym))
((and (or (boundp sym)
	  (get sym 'variable-documentation))
      (fboundp sym))
 ;; We can't intuit whether to use the
 ;; variable or function doc -- supply both.
 (help-xref-button 8 'help-symbol sym))
((and
  (or (boundp sym)
      (get sym 'variable-documentation))
  (or
   (documentation-property
    sym 'variable-documentation)
   (documentation-property
    (indirect-variable sym)
    'variable-documentation)))
 (help-xref-button 8 'help-variable sym))
((fboundp sym)
 (help-xref-button 8 'help-function sym)))))))





  reply	other threads:[~2017-02-05 19:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-05 18:44 bug#25627: 25.1; `help-make-xrefs' loads `cl-extra.el' now Drew Adams
2017-02-05 19:24 ` Drew Adams [this message]
2017-02-07  0:58 ` npostavs
2017-02-07  2:21   ` Drew Adams
2017-02-07 13:30     ` Michael Heerdegen
2017-02-07 16:13       ` Drew Adams
2017-02-07 17:19         ` Michael Heerdegen
2017-02-07 22:29     ` Philipp Stephani
2017-02-07 23:00       ` Drew Adams
2017-02-07 23:08         ` Noam Postavsky
2017-02-08  0:18           ` Drew Adams
2017-02-08  1:56             ` npostavs
2017-02-08  1:59               ` Drew Adams
2017-02-08  4:57                 ` npostavs
2017-02-08  5:40                   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdc98b2f-d5c1-4c7d-a3b6-48a8ea6bb6fa@default \
    --to=drew.adams@oracle.com \
    --cc=25627@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.