From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name Date: Mon, 22 Apr 2019 03:58:30 -0700 (PDT) Message-ID: References: <<96cafba3-7ba2-4e87-8f9d-e53825fd1dde@default> <94feda5f-7afa-4ab5-96f8-60dfaba7e0a4@default> <469bf659-07b6-8172-287c-2abc53582447@yandex.ru> <83zhoi74vl.fsf@gnu.org> <44b1aa8a-c06c-61f7-0948-0fd20605e938@yandex.ru>> <<83y34273mu.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227737"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35353@debbugs.gnu.org To: Eli Zaretskii , Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 22 12:59:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIWfJ-000x8F-VX for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 12:59:14 +0200 Original-Received: from localhost ([127.0.0.1]:35545 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIWfJ-0004Eh-1c for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 06:59:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIWfC-0004EM-SJ for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 06:59:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIWfA-0001Qo-U3 for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 06:59:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIWf8-0001PX-7P for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 06:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIWf8-0001Ex-59 for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 06:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2019 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35353 X-GNU-PR-Package: emacs Original-Received: via spool by 35353-submit@debbugs.gnu.org id=B35353.15559307214741 (code B ref 35353); Mon, 22 Apr 2019 10:59:02 +0000 Original-Received: (at 35353) by debbugs.gnu.org; 22 Apr 2019 10:58:41 +0000 Original-Received: from localhost ([127.0.0.1]:49880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIWen-0001EO-IV for submit@debbugs.gnu.org; Mon, 22 Apr 2019 06:58:41 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:40376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIWem-0001EB-09 for 35353@debbugs.gnu.org; Mon, 22 Apr 2019 06:58:40 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3MArrvD022174; Mon, 22 Apr 2019 10:58:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=N32YxNDmbykPJtAatLJ740lrtW4WwrJ7QDExSn4Ccys=; b=SE1IPmzcpwrcALr215/iJf90+qPEXr2X//+AOYQvYuWNv6G6UoXroGEneGMdQeSpPu+s 1iAxtakVzBZGdt1F5LCLAWdzbBV4bim6s7Iv3A8t6I4S7ND4/IrT/+C/kv6f4BO0aMA2 pa2LhI3oLy98fsqL7vj/39IZSP0O4gBu5KNmgB2ds09szV6w2vQHs+LmhYwEPuEtB2bZ GQtpR4zBHSCurt++AdPR7Eip4fw/gue4xQLA+pZy36ejM4/rjipkpsBmGfvn7nks84i+ JmgzY4MNFM548AOmgJgv6Moo9McAXx5e29P3iZU+Yufv4qV7ZYQS3y9HHfoYYgKGcwxn ZQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2ryv2pwjbh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Apr 2019 10:58:33 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3MAwWfh170688; Mon, 22 Apr 2019 10:58:32 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2s0fv2cgm0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Apr 2019 10:58:32 +0000 Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3MAwVXP022961; Mon, 22 Apr 2019 10:58:31 GMT In-Reply-To: <<83y34273mu.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9234 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=18 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=569 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904220084 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9234 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=18 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=593 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904220084 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158008 Archived-At: > > > I'm not sure I follow: currently, mouse-2 does "follow the link" > > > already, > > > > It calls xref--mouse-2, see xref--button-map. > > That function displays the location, but keeps the Xref window selected= . > > > > > and I believe this bug report will be satisfied if we cause > > > mouse-1 to do the same when mouse-1-click-follows-link is in effect. > > > And mouse-1 is not currently bound in Xref buffers. > > > > ?? It's bound to xref-goto-xref, see the same map. >=20 > Sorry, I just looked in the manual. > So we already support mouse-1 clicks, don't we? > Or am I again missing something? What do you mean by "support mouse-1 clicks"? We support them following a link, but we don't support them not following a link. `mouse-1' clicks follow the link, regardless of `mouse-1-click-follows-link'. When that variable is nil a `mouse-1' click should not follow a link. In the nil case it should typically (default behavior) just set point (or begin a region drag) - `mouse-drag-region' for `down-mouse-1' and `mouse-set-point' for `mouse-1'.