all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 15573@debbugs.gnu.org
Subject: bug#15573: 24.3.50; `comment-end' in c mode
Date: Wed, 9 Oct 2013 08:55:38 -0700 (PDT)	[thread overview]
Message-ID: <fccf1518-28fb-4192-b565-a7cf24e1fed9@default> (raw)

I don't work in C anymore, but I recently noticed that `comment-end' for
C mode seems to be " */", not "*/".  That presumably makes sense for the
use of `comment-end' as "String to insert to end a new comment.", per
the doc string.

But `comment-end' can also be used to recognize the end of a comment,
and in that case I would think that "*/", not " */", would be
appropriate for C.

Case in point: I have some code that does this:

(while (and (< start end) (setq cbeg  (comment-search-forward end 'NOERROR)))
  (setq cend  (if (string= "" comment-end)
                  (min (1+ (line-end-position)) (point-max))
                (search-forward comment-end end 'NOERROR)))
  (when (and cbeg cend)...))

But that fails to DTRT with a comment such as this, because `comment-end'
is not found:

/*
Some comment.
*/

So my question is whether `comment-end' should not perhaps be "*/" for C
code.

I do realize that `comment-skip' is available.  Perhaps I should just
use that somehow in my code, above?  Advice welcome.

I also see that there is `comment-padding', and that "the strings used
as comment ends are built from `comment-end' and `comment-padding'" (doc
string of `comment-region').  Perhaps `comment-end' should be "*/" and
`comment-padding' as " " should be used with it to do what is done now
using " */" as `comment-end' (and "" as `comment-padding')?

Presumably, since lots of people have been using this for a long time, I
just have something to learn wrt my code, above.  Again, please let me
know.  Thx.

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-09-30 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'





             reply	other threads:[~2013-10-09 15:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09 15:55 Drew Adams [this message]
2013-10-09 18:17 ` bug#15573: 24.3.50; `comment-end' in c mode Stefan Monnier
     [not found]   ` <52565D50.5070706@easy-emacs.de>
     [not found]     ` <e6ecb48c-3d29-44b7-bfd2-49be3ee6aeaa@default>
     [not found]       ` <jwvwqiruh77.fsf-monnier+emacsbugs@gnu.org>
2013-12-28 17:09         ` Drew Adams
     [not found]         ` <b63dc9a7-7c49-4cd4-b256-8be93a5a6dea@default>
2014-01-02  2:45           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fccf1518-28fb-4192-b565-a7cf24e1fed9@default \
    --to=drew.adams@oracle.com \
    --cc=15573@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.