* bug#40859: Clicking the wrap-prefix string inside a button causes an error
@ 2020-04-26 3:40 Clément Pit-Claudel
2020-04-26 13:43 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Clément Pit-Claudel @ 2020-04-26 3:40 UTC (permalink / raw)
To: 40859
Hi all,
The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below.
(with-current-buffer (get-buffer-create "*button*")
(erase-buffer)
(insert-text-button
(let ((str "long long long long text "))
(concat str str str str str))
'follow-link t
'action (lambda (&rest args) (print args))
'wrap-prefix "this is the wrap prefix")
(pop-to-buffer (current-buffer)))
Debugger entered--Lisp error: (void-function nil)
nil(("this is the wrap prefix" . 9))
button-activate(("this is the wrap prefix" . 9) t)
push-button((mouse-2 (#<window 13 on *button*> 81 (76 . 29) 379842354 ("this is the wrap prefix" . 9) 81 (9 . 1) nil (4 . 12) (8 . 17))))
funcall-interactively(push-button (mouse-2 (#<window 13 on *button*> 81 (76 . 29) 379842354 ("this is the wrap prefix" . 9) 81 (9 . 1) nil (4 . 12) (8 . 17))))
call-interactively(push-button nil nil)
command-execute(push-button)
Cheers,
Clément.
In GNU Emacs 28.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10)
of 2020-03-15 built on clem-w50-mint
Repository revision: 9dccaf8a5cdb10dae597345ec3741475477a7d97
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Linux Mint 19.3
Recent messages:
Mark set
#<buffer *button*>
button-activate: Symbol’s function definition is void: nil
Debug on Error enabled globally
Entering debugger...
Mark set [2 times]
Saved text until "nil nil)
command-execute(push-button)
"
Mark set
Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD
JSON PDUMPER LCMS2 GMP
Important settings:
value of $LC_MONETARY: en_DK.UTF-8
value of $LC_NUMERIC: en_DK.UTF-8
value of $LC_TIME: en_DK.UTF-8
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config
gnus-util rmail rmail-loaddefs text-property-search seq byte-opt gv
bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils help-fns radix-tree cl-print
debug backtrace help-mode easymenu find-func cus-start cus-load
time-date subr-x cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit
x multi-tty make-network-process emacs)
Memory information:
((conses 16 57304 5023)
(symbols 48 7631 1)
(strings 32 18904 1618)
(string-bytes 1 584373)
(vectors 16 10294)
(vector-slots 8 143875 8980)
(floats 8 30 160)
(intervals 56 309 0)
(buffers 1000 14))
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#40859: Clicking the wrap-prefix string inside a button causes an error
2020-04-26 3:40 bug#40859: Clicking the wrap-prefix string inside a button causes an error Clément Pit-Claudel
@ 2020-04-26 13:43 ` Eli Zaretskii
2020-04-26 15:59 ` Clément Pit-Claudel
2020-04-26 16:44 ` Clément Pit-Claudel
0 siblings, 2 replies; 6+ messages in thread
From: Eli Zaretskii @ 2020-04-26 13:43 UTC (permalink / raw)
To: Clément Pit-Claudel; +Cc: 40859
> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
> Date: Sat, 25 Apr 2020 23:40:38 -0400
>
> The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below.
Isn't that a cockpit error?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#40859: Clicking the wrap-prefix string inside a button causes an error
2020-04-26 13:43 ` Eli Zaretskii
@ 2020-04-26 15:59 ` Clément Pit-Claudel
2020-04-26 16:44 ` Clément Pit-Claudel
1 sibling, 0 replies; 6+ messages in thread
From: Clément Pit-Claudel @ 2020-04-26 15:59 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 40859
On 26/04/2020 09.43, Eli Zaretskii wrote:
>> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
>> Date: Sat, 25 Apr 2020 23:40:38 -0400
>>
>> The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below.
>
> Isn't that a cockpit error?
Nope, I think not. It's button.el getting confused about where the click came from. And it's not fixable from the cockpit, I think, since wrap-prefixes and other replacing display specs can't have extra properties like an 'action that would make button.el happy.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#40859: Clicking the wrap-prefix string inside a button causes an error
2020-04-26 13:43 ` Eli Zaretskii
2020-04-26 15:59 ` Clément Pit-Claudel
@ 2020-04-26 16:44 ` Clément Pit-Claudel
2020-04-26 18:27 ` Clément Pit-Claudel
1 sibling, 1 reply; 6+ messages in thread
From: Clément Pit-Claudel @ 2020-04-26 16:44 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 40859
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
On 26/04/2020 09.43, Eli Zaretskii wrote:
>> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
>> Date: Sat, 25 Apr 2020 23:40:38 -0400
>>
>> The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below.
>
> Isn't that a cockpit error?
Here's a tentative patch, but I can't claim to understand the button.el code well :/
[-- Attachment #2: 0001-Only-treat-display-strings-as-buttons-if-they-have-a.patch --]
[-- Type: text/x-patch, Size: 1400 bytes --]
From 11034798933a1e0c9498b0409cd463acb822f2d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Pit-Claudel?= <clement.pitclaudel@live.com>
Date: Sun, 26 Apr 2020 12:41:42 -0400
Subject: [PATCH] Only treat display strings as buttons if they have a 'button
property
* lisp/button.el (push-button): Use posn-point instead of posn-string
if the string doesn't have a 'button property (Bug#40859).
---
lisp/button.el | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lisp/button.el b/lisp/button.el
index b3afc4eca2..c33a3e8ac2 100644
--- a/lisp/button.el
+++ b/lisp/button.el
@@ -469,10 +469,12 @@ push-button
;; POS is a mouse event; switch to the proper window/buffer
(let ((posn (event-start pos)))
(with-current-buffer (window-buffer (posn-window posn))
- (if (posn-string posn)
- ;; mode-line, header-line, or display string event.
- (button-activate (posn-string posn) t)
- (push-button (posn-point posn) t))))
+ (let* ((str (posn-string posn))
+ (str-button (get-text-property (cdr str) 'button (car str))))
+ (if (and str str-button)
+ ;; mode-line, header-line, or display string event.
+ (button-activate str t)
+ (push-button (posn-point posn) t)))))
;; POS is just normal position
(let ((button (button-at (or pos (point)))))
(when button
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#40859: Clicking the wrap-prefix string inside a button causes an error
2020-04-26 16:44 ` Clément Pit-Claudel
@ 2020-04-26 18:27 ` Clément Pit-Claudel
2020-05-09 7:43 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Clément Pit-Claudel @ 2020-04-26 18:27 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 40859
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On 26/04/2020 12.44, Clément Pit-Claudel wrote:
> On 26/04/2020 09.43, Eli Zaretskii wrote:
>>> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
>>> Date: Sat, 25 Apr 2020 23:40:38 -0400
>>>
>>> The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below.
>>
>> Isn't that a cockpit error?
>
> Here's a tentative patch, but I can't claim to understand the button.el code well :/
A slightly revised version.
[-- Attachment #2: 0001-Only-treat-display-strings-as-buttons-if-they-have-a.patch --]
[-- Type: text/x-patch, Size: 1400 bytes --]
From fd57a05b6598de77dbf9a7ba66a15dc1cd9568a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Pit-Claudel?= <clement.pitclaudel@live.com>
Date: Sun, 26 Apr 2020 12:41:42 -0400
Subject: [PATCH] Only treat display strings as buttons if they have a 'button
property
* lisp/button.el (push-button): Use posn-point instead of posn-string
if the string doesn't have a 'button property (Bug#40859).
---
lisp/button.el | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lisp/button.el b/lisp/button.el
index b3afc4eca2..3a6a6de774 100644
--- a/lisp/button.el
+++ b/lisp/button.el
@@ -469,10 +469,12 @@ push-button
;; POS is a mouse event; switch to the proper window/buffer
(let ((posn (event-start pos)))
(with-current-buffer (window-buffer (posn-window posn))
- (if (posn-string posn)
- ;; mode-line, header-line, or display string event.
- (button-activate (posn-string posn) t)
- (push-button (posn-point posn) t))))
+ (let* ((str (posn-string posn))
+ (str-button (and str (get-text-property (cdr str) 'button (car str)))))
+ (if str-button
+ ;; mode-line, header-line, or display string event.
+ (button-activate str t)
+ (push-button (posn-point posn) t)))))
;; POS is just normal position
(let ((button (button-at (or pos (point)))))
(when button
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#40859: Clicking the wrap-prefix string inside a button causes an error
2020-04-26 18:27 ` Clément Pit-Claudel
@ 2020-05-09 7:43 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2020-05-09 7:43 UTC (permalink / raw)
To: Clément Pit-Claudel; +Cc: 40859-done
> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
> Cc: 40859@debbugs.gnu.org
> Date: Sun, 26 Apr 2020 14:27:48 -0400
>
> A slightly revised version.
Thanks, pushed to the master branch.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-09 7:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-26 3:40 bug#40859: Clicking the wrap-prefix string inside a button causes an error Clément Pit-Claudel
2020-04-26 13:43 ` Eli Zaretskii
2020-04-26 15:59 ` Clément Pit-Claudel
2020-04-26 16:44 ` Clément Pit-Claudel
2020-04-26 18:27 ` Clément Pit-Claudel
2020-05-09 7:43 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.