From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: xassert in dispextern.h Date: Wed, 2 Mar 2005 07:50:53 +0900 Message-ID: References: Reply-To: snogglethorpe@gmail.com, miles@gnu.org NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1109718088 12773 80.91.229.2 (1 Mar 2005 23:01:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 1 Mar 2005 23:01:28 +0000 (UTC) Cc: emacs-devel@gnu.org, Jason Rumney , "Kim F. Storm" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 02 00:01:27 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D6GMe-0005Fa-NJ for ged-emacs-devel@m.gmane.org; Wed, 02 Mar 2005 00:01:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D6GfI-00055H-Lr for ged-emacs-devel@m.gmane.org; Tue, 01 Mar 2005 18:20:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D6Gdq-0004YL-JS for emacs-devel@gnu.org; Tue, 01 Mar 2005 18:19:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D6Gdh-0004U6-7Z for emacs-devel@gnu.org; Tue, 01 Mar 2005 18:18:55 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D6Gdg-0004Oh-FM for emacs-devel@gnu.org; Tue, 01 Mar 2005 18:18:52 -0500 Original-Received: from [64.233.184.206] (helo=wproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D6GCc-000335-7F for emacs-devel@gnu.org; Tue, 01 Mar 2005 17:50:54 -0500 Original-Received: by wproxy.gmail.com with SMTP id 40so109914wri for ; Tue, 01 Mar 2005 14:50:53 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=XFsd+enZdWc5eCLjRkf2PN3z0mQUW9WmPNnEP5myotczMCK0TpHBwkI8J18rHPlkrglYYDdP+54DSfi9mjrSJ1Us+VtZko6IcHVOzQGC/VcXqqSw5gPYCsVz7li06HE3fRTyEVamS42YVqH/cVA3qZDj/Q4VhsBZr7AextNitF4= Original-Received: by 10.54.17.10 with SMTP id 10mr99748wrq; Tue, 01 Mar 2005 14:50:53 -0800 (PST) Original-Received: by 10.54.19.70 with HTTP; Tue, 1 Mar 2005 14:50:53 -0800 (PST) Original-To: David Kastrup In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: main.gmane.org gmane.emacs.devel:34011 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34011 The right answer is to change those xasserts (and _only_ those) which cause a problem or test something silly or are insanely inefficient [99% are quite efficient] to use some other macro, like "gdassert" or something, and make gdassert dependent on GLYPH_DEBUG. [I should note that the thing which caused me to originally enable xassert by default is that it caught (I always have it enabled) a case where iterator stacks could overflow -- something that otherwise would just result in rare, hard to debug, memory corruption.] -Miles