From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#37507: 26.3; Non-number value for `fill-column' causes wrong-type-arg error for `C-h f' Date: Tue, 24 Sep 2019 13:49:54 -0700 (PDT) Message-ID: References: <326973dd-0844-40e1-ad2e-55b3a7ea35bf@default> <85lfudjwt0.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="139879"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37507@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 24 22:55:55 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCrql-000aHs-Fx for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 22:55:55 +0200 Original-Received: from localhost ([::1]:51150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrqk-0000Fq-3h for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 16:55:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54028) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrm3-00022e-Qm for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 16:51:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCrm2-0000Hs-Mn for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 16:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59651) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iCrm2-0000He-Hu for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 16:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iCrm2-0006kY-Ed for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 16:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2019 20:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37507 X-GNU-PR-Package: emacs Original-Received: via spool by 37507-submit@debbugs.gnu.org id=B37507.156935820725866 (code B ref 37507); Tue, 24 Sep 2019 20:51:02 +0000 Original-Received: (at 37507) by debbugs.gnu.org; 24 Sep 2019 20:50:07 +0000 Original-Received: from localhost ([127.0.0.1]:40239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCrl7-0006j6-VD for submit@debbugs.gnu.org; Tue, 24 Sep 2019 16:50:06 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:35828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCrl5-0006iR-7x for 37507@debbugs.gnu.org; Tue, 24 Sep 2019 16:50:03 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8OKnZng052556; Tue, 24 Sep 2019 20:49:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=4wtpHgqfmYPr+0rDkQYmpk4yyU1ZA/BVvfnQrNjNzgo=; b=GpiYD91ptOEiL/1bwdvHvzUrqAyIPmVCdYFEZGnJLl+xS6HnwY0/xwPjKhBpOL+agT5C v0KnAPgbXoWw3gcbXrBhh+t+0nXsc6tO2+q1G1F6X3a97zTHN8xIJt752bgDFszXJYYX n+rsre2luZOLnLQPvIdsbmbEOvRtB5CTFtqpv3cWewVdSqP0ElzwYaNiJTlHe7/yNp7F t5UPdYagI44BNvEvDReLQBWv8JnWmcRAT0mJEnG33kIwSzWm5LLgfxgHE0DxRrnQ7WuS ke2EtMU96YnXsil5Zz7Jw9qhl/OG5KceWqu1Gnzsmytlr5H1oYCSP2rZoOKSjnaSbjwT PQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2v5cgr0nnc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Sep 2019 20:49:56 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8OKhV0s090820; Tue, 24 Sep 2019 20:49:55 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2v6yvsgmqx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Sep 2019 20:49:55 +0000 Original-Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x8OKntTY025546; Tue, 24 Sep 2019 20:49:55 GMT In-Reply-To: <85lfudjwt0.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4888.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9390 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909240168 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9390 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909240169 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167126 Archived-At: > > `fill-column' is supposed to have an integer value > 0. > > > > But if it has a non-numeric value then other functions > > can barf, unless they watch out for that. >=20 > Shouldn't users just not set it to a non-numeric value then? Should? Yes. Just? I don't see why. > I'm sure you can cause all sort of errors by setting > things to invalid values. And? If this is only about users setting the value then the answer is for them to always use `set-fill-column'. "Should [eom]." But is there a reason why this shouldn't be protected here?' I wonder even whether there is a reason why `current-column' shouldn't prevent that particular error by, say, substituting 0 for a `fill-column' value that's not an integer > 0. I don't propose that at this point (might break something that depends on raising an error?), but I wonder if it wouldn't be reasonable for `current-column' to do.