From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase Date: Wed, 22 May 2024 21:35:29 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37353"; mail-complaints-to="usenet@ciao.gmane.io" To: Robin Campbell Joy , 71107@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 23 06:37:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sA0Ch-0009aE-0P for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 May 2024 06:37:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sA0CI-0003bj-I3; Thu, 23 May 2024 00:36:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA0CG-0003ay-UM for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 00:36:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sA0CG-0003mz-AG for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 00:36:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sA0CM-0005ux-0q for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 00:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 May 2024 04:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71107 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71107-submit@debbugs.gnu.org id=B71107.171643900622739 (code B ref 71107); Thu, 23 May 2024 04:37:01 +0000 Original-Received: (at 71107) by debbugs.gnu.org; 23 May 2024 04:36:46 +0000 Original-Received: from localhost ([127.0.0.1]:58334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA0C5-0005uh-Mg for submit@debbugs.gnu.org; Thu, 23 May 2024 00:36:46 -0400 Original-Received: from mail-pl1-f171.google.com ([209.85.214.171]:56737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA0C2-0005ub-CJ for 71107@debbugs.gnu.org; Thu, 23 May 2024 00:36:44 -0400 Original-Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1f335e8d493so839405ad.1 for <71107@debbugs.gnu.org>; Wed, 22 May 2024 21:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716438930; x=1717043730; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=put3T+B3EkAi1XuxElWcBwCQOBbXIYjJ8R+r2luWggQ=; b=dXmqDcvgmLLqQE5M8LKcoaMUvo3el/GuvzdpgeRIpTkMG+xgGhsmWvrzupnvXteYPl r3H3CkWdJNvf3UW+3DCXqBXL7ZjgZR16frEz1J2me5nx5yDlDsbrXexmZfvnj7u/YpBc 9YN5zzekYsnjKFMrwY8jNwzDUlfpJajj/M7zLZpelLqUJiqbfQDxIkjah91FKAxCQQ5L Z7rQC3x8UkqMg8Qps/2I4BWADyVZPFFVtg64kizDKPwb/BeoGVFFNB1Pu6CwedpLNRm1 fIIAdZKtzzrcD1Bc11Y4rnZiiIMe9ckpz+WV77nrwX6k8asTqKiJvcbjothmsPY0Rkkk I8Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716438930; x=1717043730; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=put3T+B3EkAi1XuxElWcBwCQOBbXIYjJ8R+r2luWggQ=; b=YL9NTXHWTNM/no1C/d04pACe4eKPydcYdjE20NwUhwOHpiWeurqjH6RegWnAlQ2H2a G/3GGzsMhLB2WQUgOMDHxEIMLNNhcBVQYLmrqd5hZ5NL6phL7x4MbFFQiLXjac4+5SXE 91MRnRQKbJ0p08e7bRn17UZt/ED9+WBlu5/QjOJ5P4QZeV5geIZHQEoGVF5sqt+t3mAq 323WkfVjtEcuP+ZYA+7y2gr+NFPQcxvfq1n7OrPdbnGQHcZ/i50MKnYX8SMREJ6kiwi4 +Jyx8DxvwwjB1+OrDKSUl34MBtEaQdqQmsuPzbs2AHB7fmF4c9U9SNZux2d33pUnIuZs erAQ== X-Forwarded-Encrypted: i=1; AJvYcCWw9zpoi7Tcvk/1im9aDATQkwd4QLS8HzUrJ/8ZFet3VKP+SFIHJmTo0xfYHQ1A4vekzXCsxeakdYQD44rLToKYpt73vHk= X-Gm-Message-State: AOJu0YxZScWjnmgZ5jiIxU9IcwJoUR1y7NbpFvF0ELKwR7ipax7bzNP4 u8PcfJpwtiPmUSS+TQbaZw/T8okY+YdAicJSdBrUlALy0DAiL7Lw X-Google-Smtp-Source: AGHT+IEukjkxz21sdAhZFyibSYp1WX+8nnGP8qCvR8SN9bgFImYAoc6jIYeY2iAk3JyS27DDfmhpVA== X-Received: by 2002:a17:902:e748:b0:1f3:1ca6:8a49 with SMTP id d9443c01a7336-1f31ca68aacmr45206095ad.65.1716438930014; Wed, 22 May 2024 21:35:30 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f3469384e6sm689305ad.283.2024.05.22.21.35.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 21:35:29 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285669 Archived-At: On 5/22/2024 1:21 AM, Robin Campbell Joy wrote: > Severity: minor > Tags: patch > > In case of eshell-hist-ingoredups set to 'erase, history handling isn't > working correctly. I believe this should already be fixed by commit 7b0f24ab1f9 from bug#63360. However, I didn't bother to account for the case where there may be multiple entries to remove (I just added a FIXME note since it seemed like a low priority). If removing multiple duplicates is important to you, would you be willing to rebase your patch on top of the master branch? Thanks either way.