all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Scan of broken conditional forms
@ 2020-01-04 12:37 Mattias Engdegård
  2020-01-04 13:03 ` Michael Albinus
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Mattias Engdegård @ 2020-01-04 12:37 UTC (permalink / raw)
  To: Emacs developers

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

Out of curiosity, I scanned the Emacs sources for useless conditional forms, like (if C X X) where both branches are the same, and found a few. Some look like unfinished code, but a several appear to be clear bugs. (I'm guilty of the one in autorevert.el, now fixed.)

In particular, the code in mml-smime.el looks like it fails to return failure from an unsuccessful encryption attempt. That can't be good.


[-- Attachment #2: iffy.log --]
[-- Type: application/octet-stream, Size: 791 bytes --]

;;; -*- compilation -*-

lisp/international/titdic-cnv.el:740: (if CONDITION X X)
lisp/international/titdic-cnv.el:741: (if CONDITION X X)
lisp/autorevert.el:736: (unless CONDITION)
lisp/emacs-lisp/tabulated-list.el:549: (when CONDITION)
lisp/filesets.el:1651: (if CONDITION CONST1 CONST2) ...
lisp/cedet/ede/cpp-root.el:490: (if CONDITION CONST) ...
lisp/cedet/ede/pconf.el:55: (when CONDITION)
lisp/cedet/srecode/semantic.el:203: (when CONDITION CONST) ...
lisp/gnus/gnus-cloud.el:243: (when CONDITION)
lisp/gnus/mml-smime.el:157: (if CONDITION (progn A t) A nil)
lisp/net/nsm.el:297: (when CONDITION)
lisp/net/tramp-sudoedit.el:509: (when CONDITION)
lisp/org/ox-odt.el:942: (if CONDITION X X)
lisp/org/org-agenda.el:8984: (when CONDITION)
lisp/textmodes/table.el:3210: (unless CONDITION)

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2021-01-27 17:35 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-04 12:37 Scan of broken conditional forms Mattias Engdegård
2020-01-04 13:03 ` Michael Albinus
2020-01-04 19:23 ` Paul Eggert
2020-01-04 19:39   ` Eli Zaretskii
2020-01-04 21:40     ` Paul Eggert
2020-01-05 15:45       ` Eli Zaretskii
2020-01-05 20:48         ` Paul Eggert
2020-01-05 20:57           ` Stefan Monnier
2021-01-27  3:02           ` Broken `if big5-p` code in titdic-cnv.el (was: Scan of broken conditional forms) Stefan Monnier
2021-01-27  8:18             ` Broken `if big5-p` code in titdic-cnv.el Andreas Schwab
2021-01-27 16:16             ` Broken `if big5-p` code in titdic-cnv.el (was: Scan of broken conditional forms) Eli Zaretskii
2021-01-27 17:35               ` Broken `if big5-p` code in titdic-cnv.el Stefan Monnier
2020-01-04 22:04   ` Scan of broken conditional forms Mattias Engdegård
2020-01-04 22:11     ` Paul Eggert
2020-01-31 16:22 ` Bastien

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.