From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: rust-ts-mode: appropriately fontify doc strings Date: Sat, 2 Dec 2023 19:04:32 +0200 Message-ID: References: <8734wotac6.fsf@poincare.umons.ac.be> <87il5is524.fsf@poincare.umons.ac.be> <83o7f982dc.fsf@gnu.org> <87r0k4q43t.fsf@poincare.umons.ac.be> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16649"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: "emacs-devel@gnu.org" To: Christophe TROESTLER , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 02 18:05:06 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r9TQO-0003z0-RY for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Dec 2023 18:05:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9TQ1-0008QR-1J; Sat, 02 Dec 2023 12:04:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9TPy-0008Pq-Lu for emacs-devel@gnu.org; Sat, 02 Dec 2023 12:04:38 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9TPw-0005jZ-Nd; Sat, 02 Dec 2023 12:04:38 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 94EFA5C01A0; Sat, 2 Dec 2023 12:04:35 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 02 Dec 2023 12:04:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1701536675; x=1701623075; bh=D3Cq9gxQxIYdSzHJoMgJDuD7gzRhES02cur ftclXMU4=; b=U4Sh7NVdSuULAmj96LFisj8HpS2uvL0KP8Ui2Bv4SAI1UU1y5nU qiUXG165qgTsE4ooRjZ4ip/HUsiZJ1aeY498peduh0pVCDVy1x7pE8ktW9UdvE5X elZxN+uTOkVKP8wPMCNAYMW5q0R8XxjsohmTtCEuJHx9+m8UG2luxUeVqIJRnfYK OZZvafIDFnKykqn6T4HAkQgs509nUWlyPOhS3eMp59ifquzSIXvll+p/9gjWCj5m fUmoqYowq8+wCaSMl0vmXtYgq1Z2c/E36KxYkQfPOVNGmmtqmhaeXV2DQV9IVO9I tlJPfMF+drDCXhReJRI12JrAVP2eLVLrOBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701536675; x=1701623075; bh=D3Cq9gxQxIYdSzHJoMgJDuD7gzRhES02cur ftclXMU4=; b=fpFjQjd/bV9UjNRCZfDFpxMVK835kRa5h6Yq3FlIxcQYaeoE1cS IuHCSTKfK9G3b5+1bgS0PXaUQhS2OyjIxntQVZR2sKankYRELSffrkKHp856pp7k oLWg9rRlGHRxCyefYoB7sSZbgpz14WqvT2CLE4VKKY914QBlGJc+ADJcQfWf4v9/ IdhpOAe9nILlNv9wATBYP252fIC6/mZ5TqhzFeSwMyGnBAkjEILcLyXc2XjPFW7j hU5/W6UvEGcHSTRwWuwnzGUE3uNFnQ2i9daqzQmauSqYIVgv5QMYhrrZ41Vr7f8/ oYkxVlqRsyRT22QguSMYUrPovOsiS0kHWtg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudejuddgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepkeeljeehvedthfffueegvdeilefffeffueefvdfhudeukeetfefhuedvudeg jeeknecuffhomhgrihhnpehruhhsthdqlhgrnhhgrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdgu vghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 2 Dec 2023 12:04:33 -0500 (EST) Content-Language: en-US In-Reply-To: <87r0k4q43t.fsf@poincare.umons.ac.be> Received-SPF: pass client-ip=66.111.4.28; envelope-from=dmitry@gutov.dev; helo=out4-smtp.messagingengine.com X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.797, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313472 Archived-At: On 02/12/2023 12:40, Christophe TROESTLER wrote: > On 2 December 2023 at 08:55 +01, Eli Zaretskii wrote: >> […] This seems to result in >> >> ELC progmodes/rust-ts-mode.elc >> >> In rust-ts-mode--comment-docstring: >> progmodes/rust-ts-mode.el:290:61: Warning: Unused lexical argument `end' > Thanks for spotting this and sorry for it. Here is an updated patch. Thanks for the update, see commit a547b0e2e83 in emacs-29. And I suppose for completeness, we should also support the "block" versions of the outer/inner docs? Like documented here: https://doc.rust-lang.org/reference/comments.html The description also mentions that //// and /*** should be interpreted as "Only a comment", which will require a further more complex regexp. It's not urgent, this is just where googling led me to.