all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: rust-ts-mode: appropriately fontify doc strings
Date: Fri, 1 Dec 2023 19:41:15 -0800	[thread overview]
Message-ID: <fb21b841-9e0d-44c9-a8e2-b040c594ac63@gmail.com> (raw)
In-Reply-To: <cf277ceb-5ac5-c6f8-6151-6e6671a37f49@gutov.dev>



On 12/1/23 3:58 PM, Dmitry Gutov wrote:
> On 01/12/2023 10:25, Christophe TROESTLER wrote:
>> Hi,
>>
>> On  1 December 2023 at 01:50 +01, Dmitry Gutov<dmitry@gutov.dev>  
>> wrote:
>>> On 30/11/2023 01:21, Christophe TROESTLER wrote:
>>>> +         (prefix (buffer-substring-no-properties beg (min (+ beg 
>>>> 3) end)))
>>>> +         (face (if (string-equal "///" prefix)
>>> It'll probably be faster overall to use save-excursion and looking-at
>>> instead of creating a substring.
>> Thanks for your feedback. I did dome tests and the two are comparable 
>> (on Emacs 29.1) but here is a version that uses your suggestion.
>
> Thanks! I'd rather err on the side of this one, even if initial 
> testing shows the approaches are comparable. It's good to have 
> verified that it's not slower, anyway.
>
> I've pushed it to emacs-29. In the future, please send patches to the 
> bug tracker, though (then it's easier to ensure they are not lost).
>
Thanks to you both!

Yuan



  parent reply	other threads:[~2023-12-02  3:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 23:21 rust-ts-mode: appropriately fontify doc strings Christophe TROESTLER
2023-12-01  0:50 ` Dmitry Gutov
2023-12-01  8:25   ` Christophe TROESTLER
2023-12-01 21:38     ` Christophe TROESTLER
2023-12-01 23:58     ` Dmitry Gutov
2023-12-02  0:59       ` Christophe TROESTLER
2023-12-02  3:41       ` Yuan Fu [this message]
2023-12-02  7:55       ` Eli Zaretskii
2023-12-02 10:40         ` Christophe TROESTLER
2023-12-02 17:04           ` Dmitry Gutov
2023-12-02 20:57             ` Christophe TROESTLER
2023-12-03 14:12               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb21b841-9e0d-44c9-a8e2-b040c594ac63@gmail.com \
    --to=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.