From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] assq-delete-all, rassq-delete-all: Avoid duplication of code Date: Mon, 28 Nov 2016 13:17:08 -0500 Message-ID: References: <87zikk9biz.fsf@gmail.com> <83eg1vzfdv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Uu4wllA7CdxSo7s5BDEL4uiQHKoRH3fRC" X-Trace: blaine.gmane.org 1480357085 13842 195.159.176.226 (28 Nov 2016 18:18:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 28 Nov 2016 18:18:05 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 28 19:18:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBQV7-0002wu-Ot for ged-emacs-devel@m.gmane.org; Mon, 28 Nov 2016 19:18:01 +0100 Original-Received: from localhost ([::1]:60483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBQVB-0006cr-8v for ged-emacs-devel@m.gmane.org; Mon, 28 Nov 2016 13:18:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBQUV-0006Fb-46 for emacs-devel@gnu.org; Mon, 28 Nov 2016 13:17:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBQUQ-0007xt-5M for emacs-devel@gnu.org; Mon, 28 Nov 2016 13:17:23 -0500 Original-Received: from mout.kundenserver.de ([217.72.192.73]:51375) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cBQUP-0007x6-PA for emacs-devel@gnu.org; Mon, 28 Nov 2016 13:17:18 -0500 Original-Received: from [18.26.2.123] ([18.26.2.123]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.184]) with ESMTPSA (Nemesis) id 0Mc9Nn-1cSgG419sN-00JcpB for ; Mon, 28 Nov 2016 19:17:15 +0100 In-Reply-To: <83eg1vzfdv.fsf@gnu.org> X-Provags-ID: V03:K0:amX9+t0iuHwHWO6w/+9FFCCxyYiFJG/l9pZG6+dQu0z/C2+d4bw KAVRF5dL4nP10m5QRVsFI2nYNgyBLuh4/8yY+sSqHGt5RYSrnlnEmLhxiO22hfUcBZhXgN5 lQQoQa0qJDdZR6D7PJ67N6UnQAE1VLhBCJS5cCsA6Ic/J8LbxBZ4pWpLzEwZAQ8A9MslR4o lPZdylZbmmTe88qGzOHXQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:PWqKKihO+rA=:oFchsER+vkBPOwwZSjXOCq bmmReZvD9TLf2Nog0+FQ5r4xPRxOiAO5wPPy90e3erhWiaIUiHrUfniDgsBdNsRoahq+waK16 10lJuwm3EAOdAez1P8tRxMLgK3PqwoqhVCAZX5A9+Yjq7ih/QfiYrmz2G9l3umlc8HwadH2fy XEFnH1CvB0qOhdTKCKjWBLqz4iH61Eh7gazHR7pBNZ06Dbr6IPo70ypqqqvDuR8Q/dllRMOSH AIVTnrLFRPkj89Z7ibGOUSpFiD+jEdZJ0eq/ukrdc1CmV3vlwfHkpJiHI7DUJ39F418AuwJ4I KGXHS8JEtjFhvuKt+mdxptyJ00YSVNOwH3YOQjVhjk+E5PoX9/+09QVqJOl1y2PvSFYKjYuGx cN1tN/WdX3XgFMcuuGvefb+S3tvxGSkEPMGxCDQnbgthY/0pcSn/CEW7apqryNa9ypZeJ5wAP O7an10yrZW15dQbmFeLN6PPVjwePPTmMjcKh7+UqpbNc9AkYrCc8QsoNOEQZgrFXrRLbUvjB/ PGfQH3lbpqjYxEdDZFP78ybMcxRrzZ7Vk1B45Ru9QZsHk4W2h9oZ+VwB52q6eu+X5YxKDTwle jXUanH8bKWwAN/f/QwfW1qLn0jEDgbnEng7BGEtdN6iEBTR5kEtORXEiNLrpokixO2gXltu8k 9WIlIje4aUw5jkM4dg7tln2xzRSxf+J/mRO4bf8kUQdQ9gEDjmULn6+hz2/ZFrUd5ueY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.72.192.73 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209664 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Uu4wllA7CdxSo7s5BDEL4uiQHKoRH3fRC Content-Type: multipart/mixed; boundary="DTT9Nv028Gg56NrCMFiFCf1GQoPAsSIol"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: emacs-devel@gnu.org Message-ID: Subject: Re: [PATCH] assq-delete-all, rassq-delete-all: Avoid duplication of code References: <87zikk9biz.fsf@gmail.com> <83eg1vzfdv.fsf@gnu.org> In-Reply-To: <83eg1vzfdv.fsf@gnu.org> --DTT9Nv028Gg56NrCMFiFCf1GQoPAsSIol Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2016-11-28 12:24, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Mon, 28 Nov 2016 18:52:36 +0900 >> Cc: tino.calancha@gmail.com >> >> how about following patch? >> It prevent some duplication of code in subr.el, and it adds >> a new test. >=20 > What about the overhead of a function call? These functions are > likely to be invoked in loops. >=20 > Should we make the common part a defsubst? Would defsubst be enough? I think you'd want a defmacro. Otherwise, you'= ll still pay for all the funcalls to #'car and #'cdr, won't you? --DTT9Nv028Gg56NrCMFiFCf1GQoPAsSIol-- --Uu4wllA7CdxSo7s5BDEL4uiQHKoRH3fRC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYPHSkAAoJEPqg+cTm90wjg94QAJpLQQn6qs8DoX8Bn9I0Hv5E RGn7X44oTQ5F9wbVJ2rQfqyjugaV+zdmBGVl+2ZnfgN8gD/KZPyTlVxHymNNT5dm gpF9kedrRyLVJxR455qkX2x/K/JLH9PAVkg/Uyxi8WJLn4xziclU+5pWS+rN/+Ma N5otu0j3xA7QfO+JhJbawmr0Pt0qeU2CKprxN0vrGdWrhYaNWubKWkyAoGo2MJnJ fq6SYJ5xcfyPvcHHgnHUt+6zfJisvcipi7hO3GmAEbE4sD6ybu8chPwPnEEOfV+n YwPW7hkz7jQrR6QPIhzaBZpXUNTLRTnA6aFlcMHyyGelCVvW2BE18ym48wrKVInK VAzIst4IikJWKR4tn1vXSj6FxUFTL40+k03x5sgnduLt9p2WejgFs3H4/hjUTnTy RxMhT6130xRdVzEfy4TgkcB8VJvTr6HA9j+v9Av9WB5g3YUbGoyFB1qGPDE24Chr pTvhDjwoymTJWc4krVyqtdMZnK5LZATiE2tNMCUIXeO45c/oPVnEDCqsxjEupRv+ 5q4lwoZmyUPvW9j6Rqm/AHEgfvX23FkpIH3vk0O3QwCU2OJ/08VjY6ujnTzTQBq2 Ld8VA5CVTQsyR1teOdAFHhBjNm8toWENzTZG1WPfTmozOWUz+VEBny/tj74m/Lq3 qrTNt85c1DLOLsINrt48 =Hi5E -----END PGP SIGNATURE----- --Uu4wllA7CdxSo7s5BDEL4uiQHKoRH3fRC--