From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Newsgroups: gmane.emacs.bugs Subject: bug#24035: 25.1.50; Eww breaks on images? Date: Wed, 20 Jul 2016 16:13:57 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qdEk6ppwH0UwWLn5oXLlk5nd5e9cH3Xtj" X-Trace: ger.gmane.org 1469045729 29615 80.91.229.3 (20 Jul 2016 20:15:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Jul 2016 20:15:29 +0000 (UTC) To: 24035@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 20 22:15:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPxtk-0007wi-He for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jul 2016 22:15:16 +0200 Original-Received: from localhost ([::1]:36877 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPxtj-00039M-NX for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jul 2016 16:15:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPxta-00034N-GY for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 16:15:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPxtW-0006UN-8N for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 16:15:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPxtW-0006UI-4n for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 16:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPxtW-0004bP-10 for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 16:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jul 2016 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24035 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.146904567017637 (code B ref -1); Wed, 20 Jul 2016 20:15:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Jul 2016 20:14:30 +0000 Original-Received: from localhost ([127.0.0.1]:58944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPxsz-0004aO-OH for submit@debbugs.gnu.org; Wed, 20 Jul 2016 16:14:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPxsy-0004aE-Cv for submit@debbugs.gnu.org; Wed, 20 Jul 2016 16:14:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPxss-0006La-BC for submit@debbugs.gnu.org; Wed, 20 Jul 2016 16:14:23 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPxss-0006LT-85 for submit@debbugs.gnu.org; Wed, 20 Jul 2016 16:14:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPxsp-0002bv-Pr for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 16:14:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPxsk-0006Ki-Pm for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 16:14:17 -0400 Original-Received: from mout.kundenserver.de ([212.227.126.134]:54185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPxsk-0006Kc-G2 for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 16:14:14 -0400 Original-Received: from [172.17.11.203] ([162.223.5.123]) by mrelayeu.kundenserver.de (mreue003) with ESMTPSA (Nemesis) id 0Lbv6m-1ayMq11KxI-00jGAz for ; Wed, 20 Jul 2016 22:14:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 In-Reply-To: X-Provags-ID: V03:K0:KXuLHgwfb7M2O6+qZazgMIMGWW+JaW1paKvvqurCIWZn37PDmjW 5ptmQ2uaXhz9YC3hjluTKbSja5L7i57J0LFWf+BCvZsjlo31RDIbFyPTmuwEHDCIXhdQEI1 unE39PPVdgpilNDvLVkLeMsFPRHikCS/HPlJ9bSQmQ/u3u2YoUzvoN8WZ9bkDafpB9gflh2 KHJg1LH5QWbaQvFVLvBpQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:3t4I5eEq3ZE=:m3ittz3YbJ90B9JpTgmqan k8PBLgS1CisDXyPlaLXxHYrBgFl2VgEsSSIGLrBRmCn3FHbJ38OdpausgVvsT060VU+HSDROS 3Hwxm3PikvcUAIRetz3VgpmefwfLlyzCADGEEhNXYeIwo+cxPkD028b+v7JRt7I5M3CEmCENq CB8RQNXFyq3sM2q7ws0NPprLVX+0BRqNm2OUHeIKW7FVrX3pFY6OJPN5xCQztV2cSpT2oHRWD n4hrGJnSGYeVc8P7ChFScDQUS1oTrSDaSmyIgpe89S4viEiACAzm5jobzlHOmAyfikZQNUXeP 2uHhphu692m91txnIoJ9RjasB2kqgKLPSrT2qCyE9wPvCtiQ2B28DJnFU99Z8i8fq81k3Cdfn Rmu65DB0eYW1jUDU3B6twkco0P8vohENmbb4WoC/flUm2G9vVKXjdXwjHipc/WS9BzPxZtxnE P8XU9vDOaddX20ZWIZvFJy25iYDM/gr3KV1N8YZ2bLKMjpEwB4FegG2dDzh/NHl8yrgJ271pl EaopP7u9OJ+ogwXlCNFoQh869EOYcHumTX3Jnpw1lfaMHL2ioAHhkPCfhr1jpdUOMXvb2dlD/ hy/sUgURgkp7QBrtUwp8fO6CtVfUxPWRRL+4co8FUH10w/hjzEcgAewZhkzjl8azCNjH4bjjY 6VuNDyHnlJBr+g7+m1I6jwbPIvslqQizLb2AJVaQ326P3Sjn/6SSh9PTlINEwK4mUffw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121332 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qdEk6ppwH0UwWLn5oXLlk5nd5e9cH3Xtj Content-Type: multipart/mixed; boundary="hM7gtQaTd9P7F3TsPCXqPdUd1Jh4KhGJM" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: bug-gnu-emacs@gnu.org Message-ID: Subject: Re: bug#24035: 25.1.50; Eww breaks on images? References: In-Reply-To: --hM7gtQaTd9P7F3TsPCXqPdUd1Jh4KhGJM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-07-20 11:35, Kaushal Modi wrote: > OK, cool! >=20 > How did you figure that out? Also how did shr get incorrectly compiled?= =20 shr calls setf on (image-property). That will only work if there's a sett= er defined for image-property; otherwise, the setf macro will be expanded= incorrectly at compile time. That setter is only available if image has = been loaded. > So then, this commit ( http://git.savannah.gnu.org/cgit/emacs.git/commi= t/?id=3D90fb0b2d13d0f44ecb9606587681cb4d8a6f0225 ) should not be needed. I think this is the right fix. shr does require image to be loaded for th= e setf to compile properly. Thus the dependency explicit is the right thi= ng to do (I think). Cheers, Cl=C3=A9ment. --hM7gtQaTd9P7F3TsPCXqPdUd1Jh4KhGJM-- --qdEk6ppwH0UwWLn5oXLlk5nd5e9cH3Xtj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXj9uFAAoJEPqg+cTm90wjkTcQAKI9zl9wBrTJAR1e22oN2Fm0 L/QLH1FgkdDASHrJ2k0bWXbfy7iyJgu64sdkYLtk20i2TA5P9ThUBOP9OI5zDmeN X7Jk1aGhaXDg02yZy2/UN4GmjMKh1Ew9muzcIRa65poXgjTN9A8yfNxXUHvWr8Iq uPF9mudxXHm2LQOiQIbxaXYhrNcsCUOv0MhNqNJaCl29r44sGDuDpzvDs7L8EgKM +p3JwAtlIx2h+ERy0nQWs6qLR9pfjzxjkIAbVPWEDbEPURx5Gp6FrdEEACoIqj80 8/yjmLZYK7FEgXxnqC9ZrH7S/u8dxGFWKmCoWSf7/fJk8TuI8PGnT+rwdQGCYR+q O7jb3SYrb8Pej2MfYArp9llVGCde0SWpZv0J23Q57D4tFzbOZiyEwVDkqPu+U2AB AZkR/KPMflWd8YAq/ChODdsAKz6YBkE/iwXe7ttVFcT6p4EO/6Pv80ouYKGWKPTv kd91V+VJ2O5Nortzj1nHnDzNm3PNMdecN1J1Dy1Fy77LnPNBA6B9IIIQEe2zKSwP RqvxKCEqC+yNLvNPbaT7d1c0SRFD7y50E95DfmJWY4+DjkqQhD2h74UuWwmMqnGC 3llAXqdPJSTP2P/ZyUBaiJPqD5Ka8nTltB3sdjd6FPzIdRwrfrQDFoj/CbzSEaOl QDWinzRxo6b97DOhqde1 =LFTn -----END PGP SIGNATURE----- --qdEk6ppwH0UwWLn5oXLlk5nd5e9cH3Xtj--