From: "Clément Pit--Claudel" <clement.pit@gmail.com>
To: 24035@debbugs.gnu.org
Subject: bug#24035: 25.1.50; Eww breaks on images?
Date: Wed, 20 Jul 2016 16:13:57 -0400 [thread overview]
Message-ID: <fa1a7cb2-f9c6-efe2-fff4-8274c6f43ae7@gmail.com> (raw)
In-Reply-To: <CAFyQvY3Uo9ruuHu=grDmYX4BDeQ=fKiRnDeCq4otck95FVEcXA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 710 bytes --]
On 2016-07-20 11:35, Kaushal Modi wrote:
> OK, cool!
>
> How did you figure that out? Also how did shr get incorrectly compiled?
shr calls setf on (image-property). That will only work if there's a setter defined for image-property; otherwise, the setf macro will be expanded incorrectly at compile time. That setter is only available if image has been loaded.
> So then, this commit ( http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=90fb0b2d13d0f44ecb9606587681cb4d8a6f0225 ) should not be needed.
I think this is the right fix. shr does require image to be loaded for the setf to compile properly. Thus the dependency explicit is the right thing to do (I think).
Cheers,
Clément.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-20 20:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 13:49 bug#24035: 25.1.50; Eww breaks on images? Clément Pit--Claudel
2016-07-20 13:58 ` Lars Ingebrigtsen
2016-07-20 14:37 ` Clément Pit--Claudel
2016-07-20 14:46 ` Lars Ingebrigtsen
2016-07-20 14:54 ` Clément Pit--Claudel
2016-07-20 14:57 ` Lars Ingebrigtsen
2016-07-20 15:07 ` Clément Pit--Claudel
2016-07-20 15:11 ` Lars Ingebrigtsen
2016-07-20 15:17 ` Kaushal Modi
2016-07-20 15:25 ` Kaushal Modi
2016-07-20 15:32 ` Clément Pit--Claudel
2016-07-20 15:35 ` Kaushal Modi
2016-07-20 20:13 ` Clément Pit--Claudel [this message]
2016-07-20 15:55 ` Lars Ingebrigtsen
2016-07-20 16:31 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1a7cb2-f9c6-efe2-fff4-8274c6f43ae7@gmail.com \
--to=clement.pit@gmail.com \
--cc=24035@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.