From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.devel Subject: Re: Which face to use for highlighting interpolation delimiters? Date: Fri, 06 Jan 2023 02:56:33 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7265"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 06 03:57:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDcvF-0001ft-OT for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Jan 2023 03:57:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDcuU-0007HU-9c; Thu, 05 Jan 2023 21:56:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDcuS-0007HD-6w for emacs-devel@gnu.org; Thu, 05 Jan 2023 21:56:44 -0500 Original-Received: from mail-4018.proton.ch ([185.70.40.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDcuO-00012A-RR for emacs-devel@gnu.org; Thu, 05 Jan 2023 21:56:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1672973797; x=1673232997; bh=kJ/8l5M/QEzuDaCy1epPfwGPGAaOSc8VMkqd5P9ss0w=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ckizlOuMeW9BA3rYmPCJnyXsbS6+0+zZ6bZZbsOQlGKuLRIGVu3ySNB/26S6YVVby ZfalXMdrsbSvLP0lqFqev5IMvOVJ9+2ysS1h1WIu/FC4XJse09YtDq2s8bXrgnOp8e CwS0lZrg4pEVYXUvSGvWPqVyrGCQDjfg35SrUjT/EtAB6+X9wpLBXekfGsIckQUyWO ENqh+7nwTYPN20wdnJig2LEPxREAmmUNoze7tMJGm/04XJSwERIG9p8yWYiW/QFtGB UZ1aajsqCzKVmrMh4CLfl+ZGbNG/zLHKgY5W0FN1TZLypt0di6iQnBXm4Wd83Rw2Jc Bx5m4nRH3rApA== In-Reply-To: Feedback-ID: 44397038:user:proton Received-SPF: pass client-ip=185.70.40.18; envelope-from=dev@rjt.dev; helo=mail-4018.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302241 Archived-At: On Thursday, January 5th, 2023 at 20:53, Dmitry Gutov wr= ote: >=20 > E.g. ${ and } in "String literal with #{var} in the middle". >=20 > So far it seems that the ts modes haven't managed to agree on one yet. >=20 > js-ts-mode uses font-lock-delimiter-face, and > typescript-ts-mode uses font-lock-builtin-face (for template_substitution= ). >=20 > Maybe we need a new one. I think font-lock-misc-punctuation-face should be used for those. >=20 > While we're at it, maybe a face for regexps literals as well? Sure.