all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Adam Porter <adam@alphapapa.net>
To: sebastian@sebasmonia.com
Cc: eliz@gnu.org, emacs-devel@gnu.org, jporterbugs@gmail.com
Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer
Date: Wed, 2 Oct 2024 19:20:52 -0500	[thread overview]
Message-ID: <f9b3dc4e-3d02-4df4-92fe-5aa33e3e8fcf@alphapapa.net> (raw)
In-Reply-To: <thqna5fmmzte.fsf@sebasmonia.com>

Hi Sebastián,

> Sebastián Monía <sebastian@sebasmonia.com> writes:
> 
>> Jim Porter <jporterbugs@gmail.com> writes:
>>
>>> On 9/20/2024 8:06 AM, Sebastián Monía wrote:
>>>> If not, I will convert it to tabulated-list (or vtable), only
>>>> disadvantage I see, is that it would change the internals of the buffer
>>>> list quite a bit. I don't expect anyone to rely on them, though.
>>>
>>> I think a tabulated list would be fine.
>>
>> I included below a patch that does this
>>
>>> Your other earlier suggestion of splitting 'eww-list-buffers' in three
>>> also makes sense to me though. Then one of the functions could be
>>> 'eww-buffer-list' (which returns a list of EWW buffers), just like how
>>> we have 'buffer-list' and 'list-buffers' in Emacs.
>>
>> I read this just now :(
>> I can add it in a subsequent patch.
>>
>> BTW, 'eww-bookmark-mode' could also use a tabulated list.
>> I use the eww specific bookmarks or some pages (and "general" bookmarks
>> for others, everyone has their workflows I guess).
>>
>> If you all think it is worth it, I can make a similar change to this one
>> for bookmarks. And add 'eww-list-buffers' too.
> 
> Hello!
> Reviving this thread before attempting the bookmark changes - just in
> case there's some feedback on the tabulated list setup and usage.

A list buffer for EWW bookmarks sounds useful, but I'd suggest using the 
newer Vtable library rather than tabulated-list.  :)

--Adam



  reply	other threads:[~2024-10-03  0:20 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16 17:28 [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Sebastián Monía
2024-08-16 17:48 ` Eli Zaretskii
2024-08-16 18:55   ` Sebastián Monía
2024-08-17 12:35     ` Sebastián Monía
2024-08-24  8:42       ` Eli Zaretskii
2024-08-24 17:27         ` Jim Porter
2024-08-30 20:01           ` Sebastián Monía
2024-09-14  7:32             ` Eli Zaretskii
     [not found]               ` <thqnjzf7s74l.fsf@sebasmonia.com>
2024-09-20  6:18                 ` Eli Zaretskii
2024-09-20 15:06                   ` Sebastián Monía
2024-09-20 17:43                     ` Jim Porter
2024-09-21  2:14                       ` Sebastián Monía
2024-10-02 12:53                         ` Sebastián Monía
2024-10-03  0:20                           ` Adam Porter [this message]
2024-10-03  3:17                             ` Sebastián Monía
2024-10-03  4:05                               ` Jim Porter
2024-10-03 12:47                                 ` Sebastián Monía
2024-10-03 23:41                                   ` Adam Porter
2024-10-11 22:14                                     ` Sebastián Monía
2024-10-12  8:05                                       ` Eli Zaretskii
2024-10-12 18:56                                         ` Jim Porter
2024-10-14  1:06                                         ` Sebastián Monía
2024-10-14  2:39                                           ` Adam Porter
2024-10-14  4:06                                             ` Sebastián Monía
2024-10-15  0:08                                               ` Adam Porter
2024-10-15  2:39                                                 ` Sebastián Monía
2024-10-15  4:04                                                   ` Adam Porter
2024-10-14  4:05                                           ` Jim Porter
2024-10-15  2:59                                             ` Sebastián Monía
2024-10-15  4:01                                               ` Adam Porter
     [not found]                                                 ` <thqnh69apzgp.fsf@sebasmonia.com>
2024-10-19 20:51                                                   ` Sebastián Monía
2024-10-20 17:50                                                     ` Jim Porter
2024-10-21  1:57                                                       ` Sebastián Monía
2024-10-03 21:58                         ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9b3dc4e-3d02-4df4-92fe-5aa33e3e8fcf@alphapapa.net \
    --to=adam@alphapapa.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=sebastian@sebasmonia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.