From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master 38fb5f4: Make make-dist more automatic Date: Sat, 2 Feb 2019 19:27:02 -0800 Organization: UCLA Computer Science Department Message-ID: References: <20190201234220.19088.3350@vcs0.savannah.gnu.org> <20190201234221.F285C205D8@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="141190"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 03 04:27:56 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gq8Ro-000aXb-ET for ged-emacs-devel@m.gmane.org; Sun, 03 Feb 2019 04:27:56 +0100 Original-Received: from localhost ([127.0.0.1]:50769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gq8Rn-00017r-Ev for ged-emacs-devel@m.gmane.org; Sat, 02 Feb 2019 22:27:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gq8R0-00017g-Nw for emacs-devel@gnu.org; Sat, 02 Feb 2019 22:27:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gq8R0-000251-1f for emacs-devel@gnu.org; Sat, 02 Feb 2019 22:27:06 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:56150) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gq8Qz-00023r-Ry; Sat, 02 Feb 2019 22:27:05 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 91DB316112B; Sat, 2 Feb 2019 19:27:03 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 7-p_vXUjzTrJ; Sat, 2 Feb 2019 19:27:02 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BC80316116D; Sat, 2 Feb 2019 19:27:02 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9rz8PXwwewSb; Sat, 2 Feb 2019 19:27:02 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 92D2C160FF9; Sat, 2 Feb 2019 19:27:02 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232918 Archived-At: Glenn Morris wrote: > I like the simplification, but I have some issues with the MANIFEST file. Yes, it's a bit of a wart. > 1) I don't think it should be linked to --no-update. The MANIFEST file > is fundamental to creating a tar file and it needs to be up-to-date. > As it stands, if you use --no-update you can easily end up with a stale > MANIFEST file and a broken tar file. If it does need to be optional, > please can it have a separate eg --no-update-manifest option. It would be easy to change make-dist to rebuild MANIFEST regardless of --no-update, and I don't see any problem with that. > 2) Running make-dist leaves a top-level MANIFEST file that nothing ever > deletes. Since in the vast majority of the time this file will be an > automatically generated file, I think it would be better to use a > temporary file. This also takes care of point 1. > > Here's a possible patch. > This excludes itself MANIFEST from the tar file. > It could be re-added, but I don't know what the point would be. The point of shipping MANIFEST is to handle the following situation: 1. User gets an Emacs tarball and extracts it. 2. User changes the source code. 2. User runs "make dist". Without the MANIFEST file, step (3) would fail because no Git repository is available to tell make-dist the names of most of the source files. If it's OK for us to say, "You must have a Git repository in order to make a distribution" then we can dispense with shipping a MANIFEST file; we might even be able to dispense from generate a manifest file at all, even a temporary one. But if we want to decouple having Git from the ability to make a distribution, we'll need something like a MANIFEST file (unless we want to go back to the old approach of listing files in make-dist itself, which was error-prone).