bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[gbiotti]

*** E-Mail body has been placed on clipboard, please paste it here! ***



1 - Using Emacs for Windows
https://alpha.gnu.org/gnu/emacs/pretest/windows/emacs-27/emacs-27.1-x86_64.zip
2 - Unzip in C:\Emacs so that the Emacs bin directory is
     C:\emacs\emacs-27.1-x86_64\bin
3 - Exec emacs -Q
4 - Open splash.svg:
     C-x C-f 
C:\emacs\emacs-27.1-x86_64\share\emacs\27.1\etc\images\splash.svg

The image is opened as XML text file (nXML Valid Image) and not rendered as
an image as expected.

Version 26.3 (windows) works ok and splash.svg is rendered as image.






In GNU Emacs 27.1 (build 1, x86_64-w64-mingw32)
  of 2020-08-12 built on CIRROCUMULUS
Repository revision: 86d8d76aa36037184db0b2897c434cdaab1a9ae8
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.18362
System Description: Microsoft Windows 10 Pro (v10.0.1903.18362.1016)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

For information about GNU Emacs and the GNU system, type C-h C-a.
Checking for load-path shadows...
Checking 540 files in c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp...
Checking 82 files in c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/vc...
Checking 64 files in c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/url...
Checking 93 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/textmodes...
Checking 168 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/progmodes...
Checking 50 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/play...
Checking 249 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/org...
Checking 44 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/nxml...
Checking 145 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/net...
Checking 50 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/mh-e...
Checking 86 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/mail...
Checking 1 files in c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/leim...
Checking 78 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/language...
Checking 77 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/international...
Checking 8 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/image...
Checking 205 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/gnus...
Checking 57 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/eshell...
Checking 71 files in c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/erc...
Checking 34 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/emulation...
Checking 180 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/emacs-lisp...
Checking 24 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/cedet...
Checking 59 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/calendar...
Checking 87 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/calc...
Checking 113 files in 
c:/emacs/emacs-27.1-x86_64/share/emacs/27.1/lisp/obsolete...
Checking for load-path shadows...done
Mark set [3 times]
Auto-saving...done
C-c c is undefined
Quit [2 times]
Mark set
C-x <end> is undefined
Quit
Mark activated
Using vacuous schema
Type C-c C-c or C-c C-x to view the image as an image or hex.
Cannot display image: (Invalid image specification)
Auto-saving...done
Mark set [2 times]
Auto-saving...done
Undo
Quit
Mark set
Auto-saving...done
Mark set
next-line: End of buffer [4 times]
Mark set
Auto-saving...done
Mark set


Configured using:
  'configure --without-dbus --host=x86_64-w64-mingw32
  --without-compress-install 'CFLAGS=-O2 -static''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2
HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP

Important settings:
   value of $LANG: ITA
   locale-coding-system: cp1252


Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads w32notify w32 lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 46199 8997)
  (symbols 48 6075 1)
  (strings 32 16888 1526)
  (string-bytes 1 523860)
  (vectors 16 9255)
  (vector-slots 8 123182 9492)
  (floats 8 21 254)
  (intervals 56 220 0)
  (buffers 1000 11))

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[Eli Zaretskii]

> From: "gbiotti@gmail.com" <gbiotti@gmail.com>
> Date: Thu, 13 Aug 2020 11:14:43 +0200
> 
> 1 - Using Emacs for Windows
> https://alpha.gnu.org/gnu/emacs/pretest/windows/emacs-27/emacs-27.1-x86_64.zip
> 2 - Unzip in C:\Emacs so that the Emacs bin directory is
>      C:\emacs\emacs-27.1-x86_64\bin
> 3 - Exec emacs -Q
> 4 - Open splash.svg:
>      C-x C-f 
> C:\emacs\emacs-27.1-x86_64\share\emacs\27.1\etc\images\splash.svg
> 
> The image is opened as XML text file (nXML Valid Image) and not rendered as
> an image as expected.

What does the below display in that Emacs, after you start it with
"emacs -Q"?

  M-: (image-type-available-p 'svg) RET

Also, do you have librsvg-2-2.dll in the same directory as emacs.exe,
and if so, what does the dependency walker
(https://www.dependencywalker.com/) say about its dependency DLLs?

Thanks.

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[gbiotti]

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

Il 15/08/2020 12:39, Eli Zaretskii ha scritto:
>> From: "gbiotti@gmail.com" <gbiotti@gmail.com>
>> Date: Thu, 13 Aug 2020 11:14:43 +0200
>>
>> 1 - Using Emacs for Windows
>> https://alpha.gnu.org/gnu/emacs/pretest/windows/emacs-27/emacs-27.1-x86_64.zip
>> 2 - Unzip in C:\Emacs so that the Emacs bin directory is
>>       C:\emacs\emacs-27.1-x86_64\bin
>> 3 - Exec emacs -Q
>> 4 - Open splash.svg:
>>       C-x C-f
>> C:\emacs\emacs-27.1-x86_64\share\emacs\27.1\etc\images\splash.svg
>>
>> The image is opened as XML text file (nXML Valid Image) and not rendered as
>> an image as expected.
> What does the below display in that Emacs, after you start it with
> "emacs -Q"?
>
>    M-: (image-type-available-p 'svg) RET

It returns nil

> Also, do you have librsvg-2-2.dll in the same directory as emacs.exe,
> and if so, what does the dependency walker
> (https://www.dependencywalker.com/) say about its dependency DLLs?
>
> Thanks.

Sorry but dependency walker always hangs on my pc, I've tryed both 
version, executed with or without admin privileges, even disabled my av. 
Whenever i open a file it hangs.

I've used another tool : https://github.com/lucasg/Dependencies
The program don't have export function. I can only offer a screenshot.


Let me know if I can do anything else.
Tanks.


[-- Attachment #2.1: Type: text/html, Size: 2490 bytes --]

[-- Attachment #2.2: pipkjadkhjldlamh.png --]
[-- Type: image/png, Size: 70577 bytes --]

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[Eli Zaretskii]

> Cc: 42844@debbugs.gnu.org
> From: "gbiotti@gmail.com" <gbiotti@gmail.com>
> Disposition-Notification-To: "gbiotti@gmail.com" <gbiotti@gmail.com>
> Date: Sat, 15 Aug 2020 16:17:06 +0200
> 
> > What does the below display in that Emacs, after you start it with
> > "emacs -Q"?
> >
> >    M-: (image-type-available-p 'svg) RET
> 
> It returns nil

That's a clear sign that SVG images aren't supported in this build.

> > Also, do you have librsvg-2-2.dll in the same directory as emacs.exe,
> > and if so, what does the dependency walker
> > (https://www.dependencywalker.com/) say about its dependency DLLs?
> >
> > Thanks.
> 
> Sorry but dependency walker always hangs on my pc, I've tryed both 
> version, executed with or without admin privileges, even disabled my av. 
> Whenever i open a file it hangs.
> 
> I've used another tool : https://github.com/lucasg/Dependencies
> The program don't have export function. I can only offer a screenshot.

Thanks, the dependencies you show spell out the reason: the
libgio-2.0-0.dll, libglib-2.0-0.dll, and libgobject-2.0-0.dll are
missing from the zip archive.  These are dependencies of librsvg, so
without them SVG will not be supported.

Phillip, could you please look into this?  The missing DLLs should be
added to the bundle.

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[gbiotti]

Il 15/08/2020 17:31, Eli Zaretskii ha scritto:
> Thanks, the dependencies you show spell out the reason: the
> libgio-2.0-0.dll, libglib-2.0-0.dll, and libgobject-2.0-0.dll are
> missing from the zip archive.  These are dependencies of librsvg, so
> without them SVG will not be supported.
>
> Phillip, could you please look into this?  The missing DLLs should be
> added to the bundle.

It turns out that this is not enough.
I copied the three dll from the 26.3 bundle and run the test again:

(image-type-available-p 'svg) => nil

And obviously the svg file is shown as text.

I can make it work only by operating a Frankestein mix between old 26.3
bundle (with deps) and 27.1 bundle (with deps).

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[Eli Zaretskii]

> Cc: 42844@debbugs.gnu.org
> From: "gbiotti@gmail.com" <gbiotti@gmail.com>
> Date: Sat, 15 Aug 2020 19:29:30 +0200
> 
> > Phillip, could you please look into this?  The missing DLLs should be
> > added to the bundle.
> 
> It turns out that this is not enough.
> I copied the three dll from the 26.3 bundle and run the test again:
> 
> (image-type-available-p 'svg) => nil
> 
> And obviously the svg file is shown as text.

Then using the same dependency tool, please look for more missing
DLLs.  There must be others.

> I can make it work only by operating a Frankestein mix between old 26.3
> bundle (with deps) and 27.1 bundle (with deps).

I don't understand what that means, sorry.

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[phillip.lord]

On 2020-08-15 18:44, Eli Zaretskii wrote:
>> Cc: 42844@debbugs.gnu.org
>> From: "gbiotti@gmail.com" <gbiotti@gmail.com>
>> Date: Sat, 15 Aug 2020 19:29:30 +0200
>> 
>> > Phillip, could you please look into this?  The missing DLLs should be
>> > added to the bundle.
>> 
>> It turns out that this is not enough.
>> I copied the three dll from the 26.3 bundle and run the test again:
>> 
>> (image-type-available-p 'svg) => nil
>> 
>> And obviously the svg file is shown as text.
> 
> Then using the same dependency tool, please look for more missing
> DLLs.  There must be others.
> 
>> I can make it work only by operating a Frankestein mix between old 
>> 26.3
>> bundle (with deps) and 27.1 bundle (with deps).
> 
> I don't understand what that means, sorry.

It probably means unpacking the 26.3 deps bundle over Emacs 27.1, or 
some mixture of the two. As the 26.3 bundle had a lot more dependencies 
that's not a surprise. Specifically, the problem is probably the logic 
in Emacs-27.1 that skips glib2 as a dependency. IIRC, that brings in 
python and many other of the packages from msys2 which made Emacs-26.3 
so huge.

The librsvg dependency itself is correctly given when I build the zips 
package.

Phil

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[gbiotti]

Il 16/08/2020 09:40, phillip.lord@russet.org.uk ha scritto:
> It probably means unpacking the 26.3 deps bundle over Emacs 27.1, or 
> some mixture of the two. As the 26.3 bundle had a lot more 
> dependencies that's not a surprise. Specifically, the problem is 
> probably the logic in Emacs-27.1 that skips glib2 as a dependency. 
> IIRC, that brings in python and many other of the packages from msys2 
> which made Emacs-26.3 so huge.
>
> The librsvg dependency itself is correctly given when I build the zips 
> package.
>
> Phil

I've tried to dig more in the dependencies and found two more missing:
libpcre-1.dll
libgmodule-2.0-0.dll

Copied to the bin directory, but it keep opening splash.svg as a text file.
I can't see any missing dependency.
Have you replicated the bug?

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[phillip.lord]

On 2020-08-17 12:02, gbiotti@gmail.com wrote:
> Il 16/08/2020 09:40, phillip.lord@russet.org.uk ha scritto:
>> It probably means unpacking the 26.3 deps bundle over Emacs 27.1, or 
>> some mixture of the two. As the 26.3 bundle had a lot more 
>> dependencies that's not a surprise. Specifically, the problem is 
>> probably the logic in Emacs-27.1 that skips glib2 as a dependency. 
>> IIRC, that brings in python and many other of the packages from msys2 
>> which made Emacs-26.3 so huge.
>> 
>> The librsvg dependency itself is correctly given when I build the zips 
>> package.
>> 
>> Phil
> 
> I've tried to dig more in the dependencies and found two more missing:
> libpcre-1.dll
> libgmodule-2.0-0.dll
> 
> Copied to the bin directory, but it keep opening splash.svg as a text 
> file.
> I can't see any missing dependency.
> Have you replicated the bug?


I haven't. I have limited access to a windows machine at the moment. Are 
you sure the file is okay? You said it works with Emacs-26; I presume on 
the same file?

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[gbiotti]

Il 18/08/2020 00:10, phillip.lord@russet.org.uk ha scritto:
> On 2020-08-17 12:02, gbiotti@gmail.com wrote:
>> Il 16/08/2020 09:40, phillip.lord@russet.org.uk ha scritto:
>>> It probably means unpacking the 26.3 deps bundle over Emacs 27.1, or 
>>> some mixture of the two. As the 26.3 bundle had a lot more 
>>> dependencies that's not a surprise. Specifically, the problem is 
>>> probably the logic in Emacs-27.1 that skips glib2 as a dependency. 
>>> IIRC, that brings in python and many other of the packages from 
>>> msys2 which made Emacs-26.3 so huge.
>>>
>>> The librsvg dependency itself is correctly given when I build the 
>>> zips package.
>>>
>>> Phil
>>
>> I've tried to dig more in the dependencies and found two more missing:
>> libpcre-1.dll
>> libgmodule-2.0-0.dll
>>
>> Copied to the bin directory, but it keep opening splash.svg as a text 
>> file.
>> I can't see any missing dependency.
>> Have you replicated the bug?
>
>
> I haven't. I have limited access to a windows machine at the moment. 
> Are you sure the file is okay? You said it works with Emacs-26; I 
> presume on the same file?
I have double checked it. Same results on splash.svg from Emacs-26 and 
Emacs-27 bundle.
I copied the dll files that where missing come from the Emacs-26 bundle.

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[Pierre Téchoueyres]

Hello Eli,

I've also tested and followed your advice with the dependency walker.
I've found the following missing ddl:
- libffi-7.dll
- libgio-2.0-0.dll
- libglib-2.0-0.dll
- libgmodule-2.0-0.dll
- libgobject-2.0-0.dll
- libpcre-1.dll

don't know why the libffi-7 is needed as there is an libffi-6 in the
directory. But with thoses files I can display SVG images inside emacs.

Pierre

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[gbiotti]

Il 19/08/2020 19:39, Pierre Téchoueyres ha scritto:
> Hello Eli,
>
> I've also tested and followed your advice with the dependency walker.
> I've found the following missing ddl:
> - libffi-7.dll
> - libgio-2.0-0.dll
> - libglib-2.0-0.dll
> - libgmodule-2.0-0.dll
> - libgobject-2.0-0.dll
> - libpcre-1.dll
>
> don't know why the libffi-7 is needed as there is an libffi-6 in the
> directory. But with thoses files I can display SVG images inside emacs.
>
> Pierre

I missed the libffi-7.dll when searching for dependencies.
Now it works for me too.

Tanks.

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[phillip.lord]

On 2020-08-19 18:39, Pierre Téchoueyres wrote:
> Hello Eli,
> 
> I've also tested and followed your advice with the dependency walker.
> I've found the following missing ddl:
> - libffi-7.dll
> - libgio-2.0-0.dll
> - libglib-2.0-0.dll
> - libgmodule-2.0-0.dll
> - libgobject-2.0-0.dll
> - libpcre-1.dll
> 
> don't know why the libffi-7 is needed as there is an libffi-6 in the
> directory. But with thoses files I can display SVG images inside emacs.
> 
> Pierre


Pretty sure all of this stems from 61c2183a440. I dropped using pactree 
and used pacman directly to determine dependencies. I also exclude glib2 
as a dependency hence the problem. If I include this, we go back to 
getting python and half the of msys2 included in the download bundle.

I guess for Emacs-27 I should just include glib2 and be exclude so of 
its dependencies (gettext and python probably). The question is whether 
to do this for Emacs-27.1 or 27.2.


For Emacs-28, I think I need a better dependency mechanism than looking 
at msys2, perhaps based around the shell script that was sent earlier, 
or an automated (or horror manual) use of dependency walker.

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[Eli Zaretskii]

> Date: Wed, 19 Aug 2020 19:33:26 +0100
> From: phillip.lord@russet.org.uk
> Cc: Eli Zaretskii <eliz@gnu.org>, 42844@debbugs.gnu.org, gbiotti@gmail.com
> 
> Pretty sure all of this stems from 61c2183a440. I dropped using pactree 
> and used pacman directly to determine dependencies. I also exclude glib2 
> as a dependency hence the problem. If I include this, we go back to 
> getting python and half the of msys2 included in the download bundle.

Too bad MSYS2 use such a "maximalistic" approach to dependencies.

> I guess for Emacs-27 I should just include glib2 and be exclude so of 
> its dependencies (gettext and python probably).

Something like that, yes.

> The question is whether to do this for Emacs-27.1 or 27.2.

I'd prefer 27.1, of course, if you can afford working on this soon
enough.  Because 27.2 is at least a couple of months away.

> For Emacs-28, I think I need a better dependency mechanism than looking 
> at msys2, perhaps based around the shell script that was sent earlier, 
> or an automated (or horror manual) use of dependency walker.

If you have Binutils installed (which you must, since you build
Emacs), you can find dependencies by recursive application of
objdump.  E.g., the following command will show all the DLLs of all
the binaries in a directory:

    objdump -p *.exe *.dll | fgrep "DLL Name:" | gawk " {print $3, $4, $5}" | sort -u

You need to rerun this each time you add one or more DLLs to the soup,
until all the DLLs you see in the list are present in the directory.

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[phillip.lord]

On 2020-08-19 19:52, Eli Zaretskii wrote:
>> Date: Wed, 19 Aug 2020 19:33:26 +0100
>> From: phillip.lord@russet.org.uk
>> Cc: Eli Zaretskii <eliz@gnu.org>, 42844@debbugs.gnu.org, 
>> gbiotti@gmail.com
>> 
>> Pretty sure all of this stems from 61c2183a440. I dropped using 
>> pactree
>> and used pacman directly to determine dependencies. I also exclude 
>> glib2
>> as a dependency hence the problem. If I include this, we go back to
>> getting python and half the of msys2 included in the download bundle.
> 
> Too bad MSYS2 use such a "maximalistic" approach to dependencies.
> 
>> I guess for Emacs-27 I should just include glib2 and be exclude so of
>> its dependencies (gettext and python probably).
> 
> Something like that, yes.
> 
>> The question is whether to do this for Emacs-27.1 or 27.2.
> 
> I'd prefer 27.1, of course, if you can afford working on this soon
> enough.  Because 27.2 is at least a couple of months away.



Okay. So I have uploaded a new version to alpha. It is about 10Mb larger 
than before, and seems to render using harfbuzz and reports 
(image-type-available-t 'svg) as true. The only change is this:


$ git diff
diff --git a/admin/nt/dist-build/build-dep-zips.py 
b/admin/nt/dist-build/build-dep-zips.py
index 0e5f1ae1dc..0f18fe331d 100755
--- a/admin/nt/dist-build/build-dep-zips.py
+++ b/admin/nt/dist-build/build-dep-zips.py
@@ -48,7 +48,7 @@
  ## Packages to fiddle with
  ## Source for gcc-libs is part of gcc
  SKIP_SRC_PKGS=["mingw-w64-gcc-libs"]
-SKIP_DEP_PKGS=["mingw-w64-x86_64-glib2"]
+SKIP_DEP_PKGS=["mingw-w64-x86_64-python3"]
  
MUNGE_SRC_PKGS={"mingw-w64-libwinpthread-git":"mingw-w64-winpthreads-git"}
  MUNGE_DEP_PKGS={
      "mingw-w64-i686-libwinpthread":"mingw-w64-i686-libwinpthread-git",




So, we still avoid the mega bloat of python, but do pull in glib2.

I would need to install this patch to Emacs-27. This would mean that the 
Emacs-27 binary with deps version was not strictly build form the 
emacs-27.1, but from a slightly later commit. Not a disaster I think -- 
normally the deps file is built from an early version.

I would plan to release this as "emacs-27.1" given that the previous 
binaries were only every uploaded to alpha and not described as 
"official".

Phil

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[Pierre Téchoueyres]

Hello Phillip,
Tested today. Everything seems to work here.
Thank you !

Le vendredi 21 août 2020 à 18:54, phillip.lord@russet.org.uk a écrit :

> On 2020-08-19 19:52, Eli Zaretskii wrote:
>>> Date: Wed, 19 Aug 2020 19:33:26 +0100
>>> From: phillip.lord@russet.org.uk
>>> Cc: Eli Zaretskii <eliz@gnu.org>, 42844@debbugs.gnu.org,
>>> gbiotti@gmail.com
>>> Pretty sure all of this stems from 61c2183a440. I dropped using 
>>> pactree
>>> and used pacman directly to determine dependencies. I also exclude
>>> glib2
>>> as a dependency hence the problem. If I include this, we go back to
>>> getting python and half the of msys2 included in the download bundle.
>> Too bad MSYS2 use such a "maximalistic" approach to dependencies.
>> 
>>> I guess for Emacs-27 I should just include glib2 and be exclude so of
>>> its dependencies (gettext and python probably).
>> Something like that, yes.
>> 
>>> The question is whether to do this for Emacs-27.1 or 27.2.
>> I'd prefer 27.1, of course, if you can afford working on this soon
>> enough.  Because 27.2 is at least a couple of months away.
>
>
>
> Okay. So I have uploaded a new version to alpha. It is about 10Mb
> larger than before, and seems to render using harfbuzz and reports 
> (image-type-available-t 'svg) as true. The only change is this:
>
>
> $ git diff
> diff --git a/admin/nt/dist-build/build-dep-zips.py
> b/admin/nt/dist-build/build-dep-zips.py
> index 0e5f1ae1dc..0f18fe331d 100755
> --- a/admin/nt/dist-build/build-dep-zips.py
> +++ b/admin/nt/dist-build/build-dep-zips.py
> @@ -48,7 +48,7 @@
>  ## Packages to fiddle with
>  ## Source for gcc-libs is part of gcc
>  SKIP_SRC_PKGS=["mingw-w64-gcc-libs"]
> -SKIP_DEP_PKGS=["mingw-w64-x86_64-glib2"]
> +SKIP_DEP_PKGS=["mingw-w64-x86_64-python3"]
>  MUNGE_SRC_PKGS={"mingw-w64-libwinpthread-git":"mingw-w64-winpthreads-git"}
>  MUNGE_DEP_PKGS={
>      "mingw-w64-i686-libwinpthread":"mingw-w64-i686-libwinpthread-git",
>
>
>
>
> So, we still avoid the mega bloat of python, but do pull in glib2.
>
> I would need to install this patch to Emacs-27. This would mean that
> the Emacs-27 binary with deps version was not strictly build form the 
> emacs-27.1, but from a slightly later commit. Not a disaster I think
> -- normally the deps file is built from an early version.
>
> I would plan to release this as "emacs-27.1" given that the previous
> binaries were only every uploaded to alpha and not described as 
> "official".
>
> Phil

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[phillip.lord]

My pleasure, and thank you very much for testing.

Phil

On 2020-08-24 21:48, Pierre Téchoueyres wrote:
> Hello Phillip,
> Tested today. Everything seems to work here.
> Thank you !
> 
> Le vendredi 21 août 2020 à 18:54, phillip.lord@russet.org.uk a écrit :
> 
>> On 2020-08-19 19:52, Eli Zaretskii wrote:
>>>> Date: Wed, 19 Aug 2020 19:33:26 +0100
>>>> From: phillip.lord@russet.org.uk
>>>> Cc: Eli Zaretskii <eliz@gnu.org>, 42844@debbugs.gnu.org,
>>>> gbiotti@gmail.com
>>>> Pretty sure all of this stems from 61c2183a440. I dropped using
>>>> pactree
>>>> and used pacman directly to determine dependencies. I also exclude
>>>> glib2
>>>> as a dependency hence the problem. If I include this, we go back to
>>>> getting python and half the of msys2 included in the download 
>>>> bundle.
>>> Too bad MSYS2 use such a "maximalistic" approach to dependencies.
>>> 
>>>> I guess for Emacs-27 I should just include glib2 and be exclude so 
>>>> of
>>>> its dependencies (gettext and python probably).
>>> Something like that, yes.
>>> 
>>>> The question is whether to do this for Emacs-27.1 or 27.2.
>>> I'd prefer 27.1, of course, if you can afford working on this soon
>>> enough.  Because 27.2 is at least a couple of months away.
>> 
>> 
>> 
>> Okay. So I have uploaded a new version to alpha. It is about 10Mb
>> larger than before, and seems to render using harfbuzz and reports
>> (image-type-available-t 'svg) as true. The only change is this:
>> 
>> 
>> $ git diff
>> diff --git a/admin/nt/dist-build/build-dep-zips.py
>> b/admin/nt/dist-build/build-dep-zips.py
>> index 0e5f1ae1dc..0f18fe331d 100755
>> --- a/admin/nt/dist-build/build-dep-zips.py
>> +++ b/admin/nt/dist-build/build-dep-zips.py
>> @@ -48,7 +48,7 @@
>>  ## Packages to fiddle with
>>  ## Source for gcc-libs is part of gcc
>>  SKIP_SRC_PKGS=["mingw-w64-gcc-libs"]
>> -SKIP_DEP_PKGS=["mingw-w64-x86_64-glib2"]
>> +SKIP_DEP_PKGS=["mingw-w64-x86_64-python3"]
>>  
>> MUNGE_SRC_PKGS={"mingw-w64-libwinpthread-git":"mingw-w64-winpthreads-git"}
>>  MUNGE_DEP_PKGS={
>>      
>> "mingw-w64-i686-libwinpthread":"mingw-w64-i686-libwinpthread-git",
>> 
>> 
>> 
>> 
>> So, we still avoid the mega bloat of python, but do pull in glib2.
>> 
>> I would need to install this patch to Emacs-27. This would mean that
>> the Emacs-27 binary with deps version was not strictly build form the
>> emacs-27.1, but from a slightly later commit. Not a disaster I think
>> -- normally the deps file is built from an early version.
>> 
>> I would plan to release this as "emacs-27.1" given that the previous
>> binaries were only every uploaded to alpha and not described as
>> "official".
>> 
>> Phil

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[Lars Ingebrigtsen]

Pierre Téchoueyres <pierre.techoueyres@free.fr> writes:

> Hello Phillip,
> Tested today. Everything seems to work here.
> Thank you !

Thanks for testing -- I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[Pierre Téchoueyres]

Le mercredi 19 août 2020 à 19:33, phillip.lord@russet.org.uk a écrit :

> On 2020-08-19 18:39, Pierre Téchoueyres wrote:
>> Hello Eli,
>> I've also tested and followed your advice with the dependency
>> walker.
>> I've found the following missing ddl:
>> - libffi-7.dll
>> - libgio-2.0-0.dll
>> - libglib-2.0-0.dll
>> - libgmodule-2.0-0.dll
>> - libgobject-2.0-0.dll
>> - libpcre-1.dll
>> don't know why the libffi-7 is needed as there is an libffi-6 in the
>> directory. But with thoses files I can display SVG images inside emacs.
>> Pierre
>
>
> Pretty sure all of this stems from 61c2183a440. I dropped using
> pactree and used pacman directly to determine dependencies. I also
> exclude glib2 as a dependency hence the problem. If I include this, we
> go back to getting python and half the of msys2 included in the
> download bundle.
>
> I guess for Emacs-27 I should just include glib2 and be exclude so of
> its dependencies (gettext and python probably). The question is
> whether to do this for Emacs-27.1 or 27.2.
>

From my user side point of view: just add the missing dll in the archive
for 27.1 and let the dust lay on.

I suggest it  because, if like me, your company has and antivirus
software which block some actions on programs without good reputation
you're lock with officials distributions. Lukly Emacs is on the list
...

see https://whitelist.kaspersky.com/advisor

For example, at my work, writing to
c:/windows/system32/drivers/etc/hosts is forbiden for not known
applications like the ones you're compiling yourself (and trust me this
bother me quite a lot).

>
> For Emacs-28, I think I need a better dependency mechanism than
> looking at msys2, perhaps based around the shell script that was sent
> earlier, or an automated (or horror manual) use of dependency walker.

If could help you in testing, ask for it.

bug#42844: 27.1; Emacs 27.1: SVG file not rendered as image

[Eli Zaretskii]

> From: Pierre Téchoueyres <pierre.techoueyres@free.fr>
> Cc: "gbiotti@gmail.com" <gbiotti@gmail.com>,  42844@debbugs.gnu.org
> Date: Wed, 19 Aug 2020 19:39:41 +0200
> 
> Hello Eli,
> 
> I've also tested and followed your advice with the dependency walker.
> I've found the following missing ddl:
> - libffi-7.dll
> - libgio-2.0-0.dll
> - libglib-2.0-0.dll
> - libgmodule-2.0-0.dll
> - libgobject-2.0-0.dll
> - libpcre-1.dll

Thanks.

> don't know why the libffi-7 is needed as there is an libffi-6 in the
> directory.

They are different versions of libffi with incompatible ABI, so
libffi-6 cannot replace libffi-7.