From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Wed, 31 Aug 2022 19:41:47 +0300 Message-ID: References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> <86zgfknc9a.fsf@mail.linkov.net> <7b11b61f-c70d-7079-9bb2-7069a6e0170b@yandex.ru> <86ler4laek.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2554"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: Po Lu , "Alfred M. Szmidt" , eliz@gnu.org, larsi@gnus.org, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 18:44:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTQp8-0000UV-0z for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 18:44:18 +0200 Original-Received: from localhost ([::1]:43634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTQp6-0003Ec-QN for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 12:44:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTQnL-0001KD-0I for emacs-devel@gnu.org; Wed, 31 Aug 2022 12:42:27 -0400 Original-Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:53005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTQnJ-00053k-8w; Wed, 31 Aug 2022 12:42:26 -0400 Original-Received: by mail-wm1-x329.google.com with SMTP id k17so7670816wmr.2; Wed, 31 Aug 2022 09:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=NuBnPgmrnWEML3ZRphmlKrN1rJpj1iVxdi7B0RU9nTg=; b=b7nj1Um9TSiQ2r47PZjkjdonFtyCtDlNYUvAM3LNpjW90eG/JUpDSmzHcUTP0VKkUb xin6+nuSVHSiVtIWybHPmjEJ0/H1julgLOgDbFMXLxkjOWUHA2niT/X0ch/1HyMu18nr R3oox4Fd2qn11a5SOv8ariGh7i9F6Oz9wLxjiqefEWv/ZyKdlnd5JkPknL8xx7UOzakV U/6bideZn7kJTxJhCUeFzKEbNI3rJ8wr6XHQbnrLkt6PU4HaBuWZ4+rPb+WGRt8jH+BG sSPcj2vxeG6ygtpkkVHj+GafB3B+76TeKJc1bLrVvVI8EjGBYUChzze//l0SSxeiMcTY 7T3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=NuBnPgmrnWEML3ZRphmlKrN1rJpj1iVxdi7B0RU9nTg=; b=yhqpjdd0WEB/aBBCQQ49B8ZGyg1FLyhI2Ba/9UzJeNVypevuAJlNdOSEuYLJdTm6bL T24hX+rT67TbN51uNSgVsxN0mrzhe9YlOs8yhRTOs+3uuN/DpEuZnXUL1hR+XT+shRXW DJ/2u1jV2PHZX1z3/IzeeJjqu8rRnFC/rnb4Nog7CDlgwGgMP+Hnn+xYF4HHEUQY94Ew mfDOsg4wCtBK35eoUTMKLvcUDxCvaDlQuTKmlNdoeaho9LMxcfdHSPRarFM1N/Xm/YQX Zpvd/CHz9/3G9BOWqISqt0+Wi5HZb/4CiLO5XljZP7iA7xuNy4yijL9MxiOYJe986kcB 6a8w== X-Gm-Message-State: ACgBeo20mSssxr2cl1EH0DzIMrQiy37RSD2eB0bjd0Pfp4yzMfLoHiRH +csCk08HODbvW1nKnZNw0Ow= X-Google-Smtp-Source: AA6agR7VWhSMrZ/uj+sCvLKdnCpszN8zMrO4J260VanVn9QGhrRu2NnUIyZExJHgTPgxryaUTjv5DQ== X-Received: by 2002:a05:600c:1497:b0:3a5:f608:d765 with SMTP id c23-20020a05600c149700b003a5f608d765mr2462331wmh.19.1661964109530; Wed, 31 Aug 2022 09:41:49 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p17-20020a5d6391000000b0022511d35d5bsm12943700wru.12.2022.08.31.09.41.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 09:41:49 -0700 (PDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=raaahh@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294444 Archived-At: On 31.08.2022 19:21, Dmitry Gutov wrote: > On 31.08.2022 19:06, Juri Linkov wrote: >>> But a loop is necessary because the diff can have more than one hunk, >>> isn't >>> it? >> A loop is necessary indeed.  The problem is that I tried it with Bzr, >> but it has such a bug that `bzr diff` adds an extra line at the end, >> so it's not (eobp) after the last diff hunk.  After removing the >> final newline in the*vc-diff*  buffer the loop can be finished. > > Hmm, so how do we apply the full diff in a backend-agnostic fashion? > > Should we delegate to 'patch', then? And require it to be installed. I suppose we could check whether every diff-apply-hunk advances point, though.