From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error Date: Tue, 22 Sep 2020 13:44:36 -0700 (PDT) Message-ID: References: <87zh5xiuk4.fsf@localhost>> <831rj9k79b.fsf@gnu.org>> > <83sgbpiqa7.fsf@gnu.org>> <87mu1xa380.fsf@mail.linkov.net>> <83imclii71.fsf@gnu.org>> <87wo1178cn.fsf@mail.linkov.net>> <83d02tifi3.fsf@gnu.org>> <87ft7cx6kh.fsf@localhost>> <83bli027is.fsf@gnu.org>> <498f6be5-f1ab-4f82-9cf1-ed5893f10ea1@default> <87wo0nbln5.fsf@mail.linkov.net> <6e21964e-a580-45ef-943f-a8ea97e58eef@default> <87sgbadxr9.fsf@mail.linkov.net> <090c6fc6-92b9-4604-bb14-e19287dd6685@default> <87eemt7gob.fsf_-_@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24857"; mail-complaints-to="usenet@ciao.gmane.io" To: Juri Linkov , 43569@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 22 22:45:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKp9z-0006KL-S8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 22:45:11 +0200 Original-Received: from localhost ([::1]:50540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKp9y-00053g-PW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 16:45:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKp9r-00053X-43 for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 16:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50261) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKp9q-0002dh-Od for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 16:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kKp9q-0001KQ-F1 for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 16:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Sep 2020 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43569 X-GNU-PR-Package: emacs Original-Received: via spool by 43569-submit@debbugs.gnu.org id=B43569.16008074915071 (code B ref 43569); Tue, 22 Sep 2020 20:45:02 +0000 Original-Received: (at 43569) by debbugs.gnu.org; 22 Sep 2020 20:44:51 +0000 Original-Received: from localhost ([127.0.0.1]:33574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKp9f-0001Jg-2s for submit@debbugs.gnu.org; Tue, 22 Sep 2020 16:44:51 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:55872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKp9a-0001JP-7W for 43569@debbugs.gnu.org; Tue, 22 Sep 2020 16:44:49 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08MKdHMV159303; Tue, 22 Sep 2020 20:44:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=p901enJqImzWLAQnUHKnhLk/TwaxSJT3ug8N5MXyuxk=; b=sOKJf4Lma5Y39xqjxswRL6ayOMjmczUk0C7J4uTrdmQ+uvDcCb6Q2CReRhU/A3cKcCca fFfTEBGpobEZ8jykOmJyWs0NC8uW7vnXjEaiTObwfpyEdNpSq7yscCAmczBrdVKjSBE8 937JSLWtPr4eHR03/qcltzHvIGFksE7SYYu0JeC3/b2iV79SSNoFjVMxLYF8qYfV38xD ssq7V9SNyOC80t07C8MIUQ1nXGgC4Om8fqPjQeDwYWLsolhXxuaqVnRQpR02cFxB6LOq vxZ+K6B3hlmiHkYb1/KNFuYE/quakgp5IzXDNVUz6XHxrKXZxOejEipbGJRfWXlzFfpf 6Q== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 33q5rgdequ-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 22 Sep 2020 20:44:40 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08MKfMcO052174; Tue, 22 Sep 2020 20:44:39 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 33nuwyyhx8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Sep 2020 20:44:39 +0000 Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08MKibIo000441; Tue, 22 Sep 2020 20:44:37 GMT In-Reply-To: <87eemt7gob.fsf_-_@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009220161 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 impostorscore=0 clxscore=1011 suspectscore=0 phishscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009220161 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188748 Archived-At: > >> I think "Continue Tags Search" should be disabled when it has no effec= t. > > > > I've done that now, in menu-bar+.el. I use this, but > > perhaps someone can let me know if it's not the right, > > or best, condition to use. (I use condition-case, not > > ignore-errors, for compatibility with older Emacs.) > > > > :enable (not (condition-case nil > > (tags-loop-eval tags-loop-scan) > > (error t))) >=20 > I tried this, but it doesn't enable "Continue Tags Search" > after starting "Search Tagged Files...". And I don't know > what else could be checked. I think the xref changes broke the use of the tags code. You can use `M-x tags-loop-continue'. I think that :enable code should work - and it does work for Emacs < 27. But you're right that it no longer works. Looks like the code for the tags-search feature was changed partially, and stuff was declared obsolete (which shouldn't have been done, IMO). * Xref as an alternative is one thing - OK. * Xref as the new default is another thing - OK, but not my preference. * Xref stealing the same keys is yet another thing - Not OK, IMO. * But declaring the tags functionality and code to be obsolete is KO, IMO. Overzealous NIH'ism, I expect. Users should have both tags and xref available, as equals. Guess I'll have to :enable that menu item unconditionally for Emacs 27 and later (and leave it conditional for Emacs before the breakage): (define-key menu-bar-search-tags-menu [tags-continue] '(menu-item "Continue Tags Search/Replace" tags-loop-continue :help "Continue last tags search or replace operation" :enable (or (> emacs-major-version 26) (not (condition-case nil (tags-loop-eval tags-loop-scan) (error t))))))